From 4e195d1dc14b567172b319de2c6b658bf36d0c7b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 25 Jun 2026 22:28:29 +0000 Subject: [PATCH 1/2] Bump the bundler group with 11 updates Bumps the bundler group with 11 updates: | Package | From | To | | --- | --- | --- | | [bigdecimal](https://github.com/ruby/bigdecimal) | `4.0.1` | `4.1.2` | | [code_ownership](https://github.com/rubyatscale/code_ownership) | `2.1.1` | `2.1.3` | | [packwerk](https://github.com/Shopify/packwerk) | `3.2.3` | `3.3.0` | | [sorbet-runtime](https://github.com/sorbet/sorbet) | `0.6.12992` | `0.6.13312` | | [rake](https://github.com/ruby/rake) | `13.3.1` | `13.4.2` | | [rubocop](https://github.com/rubocop/rubocop) | `1.85.1` | `1.88.0` | | [rubocop-gusto](https://github.com/gusto/rubocop-gusto) | `10.6.0` | `11.1.1` | | [sorbet](https://github.com/sorbet/sorbet) | `0.6.12992` | `0.6.13312` | | [sorbet-static](https://github.com/sorbet/sorbet) | `0.6.12992` | `0.6.13312` | | [spoom](https://github.com/Shopify/spoom) | `1.7.11` | `1.8.2` | | [tapioca](https://github.com/Shopify/tapioca) | `0.17.10` | `0.19.2` | Updates `bigdecimal` from 4.0.1 to 4.1.2 - [Release notes](https://github.com/ruby/bigdecimal/releases) - [Changelog](https://github.com/ruby/bigdecimal/blob/master/CHANGES.md) - [Commits](https://github.com/ruby/bigdecimal/compare/v4.0.1...v4.1.2) Updates `code_ownership` from 2.1.1 to 2.1.3 - [Release notes](https://github.com/rubyatscale/code_ownership/releases) - [Commits](https://github.com/rubyatscale/code_ownership/compare/v2.1.1...v2.1.3) Updates `packwerk` from 3.2.3 to 3.3.0 - [Release notes](https://github.com/Shopify/packwerk/releases) - [Commits](https://github.com/Shopify/packwerk/compare/v3.2.3...v3.3.0) Updates `sorbet-runtime` from 0.6.12992 to 0.6.13312 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `rake` from 13.3.1 to 13.4.2 - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/v13.3.1...v13.4.2) Updates `rubocop` from 1.85.1 to 1.88.0 - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.85.1...v1.88.0) Updates `rubocop-gusto` from 10.6.0 to 11.1.1 - [Release notes](https://github.com/gusto/rubocop-gusto/releases) - [Changelog](https://github.com/Gusto/rubocop-gusto/blob/main/CHANGELOG.md) - [Commits](https://github.com/gusto/rubocop-gusto/compare/v10.6.0...v11.1.1) Updates `sorbet` from 0.6.12992 to 0.6.13312 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-static` from 0.6.12992 to 0.6.13312 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `spoom` from 1.7.11 to 1.8.2 - [Release notes](https://github.com/Shopify/spoom/releases) - [Commits](https://github.com/Shopify/spoom/compare/v1.7.11...v1.8.2) Updates `tapioca` from 0.17.10 to 0.19.2 - [Release notes](https://github.com/Shopify/tapioca/releases) - [Commits](https://github.com/Shopify/tapioca/compare/v0.17.10...v0.19.2) --- updated-dependencies: - dependency-name: bigdecimal dependency-version: 4.1.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: bundler - dependency-name: code_ownership dependency-version: 2.1.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: bundler - dependency-name: packwerk dependency-version: 3.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: bundler - dependency-name: sorbet-runtime dependency-version: 0.6.13312 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: bundler - dependency-name: rake dependency-version: 13.4.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: bundler - dependency-name: rubocop dependency-version: 1.88.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: bundler - dependency-name: rubocop-gusto dependency-version: 11.1.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: bundler - dependency-name: sorbet dependency-version: 0.6.13312 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: bundler - dependency-name: sorbet-static dependency-version: 0.6.13312 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: bundler - dependency-name: spoom dependency-version: 1.8.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: bundler - dependency-name: tapioca dependency-version: 0.19.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: bundler ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 137 +++++++++++++++++++++++++-------------------------- 1 file changed, 67 insertions(+), 70 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index e2046c2..46d00f8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -15,13 +15,13 @@ PATH GEM remote: https://rubygems.org/ specs: - actionview (8.1.2) - activesupport (= 8.1.2) + actionview (8.1.3) + activesupport (= 8.1.3) builder (~> 3.1) erubi (~> 1.11) rails-dom-testing (~> 2.2) rails-html-sanitizer (~> 1.6) - activesupport (8.1.2) + activesupport (8.1.3) base64 bigdecimal concurrent-ruby (~> 1.0, >= 1.3.1) @@ -34,8 +34,6 @@ GEM securerandom (>= 0.3) tzinfo (~> 2.0, >= 2.0.5) uri (>= 0.13.1) - addressable (2.8.9) - public_suffix (>= 2.0.2, < 8.0) ast (2.4.3) base64 (0.3.0) benchmark (0.5.0) @@ -46,90 +44,89 @@ GEM erubi (~> 1.4) parser (>= 2.4) smart_properties - bigdecimal (4.0.1) + bigdecimal (4.1.2) builder (3.3.0) byebug (13.0.0) reline (>= 0.6.0) - code_ownership (2.1.1-aarch64-linux) + code_ownership (2.1.3-aarch64-linux) code_teams (~> 1.0) packs-specification sorbet-runtime (>= 0.6.12763) - code_ownership (2.1.1-arm64-darwin) + code_ownership (2.1.3-aarch64-linux-musl) code_teams (~> 1.0) packs-specification sorbet-runtime (>= 0.6.12763) - code_ownership (2.1.1-x86_64-darwin) + code_ownership (2.1.3-arm64-darwin) code_teams (~> 1.0) packs-specification sorbet-runtime (>= 0.6.12763) - code_ownership (2.1.1-x86_64-linux) + code_ownership (2.1.3-x86_64-darwin) code_teams (~> 1.0) packs-specification sorbet-runtime (>= 0.6.12763) - code_ownership (2.1.1-x86_64-linux-musl) + code_ownership (2.1.3-x86_64-linux) + code_teams (~> 1.0) + packs-specification + sorbet-runtime (>= 0.6.12763) + code_ownership (2.1.3-x86_64-linux-musl) code_teams (~> 1.0) packs-specification sorbet-runtime (>= 0.6.12763) code_teams (1.3.0) sorbet-runtime coderay (1.1.3) - concurrent-ruby (1.3.6) + concurrent-ruby (1.3.7) connection_pool (3.0.2) constant_resolver (0.3.0) - crass (1.0.6) + crass (1.0.7) diff-lcs (1.6.2) drb (2.2.3) erubi (1.13.1) - i18n (1.14.8) + i18n (1.15.2) concurrent-ruby (~> 1.0) io-console (0.8.2) - json (2.18.1) - json-schema (6.1.0) - addressable (~> 2.8) - bigdecimal (>= 3.1, < 5) + json (2.20.0) language_server-protocol (3.17.0.5) lint_roller (1.1.0) logger (1.7.0) - loofah (2.25.0) + loofah (2.25.1) crass (~> 1.0.2) nokogiri (>= 1.12.0) - mcp (0.8.0) - json-schema (>= 4.1) method_source (1.1.0) - minitest (6.0.2) + minitest (6.0.6) drb (~> 2.0) prism (~> 1.5) netrc (0.11.0) - nokogiri (1.19.1-aarch64-linux-gnu) + nokogiri (1.19.4-aarch64-linux-gnu) racc (~> 1.4) - nokogiri (1.19.1-aarch64-linux-musl) + nokogiri (1.19.4-aarch64-linux-musl) racc (~> 1.4) - nokogiri (1.19.1-arm64-darwin) + nokogiri (1.19.4-arm64-darwin) racc (~> 1.4) - nokogiri (1.19.1-x86_64-darwin) + nokogiri (1.19.4-x86_64-darwin) racc (~> 1.4) - nokogiri (1.19.1-x86_64-linux-gnu) + nokogiri (1.19.4-x86_64-linux-gnu) racc (~> 1.4) - nokogiri (1.19.1-x86_64-linux-musl) + nokogiri (1.19.4-x86_64-linux-musl) racc (~> 1.4) packs-specification (0.0.11) sorbet-runtime - packwerk (3.2.3) + packwerk (3.3.0) activesupport (>= 6.0) ast + benchmark better_html bundler constant_resolver (>= 0.3) - parallel + parallel (< 2) parser - prism (>= 0.25.0) - sorbet-runtime (>= 0.5.9914) + prism (>= 1.4.0) zeitwerk (>= 2.6.1) - parallel (1.27.0) + parallel (1.28.0) parse_packwerk (0.27.0) bigdecimal sorbet-runtime - parser (3.3.10.2) + parser (3.3.11.1) ast (~> 2.4.1) racc pastel (0.8.0) @@ -142,7 +139,6 @@ GEM pry-byebug (3.12.0) byebug (~> 13.0) pry (>= 0.13, < 0.17) - public_suffix (7.0.5) racc (1.8.1) rails-dom-testing (2.3.0) activesupport (>= 5.0.0) @@ -152,18 +148,18 @@ GEM loofah (~> 2.25) nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0) rainbow (3.1.1) - rake (13.3.1) - rbi (0.3.9) + rake (13.4.2) + rbi (0.3.14) prism (~> 1.0) - rbs (>= 3.4.4) - rbs (4.0.0.dev.5) + rbs (>= 4.0.1) + rbs (4.1.0.pre.2) logger - prism (>= 1.3.0) + prism (>= 1.6.0) tsort - regexp_parser (2.11.3) + regexp_parser (2.12.0) reline (0.6.3) io-console (~> 0.5) - require-hooks (0.2.3) + require-hooks (0.4.0) rexml (3.4.4) rspec (3.13.2) rspec-core (~> 3.13.0) @@ -178,22 +174,21 @@ GEM diff-lcs (>= 1.2.0, < 2.0) rspec-support (~> 3.13.0) rspec-support (3.13.7) - rubocop (1.85.1) + rubocop (1.88.0) json (~> 2.3) language_server-protocol (~> 3.17.0.2) lint_roller (~> 1.1.0) - mcp (~> 0.6) - parallel (~> 1.10) + parallel (>= 1.10) parser (>= 3.3.0.2) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 2.9.3, < 3.0) rubocop-ast (>= 1.49.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 4.0) - rubocop-ast (1.49.0) + rubocop-ast (1.49.1) parser (>= 3.3.7.2) prism (~> 1.7) - rubocop-gusto (10.6.0) + rubocop-gusto (11.1.1) lint_roller rubocop (>= 1.76) rubocop-performance @@ -208,43 +203,49 @@ GEM rubocop-rake (0.7.1) lint_roller (~> 1.1) rubocop (>= 1.72.1) - rubocop-rspec (3.9.0) + rubocop-rspec (3.10.2) lint_roller (~> 1.1) - rubocop (~> 1.81) + regexp_parser (>= 2.0) + rubocop (~> 1.86, >= 1.86.2) rubocop-sorbet (0.12.0) lint_roller rubocop (>= 1.75.2) ruby-progressbar (1.13.0) + rubydex (0.2.6-aarch64-linux) + rubydex (0.2.6-arm64-darwin) + rubydex (0.2.6-x86_64-darwin) + rubydex (0.2.6-x86_64-linux) securerandom (0.4.1) smart_properties (1.17.0) - sorbet (0.6.12992) - sorbet-static (= 0.6.12992) - sorbet-runtime (0.6.12992) - sorbet-static (0.6.12992-aarch64-linux) - sorbet-static (0.6.12992-universal-darwin) - sorbet-static (0.6.12992-x86_64-linux) - sorbet-static-and-runtime (0.6.12992) - sorbet (= 0.6.12992) - sorbet-runtime (= 0.6.12992) - spoom (1.7.11) + sorbet (0.6.13312) + sorbet-static (= 0.6.13312) + sorbet-runtime (0.6.13312) + sorbet-static (0.6.13312-aarch64-linux) + sorbet-static (0.6.13312-universal-darwin) + sorbet-static (0.6.13312-x86_64-linux) + sorbet-static-and-runtime (0.6.13312) + sorbet (= 0.6.13312) + sorbet-runtime (= 0.6.13312) + spoom (1.8.2) erubi (>= 1.10.0) prism (>= 0.28.0) - rbi (>= 0.3.3) - rbs (>= 4.0.0.dev.4) + rbi (>= 0.3.14) + rbs (>= 4.0.0.dev.5) rexml (>= 3.2.6) sorbet-static-and-runtime (>= 0.5.10187) thor (>= 0.19.2) - tapioca (0.17.10) + tapioca (0.19.2) benchmark bundler (>= 2.2.25) netrc (>= 0.11.0) parallel (>= 1.21.0) rbi (>= 0.3.7) require-hooks (>= 0.2.2) - sorbet-static-and-runtime (>= 0.5.11087) - spoom (>= 1.7.9) + rubydex (>= 0.1.0.beta10) + sorbet-static-and-runtime (>= 0.6.12698) + spoom (>= 1.7.16) thor (>= 1.2.0) - yard-sorbet + tsort thor (1.5.0) tsort (0.2.0) tty-color (0.6.0) @@ -264,11 +265,7 @@ GEM unicode-emoji (4.2.0) uri (1.1.1) wisper (2.0.1) - yard (0.9.38) - yard-sorbet (0.9.0) - sorbet-runtime - yard - zeitwerk (2.7.5) + zeitwerk (2.8.2) PLATFORMS aarch64-linux From aef4d4a7e3d8ec2476e00734409a9255cd3767b6 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 25 Jun 2026 15:44:01 -0700 Subject: [PATCH 2/2] Fix CI: rubocop autocorrect + todo for bumped rubocop --- .rubocop_todo.yml | 30 +++++++------ lib/packs.rb | 42 +++++++++---------- lib/packs/cli.rb | 12 +++--- lib/packs/private.rb | 24 +++++------ lib/packs/private/file_move_operation.rb | 6 +-- .../private/interactive_cli/pack_selector.rb | 4 +- .../private/interactive_cli/team_selector.rb | 4 +- .../interactive_cli/use_cases/create.rb | 2 +- .../interactive_cli/use_cases/get_info.rb | 2 +- .../interactive_cli/use_cases/make_public.rb | 2 +- .../private/interactive_cli/use_cases/move.rb | 2 +- .../interactive_cli/use_cases/move_pack.rb | 2 +- .../interactive_cli/use_cases/query.rb | 2 +- spec/packs/private/interactive_cli_spec.rb | 2 +- spec/packs_spec.rb | 12 +++--- spec/spec_helper.rb | 14 +++---- 16 files changed, 83 insertions(+), 79 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 61ef2d6..e0cc786 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,25 +1,15 @@ # This configuration was generated by -# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100` -# on 2026-03-05 21:24:10 UTC using RuboCop version 1.85.1. +# `rubocop --auto-gen-config --exclude-limit 10000` +# on 2026-06-25 22:43:37 UTC using RuboCop version 1.88.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 8 +# Offense count: 1 Gusto/NoMetaprogramming: Exclude: - - 'lib/packs/cli.rb' - 'lib/packs/private/interactive_cli/use_cases/interface.rb' - - 'spec/packs/private/cli_spec.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowedPatterns. -Sorbet/BlockMethodDefinition: - Exclude: - - 'spec/packs/private/cli_spec.rb' - - 'spec/packs_spec.rb' # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). @@ -59,6 +49,13 @@ RSpec/SpecFilePathFormat: - 'spec/packs/private/cli_spec.rb' - 'spec/verify_docs_spec.rb' +# Offense count: 5 +# This cop supports unsafe autocorrection (--autocorrect-all). +Sorbet/BlockMethodDefinition: + Exclude: + - 'spec/packs/private/cli_spec.rb' + - 'spec/packs_spec.rb' + # Offense count: 12 Sorbet/ConstantsFromStrings: Exclude: @@ -66,6 +63,13 @@ Sorbet/ConstantsFromStrings: - 'spec/packs_spec.rb' - 'spec/spec_helper.rb' +# Offense count: 3 +Sorbet/ForbidTUnsafe: + Exclude: + - 'lib/packs/private.rb' + - 'lib/packs/private/interactive_cli/use_cases/interface.rb' + - 'lib/packs/private/packwerk_wrapper/offenses_aggregator_formatter.rb' + # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SuggestedStrictness. diff --git a/lib/packs.rb b/lib/packs.rb index dd4f5db..0f189e1 100644 --- a/lib/packs.rb +++ b/lib/packs.rb @@ -74,11 +74,11 @@ def self.create_pack!( team: nil ) Private.create_pack!( - pack_name: pack_name, - enforce_privacy: enforce_privacy, - enforce_dependencies: enforce_dependencies, - enforce_layers: enforce_layers, - team: team + pack_name:, + enforce_privacy:, + enforce_dependencies:, + enforce_layers:, + team: ) end @@ -100,9 +100,9 @@ def self.move_to_pack!( end Private.move_to_pack!( - pack_name: pack_name, - paths_relative_to_root: paths_relative_to_root, - per_file_processors: per_file_processors + pack_name:, + paths_relative_to_root:, + per_file_processors: ) Logging.section('Next steps') do @@ -127,8 +127,8 @@ def self.make_public!( end Private.make_public!( - paths_relative_to_root: paths_relative_to_root, - per_file_processors: per_file_processors + paths_relative_to_root:, + per_file_processors: ) Logging.section('Next steps') do @@ -153,8 +153,8 @@ def self.add_dependency!( end Private.add_dependency!( - pack_name: pack_name, - dependency_name: dependency_name + pack_name:, + dependency_name: ) Logging.section('Next steps') do @@ -181,9 +181,9 @@ def self.move_to_parent!( end Private.move_to_parent!( - pack_name: pack_name, - parent_name: parent_name, - per_file_processors: per_file_processors + pack_name:, + parent_name:, + per_file_processors: ) Logging.section('Next steps') do @@ -211,9 +211,9 @@ def self.move_to_folder!( end Private.move_to_folder!( - pack_name: pack_name, - destination: destination, - per_file_processors: per_file_processors + pack_name:, + destination:, + per_file_processors: ) Logging.section('Next steps') do @@ -251,9 +251,9 @@ def self.list_top_violations( end def self.replace_in_file(file:, find:, replace_with:) Private.replace_in_file( - file: file, - find: find, - replace_with: replace_with + file:, + find:, + replace_with: ) end diff --git a/lib/packs/cli.rb b/lib/packs/cli.rb index c8da1ef..573ebdc 100644 --- a/lib/packs/cli.rb +++ b/lib/packs/cli.rb @@ -13,7 +13,7 @@ class CLI < Thor sig { params(pack_name: String).void } def create(pack_name) Packs.create_pack!( - pack_name: pack_name, + pack_name:, enforce_dependencies: options[:enforce_dependencies], enforce_privacy: options[:enforce_privacy], enforce_layers: options[:enforce_layers] @@ -63,8 +63,8 @@ def list_top_violations(type, pack_name = nil) raise StandardError, "Invalid type #{type}. Possible types are: #{POSSIBLE_TYPES.join(', ')}" unless POSSIBLE_TYPES.include?(type) Packs.list_top_violations( - type: type, - pack_name: pack_name, + type:, + pack_name:, limit: options[:limit] ) exit_successfully @@ -92,7 +92,7 @@ def make_public(*paths) sig { params(pack_name: String, paths: String).void } def move(pack_name, *paths) Packs.move_to_pack!( - pack_name: pack_name, + pack_name:, paths_relative_to_root: paths ) exit_successfully @@ -168,8 +168,8 @@ def move_to_parent(child_pack_name, parent_pack_name) sig { params(pack_name: String, destination: String).void } def move_to_folder(pack_name, destination) Packs.move_to_folder!( - pack_name: pack_name, - destination: destination + pack_name:, + destination: ) exit_successfully end diff --git a/lib/packs/private.rb b/lib/packs/private.rb index 55b1a72..1cb9db3 100644 --- a/lib/packs/private.rb +++ b/lib/packs/private.rb @@ -64,11 +64,11 @@ def self.create_pack!(pack_name:, enforce_dependencies:, enforce_privacy:, enfor pack_name = Private.clean_pack_name(pack_name) package = create_pack_if_not_exists!( - pack_name: pack_name, - enforce_dependencies: enforce_dependencies, - enforce_privacy: enforce_privacy, - enforce_layers: enforce_layers, - team: team + pack_name:, + enforce_dependencies:, + enforce_privacy:, + enforce_layers:, + team: ) add_public_directory(package) if package.enforce_privacy add_readme(package) @@ -127,7 +127,7 @@ def self.move_to_pack!(pack_name:, paths_relative_to_root:, per_file_processors: end file_move_operations = file_paths.flat_map do |origin_pathname| file_move_operation = FileMoveOperation.new( - origin_pathname: origin_pathname, + origin_pathname:, destination_pathname: FileMoveOperation.destination_pathname_for_package_move(origin_pathname, package_location), destination_pack: package ) @@ -184,7 +184,7 @@ def self.move_to_folder!(pack_name:, destination:, per_file_processors: [Packs:: move_to_pack!( pack_name: new_package_name, paths_relative_to_root: [package.directory.to_s], - per_file_processors: per_file_processors + per_file_processors: ) # Then delete the old package.yml and package_todo.yml files @@ -278,7 +278,7 @@ def self.move_to_parent!( move_to_pack!( pack_name: new_package_name, paths_relative_to_root: [package.directory.to_s], - per_file_processors: per_file_processors + per_file_processors: ) # Then delete the old package.yml and package_todo.yml files @@ -353,7 +353,7 @@ def self.make_public!(paths_relative_to_root:, per_file_processors:) origin_pathname = Pathname.new(path).cleanpath file_move_operation = FileMoveOperation.new( - origin_pathname: origin_pathname, + origin_pathname:, destination_pathname: FileMoveOperation.destination_pathname_for_new_public_api(origin_pathname), destination_pack: package ) @@ -498,13 +498,13 @@ def self.create_pack_if_not_exists!(pack_name:, enforce_dependencies:, enforce_p package = ParsePackwerk::Package.new( enforce_dependencies: should_enforce_dependencies || false, - enforce_privacy: enforce_privacy, - enforce_layers: enforce_layers, + enforce_privacy:, + enforce_layers:, dependencies: [], violations: [], metadata: {}, name: pack_name, - config: config + config: ) ParsePackwerk.write_package_yml!(package) diff --git a/lib/packs/private/file_move_operation.rb b/lib/packs/private/file_move_operation.rb index e3e3822..2a390b6 100644 --- a/lib/packs/private/file_move_operation.rb +++ b/lib/packs/private/file_move_operation.rb @@ -71,7 +71,7 @@ def spec_file_move_operations FileMoveOperation.new( origin_pathname: new_origin_pathname, destination_pathname: new_destination_pathname, - destination_pack: destination_pack + destination_pack: ), ] @@ -140,7 +140,7 @@ def request_spec_file_move_operation FileMoveOperation.new( origin_pathname: request_spec_origin, destination_pathname: request_spec_destination, - destination_pack: destination_pack + destination_pack: ) end @@ -149,7 +149,7 @@ def relative_to(path) FileMoveOperation.new( origin_pathname: origin_pathname.relative_path_from(path), destination_pathname: destination_pathname.relative_path_from(path), - destination_pack: destination_pack + destination_pack: ) end end diff --git a/lib/packs/private/interactive_cli/pack_selector.rb b/lib/packs/private/interactive_cli/pack_selector.rb index 8d7f3a4..045759d 100644 --- a/lib/packs/private/interactive_cli/pack_selector.rb +++ b/lib/packs/private/interactive_cli/pack_selector.rb @@ -25,7 +25,7 @@ def self.single_pack_select(prompt, question_text: 'Please use space to select a 'No packs were selected, please select a pack using the space key before pressing enter.' ) - pack_selection = single_pack_select(prompt, question_text: question_text) + pack_selection = single_pack_select(prompt, question_text:) end pack_selection @@ -48,7 +48,7 @@ def self.single_or_all_pack_multi_select(prompt, question_text: 'Please use spac 'No packs were selected, please select one or more packs using the space key before pressing enter.' ) - pack_selection = single_or_all_pack_multi_select(prompt, question_text: question_text) + pack_selection = single_or_all_pack_multi_select(prompt, question_text:) end pack_selection diff --git a/lib/packs/private/interactive_cli/team_selector.rb b/lib/packs/private/interactive_cli/team_selector.rb index c9ab03b..378d851 100644 --- a/lib/packs/private/interactive_cli/team_selector.rb +++ b/lib/packs/private/interactive_cli/team_selector.rb @@ -26,7 +26,7 @@ def self.single_select(prompt, question_text: 'Please use space to select a team 'No owners were selected, please select an owner using the space key before pressing enter.' ) - team_selection = single_select(prompt, question_text: question_text) + team_selection = single_select(prompt, question_text:) end team_selection @@ -51,7 +51,7 @@ def self.multi_select(prompt, question_text: 'Please use space to select team ow 'No owners were selected, please select one or more owners using the space key before pressing enter.' ) - team_selection = multi_select(prompt, question_text: question_text) + team_selection = multi_select(prompt, question_text:) end team_selection diff --git a/lib/packs/private/interactive_cli/use_cases/create.rb b/lib/packs/private/interactive_cli/use_cases/create.rb index 7ed2de6..393ed00 100644 --- a/lib/packs/private/interactive_cli/use_cases/create.rb +++ b/lib/packs/private/interactive_cli/use_cases/create.rb @@ -13,7 +13,7 @@ class Create def perform!(prompt) pack_name = prompt.ask('What should the name of your pack be?', value: 'packs/') team = TeamSelector.single_select(prompt) - Packs.create_pack!(pack_name: pack_name, team: team) + Packs.create_pack!(pack_name:, team:) end sig { override.returns(String) } diff --git a/lib/packs/private/interactive_cli/use_cases/get_info.rb b/lib/packs/private/interactive_cli/use_cases/get_info.rb index 8fc0ad0..c5ff425 100644 --- a/lib/packs/private/interactive_cli/use_cases/get_info.rb +++ b/lib/packs/private/interactive_cli/use_cases/get_info.rb @@ -41,7 +41,7 @@ def perform!(prompt) packs: selected_packs, format: format.downcase.to_sym, types: types.map(&:downcase).map(&:to_sym), - include_date: include_date + include_date: ) end end diff --git a/lib/packs/private/interactive_cli/use_cases/make_public.rb b/lib/packs/private/interactive_cli/use_cases/make_public.rb index f69e564..c987f1e 100644 --- a/lib/packs/private/interactive_cli/use_cases/make_public.rb +++ b/lib/packs/private/interactive_cli/use_cases/make_public.rb @@ -19,7 +19,7 @@ def perform!(prompt) paths_relative_to_root = FileSelector.select(prompt) Packs.make_public!( - paths_relative_to_root: paths_relative_to_root, + paths_relative_to_root:, per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new] ) end diff --git a/lib/packs/private/interactive_cli/use_cases/move.rb b/lib/packs/private/interactive_cli/use_cases/move.rb index 281a376..e4556a9 100644 --- a/lib/packs/private/interactive_cli/use_cases/move.rb +++ b/lib/packs/private/interactive_cli/use_cases/move.rb @@ -16,7 +16,7 @@ def perform!(prompt) Packs.move_to_pack!( pack_name: pack.name, - paths_relative_to_root: paths_relative_to_root, + paths_relative_to_root:, per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new] ) end diff --git a/lib/packs/private/interactive_cli/use_cases/move_pack.rb b/lib/packs/private/interactive_cli/use_cases/move_pack.rb index c7f8684..2cb6ff9 100644 --- a/lib/packs/private/interactive_cli/use_cases/move_pack.rb +++ b/lib/packs/private/interactive_cli/use_cases/move_pack.rb @@ -53,7 +53,7 @@ def perform!(prompt) Packs.move_to_folder!( pack_name: pack.name, - destination: destination, + destination:, per_file_processors: [Packs::RubocopPostProcessor.new, Packs::CodeOwnershipPostProcessor.new] ) end diff --git a/lib/packs/private/interactive_cli/use_cases/query.rb b/lib/packs/private/interactive_cli/use_cases/query.rb index c22fe6d..3c362c9 100644 --- a/lib/packs/private/interactive_cli/use_cases/query.rb +++ b/lib/packs/private/interactive_cli/use_cases/query.rb @@ -35,7 +35,7 @@ def perform!(prompt) Packs.list_top_violations( type: selection.downcase, pack_name: selected_pack, - limit: limit + limit: ) end end diff --git a/spec/packs/private/interactive_cli_spec.rb b/spec/packs/private/interactive_cli_spec.rb index 139b08c..fef5e14 100644 --- a/spec/packs/private/interactive_cli_spec.rb +++ b/spec/packs/private/interactive_cli_spec.rb @@ -20,7 +20,7 @@ module INPUTS let(:prompt) { TTY::Prompt::Test.new } subject do - Private::InteractiveCli.start!(prompt: prompt) + Private::InteractiveCli.start!(prompt:) end before { CodeTeams.bust_caches! } diff --git a/spec/packs_spec.rb b/spec/packs_spec.rb index 60d41a7..697bd4b 100644 --- a/spec/packs_spec.rb +++ b/spec/packs_spec.rb @@ -2190,8 +2190,8 @@ def write_codeownership_config let(:list_top_privacy_violations) do Packs.list_top_violations( type: 'privacy', - pack_name: pack_name, - limit: limit + pack_name:, + limit: ) end @@ -2338,7 +2338,7 @@ def write_codeownership_config Packs.list_top_violations( type: 'privacy', pack_name: nil, - limit: limit + limit: ) expected_logged_output = <<~OUTPUT @@ -2375,8 +2375,8 @@ def write_codeownership_config let(:list_top_dependency_violations) do Packs.list_top_violations( type: 'dependency', - pack_name: pack_name, - limit: limit + pack_name:, + limit: ) end @@ -2529,7 +2529,7 @@ def write_codeownership_config Packs.list_top_violations( type: 'dependency', pack_name: nil, - limit: limit + limit: ) expected_logged_output = <<~OUTPUT diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 3d4e1a0..b299f67 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -62,13 +62,13 @@ def write_package_yml( package = ParsePackwerk::Package.new( name: pack_name, - dependencies: dependencies, - violations: violations, - enforce_dependencies: enforce_dependencies, - enforce_privacy: enforce_privacy, - enforce_layers: enforce_layers, - metadata: metadata, - config: config + dependencies:, + violations:, + enforce_dependencies:, + enforce_privacy:, + enforce_layers:, + metadata:, + config: ) ParsePackwerk.write_package_yml!(package)