Overview
.github/workflows/pr-quality-gates.yml line 23 contains a regex meant to match PR closing keywords (close, fix, resolve and their variants). The pattern fix(e[sd])? is confusing and diverges from standard GitHub closing keyword syntax. A simpler, explicit alternation removes ambiguity and ensures all documented variants are matched correctly.
Specifications
Features:
- PR body regex reliably matches all documented linking keywords:
close, closes, closed, fix, fixed, fixes, resolve, resolves, resolved
Tasks:
- Replace the current regex with an explicit alternation:
(close[sd]?|fix(ed|es)?|resolve[sd]?)\s+#\d+
- Add test cases validating each keyword variant against the pattern
- Document the expected keyword format in
CONTRIBUTING.md
Impacted Files:
.github/workflows/pr-quality-gates.yml
CONTRIBUTING.md
Acceptance Criteria
- All nine documented closing keywords are matched correctly
- PRs without an issue reference are blocked
- PRs with any valid keyword + issue number pass the gate
Overview
.github/workflows/pr-quality-gates.ymlline 23 contains a regex meant to match PR closing keywords (close,fix,resolveand their variants). The patternfix(e[sd])?is confusing and diverges from standard GitHub closing keyword syntax. A simpler, explicit alternation removes ambiguity and ensures all documented variants are matched correctly.Specifications
Features:
close,closes,closed,fix,fixed,fixes,resolve,resolves,resolvedTasks:
(close[sd]?|fix(ed|es)?|resolve[sd]?)\s+#\d+CONTRIBUTING.mdImpacted Files:
.github/workflows/pr-quality-gates.ymlCONTRIBUTING.mdAcceptance Criteria