From b71f8baa64054c1c8582e6d579f602ed5b288dd5 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sun, 9 Aug 2026 21:04:01 +0000
Subject: [PATCH] fix(plugin-grid): BulkActionDialog required params announce
 state, not the asterisk (objectui#3967)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`ParamField` renders the required marker inside a `<Label htmlFor>` that points
at the control, so accname folded the bare `*` into the control's accessible
name ("Notify owner asterisk"), while nothing carried the required STATE to the
control at all — `param.required` was live only in the dialog's own pre-submit
gate, and no widget derives `aria-required` from `field.required`.

Aligned with app-shell's `ActionParamDialog` (objectui#3299/#3290), not a second
spelling: `aria-hidden="true"` on the marker span, `aria-required={param.required
|| undefined}` on the widget. Deliberately not the native `required` attribute
(#3290: that arms the browser's constraint bubble alongside this dialog's own
gating — two validators, one field), and `|| undefined` so an optional param
carries no attribute rather than `aria-required="false"`.

`id` ownership at this site was already correct and is untouched, as is
`ActionParamDialog`. The marker stays visible; only its participation in the
accessible name changes.

Pins in `bulkActionDialogParams.test.tsx` cover both halves together — either
one alone is satisfiable the wrong way — plus a non-boolean param, since
`ParamField` has no type branches.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
---
 .../bulkactiondialog-required-aria-3967.md    |  31 +++++
 .../__tests__/bulkActionDialogParams.test.tsx | 114 ++++++++++++++++++
 .../src/components/BulkActionDialog.tsx       |  20 ++-
 3 files changed, 164 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/bulkactiondialog-required-aria-3967.md

diff --git a/.changeset/bulkactiondialog-required-aria-3967.md b/.changeset/bulkactiondialog-required-aria-3967.md
new file mode 100644
index 000000000..23a310a95
--- /dev/null
+++ b/.changeset/bulkactiondialog-required-aria-3967.md
@@ -0,0 +1,31 @@
+---
+"@object-ui/plugin-grid": patch
+---
+
+`BulkActionDialog` required params: the control now announces the required state, and the visual `*` stays out of its accessible name
+
+`ParamField` renders each bulk param's label with a `*` marker when
+`param.required`, inside a `<Label htmlFor>` that points at the control. Two
+conventions the app-shell `ActionParamDialog` has carried since objectui#3299 /
+objectui#3290 were missing at this site:
+
+- The `*` span had no `aria-hidden="true"`. Accname folds a referencing label's
+  text into the control's name, so every required bulk param announced as
+  "Notify owner asterisk" — a decorative glyph read aloud as part of the label.
+- No `aria-required` was passed to the widget. `param.required` is otherwise
+  live — the dialog's own pre-submit gate reads it to keep Next disabled — but
+  nothing carried the state to the control, and no widget derives it from
+  `field.required` (`toDomProps` forwards `aria-*` by prefix; it invents
+  nothing). So the only channel that could announce requiredness was empty
+  while the only thing present was the glyph.
+
+The required state now rides the state channel to the control, deliberately as
+`aria-required` and not the native `required` attribute — per the objectui#3290
+ruling, the native attribute would arm the browser's constraint-validation
+bubble alongside this dialog's own gating, giving one field two validators.
+`|| undefined` keeps an optional param free of the attribute entirely rather
+than carrying `aria-required="false"`, matching `ActionParamDialog`.
+
+The marker remains visible; only its participation in the accessible name
+changes. `id` ownership at this site was already correct and is untouched, as
+is `ActionParamDialog`.
diff --git a/packages/plugin-grid/src/__tests__/bulkActionDialogParams.test.tsx b/packages/plugin-grid/src/__tests__/bulkActionDialogParams.test.tsx
index 4a552f844..b434ddfc1 100644
--- a/packages/plugin-grid/src/__tests__/bulkActionDialogParams.test.tsx
+++ b/packages/plugin-grid/src/__tests__/bulkActionDialogParams.test.tsx
@@ -17,6 +17,9 @@
  * lookup suite pins the #3064 contract itself: no eager candidate prefetch,
  * fetch errors surfaced with a Retry affordance, and no failure caching
  * (reopening the picker refetches).
+ *
+ * objectui#3967 added the a11y suite at the bottom: the required STATE reaches
+ * the control and the visual-only `*` stays out of its accessible name.
  */
 import { describe, it, expect, vi, beforeAll, beforeEach } from 'vitest';
 import { render, screen, waitFor, fireEvent } from '@testing-library/react';
@@ -203,3 +206,114 @@ describe('BulkActionDialog — lookup param uses the shared record picker (#3064
     expect(ds.find).toHaveBeenCalledTimes(2);
   });
 });
+
+/**
+ * Required params announce STATE, not the decoration (objectui#3967).
+ *
+ * `ParamField` renders one row per param through a SINGLE code path (unlike
+ * app-shell's `ActionParamDialog`, which forks a boolean branch), so both
+ * defects landed on every param type at once:
+ *
+ * 1. The visible `*` sat inside `<Label htmlFor={id}>` with no `aria-hidden`.
+ *    Accname §2D folds a referencing label's text into the control's name, so
+ *    a required bulk param announced as "Notify owner asterisk" — a decorative
+ *    glyph read aloud as if it were part of the label.
+ * 2. `aria-required` was never passed. `param.required` IS live — the dialog's
+ *    own pre-submit gate reads it to disable Next — but nothing carried the
+ *    state to the control, and no widget derives it from `field.required`
+ *    (`toDomProps` forwards `aria-*` by prefix; it invents nothing). So the
+ *    only channel that could announce "required" was empty while the only
+ *    thing present was the glyph now hidden.
+ *
+ * Both halves have to be pinned together, because either one alone is
+ * satisfiable the wrong way: hiding the `*` without `aria-required` announces
+ * NOTHING about requiredness, and `aria-required` without hiding the `*`
+ * announces it twice, once as noise. The visible-marker assertions exist for
+ * the same reason — deleting the `*` outright would also produce a clean name.
+ */
+describe('BulkActionDialog — required params announce state, not the asterisk (objectui#3967)', () => {
+  function renderParams(params: any[]) {
+    const ds = makeDataSource();
+    const def: any = { name: 'set_it', label: 'Set it', operation: 'update', params };
+    render(
+      <BulkActionDialog
+        def={def}
+        rows={[{ id: 'r1' }]}
+        resource="thing"
+        dataSource={ds}
+        open
+        onClose={() => {}}
+      />,
+    );
+    return ds;
+  }
+
+  /**
+   * Query by the host-owned id rather than by role or label text: the id is
+   * what `<Label htmlFor>` names, it is stable across widget types (switch,
+   * textbox, …), and — unlike `*ByLabelText`, which matches on the label's raw
+   * `textContent` — it does not quietly depend on the very `aria-hidden` these
+   * tests are asserting.
+   */
+  async function control(paramName: string): Promise<HTMLElement> {
+    return await waitFor(() => {
+      const el = document.getElementById(`bulk-param-${paramName}`);
+      expect(el).not.toBeNull();
+      return el as HTMLElement;
+    });
+  }
+
+  function labelFor(paramName: string): HTMLLabelElement {
+    const el = document.querySelector(`label[for="bulk-param-${paramName}"]`);
+    expect(el).not.toBeNull();
+    return el as HTMLLabelElement;
+  }
+
+  it('gives a required boolean param aria-required and an asterisk-free name', async () => {
+    renderParams([{ name: 'notify', label: 'Notify owner', type: 'boolean', required: true }]);
+
+    const el = await control('notify');
+    // The state channel of #3299/#3290 — deliberately not the native
+    // `required` attribute, which would arm a second validator (#3290).
+    expect(el).toHaveAttribute('aria-required', 'true');
+    expect(el).not.toHaveAttribute('required');
+    // The name is exactly what the author declared: no trailing glyph.
+    expect(el).toHaveAccessibleName('Notify owner');
+
+    // …and the marker is still SHOWN, just excluded from the name.
+    const label = labelFor('notify');
+    expect(label.textContent).toContain('*');
+    expect(label.querySelector('[aria-hidden="true"]')?.textContent).toBe('*');
+  });
+
+  it('leaves an optional boolean param with no aria-required attribute at all', async () => {
+    renderParams([{ name: 'notify', label: 'Notify owner', type: 'boolean' }]);
+
+    const el = await control('notify');
+    // Absent, not `aria-required="false"` — an optional control should not
+    // appear in the a11y tree as one whose requiredness was considered.
+    expect(el).not.toHaveAttribute('aria-required');
+    expect(el).toHaveAccessibleName('Notify owner');
+    expect(labelFor('notify').textContent).not.toContain('*');
+  });
+
+  it('applies the same shape to a non-boolean param — one ParamField path, not a per-type one', async () => {
+    // The unchanged-direction half: `ParamField` has no type branches, so a
+    // text param must come out with the identical treatment. A future refactor
+    // that forks a boolean-only branch (as app-shell's dialog has) and fixes
+    // only that fork fails here.
+    renderParams([
+      { name: 'note', label: 'Note', type: 'text', required: true },
+      { name: 'memo', label: 'Memo', type: 'text' },
+    ]);
+
+    const required = await control('note');
+    expect(required).toHaveAttribute('aria-required', 'true');
+    expect(required).toHaveAccessibleName('Note');
+    expect(labelFor('note').querySelector('[aria-hidden="true"]')?.textContent).toBe('*');
+
+    const optional = await control('memo');
+    expect(optional).not.toHaveAttribute('aria-required');
+    expect(optional).toHaveAccessibleName('Memo');
+  });
+});
diff --git a/packages/plugin-grid/src/components/BulkActionDialog.tsx b/packages/plugin-grid/src/components/BulkActionDialog.tsx
index 0dbdc4af1..03e2ac60e 100644
--- a/packages/plugin-grid/src/components/BulkActionDialog.tsx
+++ b/packages/plugin-grid/src/components/BulkActionDialog.tsx
@@ -586,7 +586,13 @@ const ParamField: React.FC<ParamFieldProps> = ({ param, multiple, value, onChang
       <div className="flex items-center justify-between">
         <Label htmlFor={id} className="text-xs">
           {param.label ?? param.name}
-          {param.required && <span className="text-destructive ml-0.5">*</span>}
+          {/* Visual-only (objectui#3299, aligned with app-shell's
+              `ActionParamDialog` in objectui#3967): the required STATE is
+              announced through `aria-required` on the control below. This
+              `*` sits inside a `<Label htmlFor>`, so without `aria-hidden`
+              accname folds it into the referenced control's name and every
+              required bulk param announces as "Label asterisk". */}
+          {param.required && <span className="text-destructive ml-0.5" aria-hidden="true">*</span>}
         </Label>
       </div>
       <Suspense fallback={<div className="h-9 w-full animate-pulse rounded-md bg-muted" aria-hidden="true" />}>
@@ -596,6 +602,18 @@ const ParamField: React.FC<ParamFieldProps> = ({ param, multiple, value, onChang
           value={value ?? null}
           onChange={onChange}
           field={field}
+          // Required is a STATE, so it rides the state channel to the control
+          // (objectui#3299) — deliberately NOT the native `required` attribute
+          // (#3290: that arms the browser's constraint bubble alongside this
+          // dialog's own `missing`/Next gating — two validators, one field).
+          // `param.required` is otherwise live only in the dialog's own
+          // pre-submit gate, so before this the control announced no required
+          // state at all. Widgets forward `aria-*` by prefix through their
+          // `toDomProps` whitelist, so it reaches the rendered control; none of
+          // them derives it from `field.required`. `|| undefined` keeps an
+          // optional param free of the attribute entirely (not `"false"`),
+          // matching `ActionParamDialog`.
+          aria-required={param.required || undefined}
           {...dataSourceProps}
         />
       </Suspense>