[finding] metadata-manager.ts:311 cites retired `captureBefore` as the witness for a live single-connection-pool hazard — needs a REPLACEMENT example, not deletion

[os-help]

Split from #6978 item 2 (its item 1 landed via PR #7081; the remainder is cross-lane — this file is domain:metadata per the anchoring rule). Filed unassigned as a recording — not a claim.

Symptom

packages/metadata/src/metadata-manager.ts:311 cites captureBefore as the live example for a single-connection-pool stall hazard. #6656 retired captureBefore (merged 2026-08-09) and PR #7081 deleted its last consumer limb, so the cited witness no longer exists.

(Line number from the #6978 census of 2026-08-09; re-anchor by grepping captureBefore before editing.)

⚠️ Fix shape — this is NOT a mechanical comment deletion

The hazard claim is independent and still stands on DatabaseLoader._find() — only the cited example is gone. Deleting the sentence would quietly retire a live policy note. The fix is a replacement witness: re-anchor the comment on DatabaseLoader._find() (or another current caller that demonstrates the stall shape), keeping the policy statement intact. Whoever picks this up should verify the hazard's continued reality against the current pool implementation rather than trusting this card.

Evidence base

#6656 (retirement), #6978 (census + the explicit "replacement witness, not deletion" warning recorded twice), PR #7081.

[os-zhuang]

Findings triage round, 2026-08-11 (PM session, maintainer-directed: 「跑一轮集中定级」).

Graded: promote. Stale witness for a live policy note — the body correctly insists on a replacement example anchored on DatabaseLoader._find(), not deletion; S-sized comment surgery with the hazard claim preserved.

finding → pm:queue (domain:metadata).

---

Generated by Claude Code

[huangyiirene]

Claim: PM loop round 1 (domain:metadata seat, huangyiirene term)

• Session: session_01AmES43BMDg4bPrxTdi5q7t
• Branch: claude/issue-7708-pool-hazard-witness
• Worktree: objectstack-issue-7708 (dedicated)
• Domain: domain:metadata
• File surface: packages/metadata/src/metadata-manager.ts (the policy comment near the former captureBefore citation) — expected to be comment-only; see the escape clause below
• Container & model: S but not mechanical ⇒ M treatment: mode:cloud, model: opus. The diff is small; the judgment — does the hazard still hold, and which caller is now the honest witness — is not, and this seat does not let card size imply model tier.
• Serial constraints cleared: packages/metadata/src/metadata-manager.ts is free — no in-flight PR touches it. Disjoint from this round's sibling dispatch metadata-fs: selfWrites suppression is time-keyed, so a poll tick landing inside the 200 ms window can swallow an external edit #7335 (packages/metadata-fs/src/repository.ts) and from both in-flight PRs (fix(metadata-protocol): listCommits no longer hides env-wide commit history (#7779) #7814 metadata-protocol/protocol.ts, fix(platform-objects): one decision, one dialog — carry identity confirm questions on description (#7309) #7827 platform-objects/**).

Why this is not a comment deletion, restated because it is the whole card: #6656 retired captureBefore and PR #7081 removed its last consumer, so the cited witness is gone — but the hazard claim is independent and, as filed, still stands on DatabaseLoader._find(). Deleting the sentence would silently retire a live policy note, which is the failure mode this card exists to prevent. The deliverable is a replacement witness, with the policy statement intact.

⚠️ The card's own instruction outranks the card's own confidence: it says to verify the hazard's continued reality against the current pool implementation rather than trusting the card. That is the first step, and both answers are deliverables — if the single-connection-pool stall shape no longer exists, the honest output is a comment that says so (or removal with that evidence), not a re-anchor onto a witness that does not stall either.

Anchors: the line number (:311) is from a 2026-08-09 census and is stale by construction — re-anchor by grepping captureBefore and the surrounding policy text. This seat anchors on symbol names, never line numbers.

---

Generated by Claude Code