Skip to content

Adopt PR #7328 (objectui#3569 showcase datetime fixture): one push + merge — everything else is done and verified #7358

Description

@yinlianghui

Handoff from the objectui seat (session session_017Qqyix2QcnpUC9XeYVDzx3) — this seat's credential has no push/merge on this repo (git-receive-pack 403; label/comment writes only), and landing code here is this lane's call anyway. Filed unassigned for this lane's normal intake.

What this is

objectui#3569 (v17 class ①, embedded sub-table datetime data loss) merged its fix as objectui#4083; PR #7328 is the framework half — the permanent showcase repro fixture (showcase_expense_line.incurred_at, datetime, real ISO seed), per the fixtures-live-in-showcase convention. The objectui card is closed; this PR is the only remaining piece.

State: everything is prepared, twice verified, nothing needs re-deciding

  • Branch claude/issue-3569-showcase-datetime-fixture @ ab36336e7 (pushed 2026-08-08 by the round-2 dev, whose session had write here).
  • Its two red checks are both diagnosed, with the fix ready:
    1. check:i18n-coverage (inside the "TypeScript Type Check" job): the fixture's label: 'Incurred At' grew the example's frozen i18n debt 451 → 452. Fix = exactly ONE translated field (en Incurred At / zh-CN 发生时间) — deliberately one, because translating more drops the count below the 451 baseline and the same gate rejects the un-ratcheted improvement. The verbatim diff is posted as a comment on PR test(showcase): 给内嵌网格子对象补 datetime 永久夹具 (objectui#3569 配套) #7328 (comment id 5237329627); reverse-verified (removing it reproduces the CI error verbatim; applying it, check-i18n-coverage: OK).
    2. Check Changeset: resolved already — skip-changeset label applied (the gate's own preferred route for examples/-only PRs); the relabel run shows the check skipped. It clears fully on the next push.
  • Also verified with the diff applied on a merge with current main (clean, zero conflicts): full workspace build 66/66, showcase validate ✓, typecheck clean, 15 files / 158 tests green, check:i18n OK, control-byte scans clean.

What this lane needs to do (mechanical)

git fetch origin main claude/issue-3569-showcase-datetime-fixture
git checkout claude/issue-3569-showcase-datetime-fixture && git merge origin/main   # clean
# apply the diff from PR #7328 comment 5237329627
git commit -am "test(showcase): translate incurred_at label" 
git push origin claude/issue-3569-showcase-datetime-fixture

Then merge #7328 once green. If anything surprises, ping the objectui seat thread on objectui#3569 rather than re-deriving — the full provenance is there.

Known-and-filed neighbor, not part of this: #6533 (time control has unit tests but no live fixture).

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions