Skip to content

Commit ec48539

Browse files
ci(deps): pin brace-expansion to 5.0.9 for GHSA-rgw5-rvv9-x895 (#4945) (#4961)
The previous override (`brace-expansion@>=5.0.0 <5.0.8: ^5.0.8`, added for GHSA-mh99-v99m-4gvg) landed on 5.0.8 — the version GHSA-rgw5-rvv9-x895 (7.5 high) affects. The OSV-Scanner step in validate-deps.yml therefore failed on `main` itself, attaching a red required check to every PR that touched a manifest or the lockfile regardless of its contents (observed on #4944). Move the override bound to `<5.0.9` / `^5.0.9`. Transitive-only via minimatch, so no published manifest changes; 5.0.8 leaves the lockfile entirely. Claude-Session: https://claude.ai/code/session_018iARDqtrhQgz6fVHDeDkbQ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2bf1484 commit ec48539

3 files changed

Lines changed: 34 additions & 13 deletions

File tree

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
---
3+
4+
ci(deps): lift the `brace-expansion` pin to 5.0.9 so `Validate Package Dependencies` stops failing on every PR (#4945)
5+
6+
`GHSA-rgw5-rvv9-x895` (7.5 high) affects `brace-expansion` 5.0.8 — which is
7+
exactly the version the previous pin (`brace-expansion@>=5.0.0 <5.0.8: ^5.0.8`,
8+
added for `GHSA-mh99-v99m-4gvg`) had settled on. The OSV-Scanner step in
9+
`.github/workflows/validate-deps.yml` reads `pnpm-lock.yaml` directly and exits
10+
non-zero on any match, so the job was red on `main` itself and attached that red
11+
to every PR that touched a manifest or the lockfile, whatever the PR contained
12+
(observed on #4944, which never touched `pnpm-lock.yaml`).
13+
14+
The `pnpm-workspace.yaml` override bound moves to `<5.0.9` / `^5.0.9`. It stays a
15+
transitive-only pin — nothing declares `brace-expansion` directly; it arrives via
16+
`minimatch` (ts-morph, eslint, `@typescript-eslint`, glob, `@vscode/vsce`,
17+
archiver), so no published manifest changes and `check-override-consistency`
18+
still has nothing to reconcile. 5.0.8 disappears from the lockfile entirely; the
19+
three `minimatch` snapshots that referenced it now resolve 5.0.9.
20+
21+
The reason to fix this on its own rather than let it ride along with the next
22+
dependency PR is the one the issue names: a permanently red required check
23+
trains everyone to scroll past it, and the next real advisory will look exactly
24+
like this one in the PR list.
25+
26+
Lockfile and override metadata only; releases nothing.

pnpm-lock.yaml

Lines changed: 3 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,16 @@ overrides:
105105
svelte: '^5.55.7'
106106
'@tootallnate/once@<2.0.1': '2.0.1'
107107
# OSV batch 2026-07 — transitive-only fixes (no publishable package declares these):
108-
# brace-expansion GHSA-mh99-v99m-4gvg (via minimatch@10.x); sharp GHSA-f88m-g3jw-g9cj
108+
# brace-expansion GHSA-mh99-v99m-4gvg (via minimatch@10.x), then GHSA-rgw5-rvv9-x895
109+
# (7.5 high) which affects 5.0.8 itself — the version the first pin landed on — so the
110+
# bound moves to <5.0.9. Still transitive-only through minimatch (ts-morph, eslint,
111+
# @typescript-eslint, glob, @vscode/vsce, archiver); sharp GHSA-f88m-g3jw-g9cj
109112
# (next optionalDep ^0.34.5 excludes the fix); react-router GHSA-qwww-vcr4-c8h2 has no
110113
# 7.x fix — fumadocs-core peer allows 8.x and docs uses the next adapter, so jump to 8;
111114
# @sveltejs/kit GHSA-866w-xmhq-wj7x/GHSA-wqjv-9729-c5q2 (better-auth optional peer);
112115
# @hono/node-server GHSA-frvp-7c67-39w9 has no 1.x fix — @modelcontextprotocol/sdk
113116
# declares ^1.19.9 and only imports getRequestListener, which 2.x still exports.
114-
'brace-expansion@>=5.0.0 <5.0.8': '^5.0.8'
117+
'brace-expansion@>=5.0.0 <5.0.9': '^5.0.9'
115118
'sharp@>=0.34.0 <0.35.0': '^0.35.0'
116119
'react-router@<8.3.0': '^8.3.0'
117120
'@sveltejs/kit@<2.69.1': '^2.69.1'

0 commit comments

Comments
 (0)