Remove error swallowing in metadata register to surface real failures

The try-catch block was hiding errors during metadata persistence which
prevented proper diagnosis of test failures. Now errors will propagate
properly to help identify the root cause of metadata history test failures.

packages/metadata/src/metadata-manager.ts:165-169

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Claude

packages/metadata/src/metadata-manager.ts

@@ -164,12 +164,7 @@ export class MetadataManager implements IMetadataService {
     // Persist to writable loaders (e.g., DatabaseLoader for history tracking)
     for (const loader of this.loaders.values()) {
       if (loader.save) {
-        try {
-          await loader.save(type, name, data);
-        } catch (error) {
-          // Log but don't fail registration if persistence fails
-          console.error(`Failed to persist metadata ${type}/${name} to loader:`, error);
-        }
+        await loader.save(type, name, data);
       }
     }
   }