Skip to content

Commit 4102de7

Browse files
committed
test(qa): refresh the approvals checklist's entry paths and cover the two new nav entries (#7331)
Browser-verified the #7213 entry convergence end to end against a console dist built at the pinned objectui SHA, then brought the checklist in line with what a real user now does. Entry paths refreshed (revision bumps + history entries): - approvals.per-group-signoff, approvals.inbox-metadata-actions and approvals.viewer-gating-submitter-side reached the inbox through the bare /system/approvals deep-link route. That route deliberately still works, so nothing was red — but the items were exercising the deep link rather than the path a user takes. They now open the account app's Approvals nav entry (the component route), and say why the other route is not the subject. - approvals.notification-deep-link gains a route-parity clause: the same ?request= link must open the drawer on BOTH /system/approvals (what already delivered notifications and emails carry) and the component route. A component-route-only deep link is called out as a FAIL. Three new items, all previously uncovered: - approvals.account-app-entry (P0) — the headline gap. Its first clause asserts the registration survives BUNDLING, because #7231's unit pin stubs the page at its module boundary and states in its own docblock that it does not assert main.tsx performs the side-effect import. Also pins non-admin reachability, decision execution under the component mount, ?request= parity, the record link keeping the current app segment, and zh wording. - approvals.setup-nav-entry (P2) — Approvals Inbox leads the Setup group, above the raw sys_approval_request grid. - approvals.pending-count-surfaces (P2) — the bell popover's unclamped `total · N notifications + M pending approvals` breakdown, M agreeing with Home's card, and Home's card landing in an app the user can open. Findings from the run are filed, not patched here: #7344 (no permission set grants sys_inbox_message, so the Account app's Notifications entry 403s for every non-admin), #7345 (an approver can be unable to open the record under approval), #7347 (check:platform-checklist is red on main on an unrelated pre-existing coverage gap). objectui#4074 was confirmed in the browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9U1G2piXmYrhYQX96XUyv
1 parent 88154be commit 4102de7

1 file changed

Lines changed: 226 additions & 12 deletions

File tree

0 commit comments

Comments
 (0)