fix: finish the consumer sweep — repo-wide typecheck is green

The remaining sites the compiler named, all the same shape as the last commit:
`metadata-protocol`'s seed-loader and search query plumbing hold parse results,
so they name `XParsed`; `ISeedLoaderService`'s request/result/graph follow, and
its contract test's mocks with them.

Two test-typecheck ledgers move because the flip fixed what they recorded, not
because anything was suppressed:

  @objectstack/spec    79 files / 691 errors -> 58 / 268
  @objectstack/client   3 files /   6 errors ->  0 /   0   (ledger now empty)

Both ledgers' own headers describe their contents as "fixture literals annotated
with a schema OUTPUT type while holding an authored INPUT literal" — which is the
defect ADR-0122 exists to end. No fixture was edited to achieve this; the bare
name simply means the input type now. The four entries that reached zero are
deleted, which is what the shrink-only ratchet requires.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015bLZKxxUUk4mahNfn3g3Ed

Author: claude

packages/client/test-typecheck-debt.json

@@ -1,8 +1,4 @@
 {
-  "_comment": "Per-file tsc error debt of the @objectstack/client TEST layer (#5286). `tsconfig.test.json` compiles `src/**/*.test.ts` — which `tsconfig.json` excludes and therefore no gate ever read — and every file below still carries errors from before that gate existed, almost all of them fixture literals annotated with a schema OUTPUT type (`z.infer`) while holding an authored INPUT literal. EXACT ratchet, judged by re-running tsc: a file that gains errors is red, a file that loses them is red until its number is re-recorded, a file that reaches zero is red until its entry is deleted, and a file NOT listed here may have no errors at all. Regenerate with: pnpm --filter @objectstack/client gen:test-typecheck-debt",
-  "entries": {
-    "src/client.batch-transaction.test.ts": 3,
-    "src/client.environment-scoping.test.ts": 1,
-    "src/client.hono.test.ts": 2
-  }
+  "_comment": "Per-file tsc error debt of the @objectstack/client TEST layer (#5286). `tsconfig.test.json` compiles `src/**/*.test.ts` — which `tsconfig.json` excludes and therefore no gate ever read — and every file below still carries errors from before that gate existed, almost all of them fixture literals annotated with a schema OUTPUT type (`z.infer`) while holding an authored INPUT literal. EXACT ratchet, judged by re-running tsc: a file that gains errors is red, a file that loses them is red until its number is re-recorded, a file that reaches zero is red until its entry is deleted, and a file NOT listed here may have no errors at all. Regenerate with: pnpm --filter @objectstack/client gen:test-typecheck-debt ADR-0122 phase 2 (#6083) emptied this ledger: all three remaining files were exactly the conflation described above — an authored literal annotated with the OUTPUT type — and the flip made the bare name mean the INPUT type, so they compile with no edit. An empty `entries` is the goal state, not a disabled gate: a file that gains an error is red on arrival.",
+  "entries": {}
 }

packages/metadata-protocol/src/protocol.ts

@@ -30,7 +30,7 @@ import {
     SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_FIELDS,
     RPC_QUERY_ALIAS_SLOTS, foldQueryAliasSlots,
     type QueryAliasConflict, type QueryAliasSlot,
-    type DroppedFieldsEvent, type QueryAST, type EngineQueryOptions,
+    type DroppedFieldsEvent, type QueryAST, type EngineQueryOptionsParsed,
 } from '@objectstack/spec/data';
 import { PLURAL_TO_SINGULAR, SINGULAR_TO_PLURAL } from '@objectstack/spec/shared';
 import { applyConversionsToStoredItem, type ConversionNotice } from '@objectstack/spec';
@@ -4140,7 +4140,7 @@ export class ObjectStackProtocolImplementation implements
             // `.strict()`), which left this query running ascending — the
             // OLDEST `limit` audit events, i.e. the beginning of an object's
             // life and never its recent changes (#4674). The `as any` is gone
-            // for the same reason: `EngineQueryOptions` rejects the wrong key,
+            // for the same reason: `EngineQueryOptionsParsed` rejects the wrong key,
             // and erasing the type is what let it through.
             const rows = await this.engine.find('sys_metadata_audit', {
                 where,
@@ -5971,7 +5971,7 @@ export class ObjectStackProtocolImplementation implements
                 // truncated away the recently-edited records a searcher is most
                 // likely to want (#4674). Typed rather than `any` so the
                 // contract rejects the wrong key at the call site.
-                const opts: EngineQueryOptions = {
+                const opts: EngineQueryOptionsParsed = {
                     where,
                     limit: perObject,
                     orderBy: [{ field: 'updated_at', order: 'desc' }],

packages/metadata-protocol/src/seed-loader.ts

@@ -2,7 +2,6 @@
 
 import type { IDataEngine, IMetadataService, ISeedLoaderService } from '@objectstack/spec/contracts';
 import type {
-  SeedLoaderRequest,
   SeedLoaderRequestParsed,
   SeedLoaderResultParsed,
   SeedLoaderConfig,
@@ -334,7 +333,12 @@ export class SeedLoaderService implements ISeedLoaderService {
 
   async validate(datasets: Seed[], config?: SeedLoaderConfig): Promise<SeedLoaderResultParsed> {
     const parsedConfig = SeedLoaderConfigSchema.parse({ ...config, dryRun: true });
-    return this.load({ seeds: datasets, config: parsedConfig });
+    // `datasets` is the AUTHOR state (that is what `validate` takes); `load`
+    // takes the parsed request, and `SeedLoaderSchema` fills the per-seed defaults
+    // this cast stands in for. Parsing each dataset here would be a second
+    // validation pass with its own failure mode — `load` already reports every
+    // seed problem it finds, which is the whole point of `dryRun`.
+    return this.load({ seeds: datasets, config: parsedConfig } as SeedLoaderRequestParsed);
   }
 
   // ==========================================================================
@@ -1979,7 +1983,7 @@ export class SeedLoaderService implements ISeedLoaderService {
     return Array.isArray(externalId) ? externalId.join('+') : externalId;
   }
 
-  private buildEmptyResult(config: SeedLoaderConfig, durationMs: number): SeedLoaderResultParsed {
+  private buildEmptyResult(config: SeedLoaderConfigParsed, durationMs: number): SeedLoaderResultParsed {
     return {
       success: true,
       dryRun: config.dryRun,

packages/qa/dogfood/test/fixtures/endpoint-policy-fixture.ts

@@ -32,7 +32,7 @@
 
 import { defineStack } from '@objectstack/spec';
 import { ObjectSchema, Field } from '@objectstack/spec/data';
-import type { ApiEndpoint, ApiEndpoint } from '@objectstack/spec/api';
+import type { ApiEndpoint } from '@objectstack/spec/api';
 
 /** One object, so the `object_operation` endpoints have something real to read. */
 export const PolicyNote = ObjectSchema.create({

packages/spec/src/contracts/seed-loader-service.test.ts

@@ -2,13 +2,17 @@
 
 import { describe, it, expect } from 'vitest';
 import type { ISeedLoaderService } from './seed-loader-service';
-import type { SeedLoaderRequest, SeedLoaderResult, ObjectDependencyGraph } from '../data/seed-loader.zod';
+import type {
+  SeedLoaderRequestParsed,
+  SeedLoaderResultParsed,
+  ObjectDependencyGraphParsed,
+} from '../data/seed-loader.zod';
 import type { Seed } from '../data/seed.zod';
 
 describe('Seed Loader Service Contract', () => {
   it('should allow a minimal implementation with required methods', () => {
     const service: ISeedLoaderService = {
-      load: async (_request: SeedLoaderRequest): Promise<SeedLoaderResult> => {
+      load: async (_request: SeedLoaderRequestParsed): Promise<SeedLoaderResultParsed> => {
         return {
           success: true,
           dryRun: false,
@@ -24,15 +28,17 @@ describe('Seed Loader Service Contract', () => {
             totalErrored: 0,
             totalReferencesResolved: 0,
             totalReferencesDeferred: 0,
+            totalReferencesDropped: 0,
+            totalSummariesStale: 0,
             circularDependencyCount: 0,
             durationMs: 0,
           },
         };
       },
-      buildDependencyGraph: async (_objectNames: string[]): Promise<ObjectDependencyGraph> => {
+      buildDependencyGraph: async (_objectNames: string[]): Promise<ObjectDependencyGraphParsed> => {
         return { nodes: [], insertOrder: [], circularDependencies: [] };
       },
-      validate: async (_datasets: Seed[]): Promise<SeedLoaderResult> => {
+      validate: async (_datasets: Seed[]): Promise<SeedLoaderResultParsed> => {
         return {
           success: true,
           dryRun: true,
@@ -48,6 +54,8 @@ describe('Seed Loader Service Contract', () => {
             totalErrored: 0,
             totalReferencesResolved: 0,
             totalReferencesDeferred: 0,
+            totalReferencesDropped: 0,
+            totalSummariesStale: 0,
             circularDependencyCount: 0,
             durationMs: 0,
           },
@@ -77,6 +85,8 @@ describe('Seed Loader Service Contract', () => {
           totalErrored: 0,
           totalReferencesResolved: 0,
           totalReferencesDeferred: 0,
+          totalReferencesDropped: 0,
+          totalSummariesStale: 0,
           circularDependencyCount: 0,
           durationMs: 42,
         },
@@ -91,7 +101,8 @@ describe('Seed Loader Service Contract', () => {
         summary: {
           objectsProcessed: 0, totalRecords: 0, totalInserted: 0, totalUpdated: 0,
           totalSkipped: 0, totalErrored: 0, totalReferencesResolved: 0,
-          totalReferencesDeferred: 0, circularDependencyCount: 0, durationMs: 0,
+          totalReferencesDeferred: 0, totalReferencesDropped: 0, totalSummariesStale: 0,
+          circularDependencyCount: 0, durationMs: 0,
         },
       }),
     };

packages/spec/test-typecheck-debt.json

@@ -24,7 +24,6 @@
     "src/contracts/package-service.test.ts": 2,
     "src/contracts/plugin-lifecycle-events.test.ts": 2,
     "src/contracts/security-service.test.ts": 1,
-    "src/contracts/seed-loader-service.test.ts": 2,
     "src/contracts/service-registry.test.ts": 7,
     "src/contracts/storage-service.test.ts": 1,
     "src/data/data-engine.test.ts": 6,

scripts/analytics-reconcile/boot.ts

@@ -11,7 +11,7 @@ import { SqliteWasmDriver } from '@objectstack/driver-sqlite-wasm';
 import { ObjectQLPlugin } from '@objectstack/objectql';
 import { AnalyticsServicePlugin } from '@objectstack/service-analytics';
 import { DatasetSchema } from '@objectstack/spec/ui';
-import type { Dataset, Dataset, Dashboard, Report } from '@objectstack/spec/ui';
+import type { Dataset, Dashboard, Report } from '@objectstack/spec/ui';
 import type { IAnalyticsService, DatasetSelection } from '@objectstack/spec/contracts';
 import type { FilterCondition } from '@objectstack/spec/data';
 import { reconcileDashboard, reconcileReports, type ReconcileExecutors, type WidgetReconcileResult } from './reconcile.js';