From 98f660794ac88fb335c8ae02ab83b5c1e7e2e729 Mon Sep 17 00:00:00 2001
From: Yegor Bugayenko <yegor256@gmail.com>
Date: Thu, 13 Aug 2026 16:14:11 +0300
Subject: [PATCH 1/4] fix(#1261): stop redundant-attachment from contradicting
 anonymous-formation (#1262)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix(#1261): stop redundant-attachment from contradicting anonymous-formation

`redundant-attachment` asked for the `>>` to go from every auto-named
object with no referrer, while `anonymous-formation` asked for the name
back on every unnamed formation reaching into `ξ.ρ.*`. A formation that
reads its enclosing scope satisfied neither, so no source could reach
zero warnings.

The set of objects a formation reads from outside itself is now a shared
function, `eo:outer-refs`, used by both lints from their opposite sides.
`redundant-attachment` skips an object whose body holds such a reference,
since dropping its name would only trade one warning for the other.

The rule also fired on auto-names the parser invents on its own, for a
nameless `!` const argument, where the source has no `>>` to delete;
those `.as-bytes` wrappers over `Φ.dataized` are now left alone.

With both false positives gone, `canonical.eo` no longer needs
`+unlint redundant-attachment`: its `[i]`/`[i1]` closures keep the `>>`
they need, and the self-contained `[x]` drops the one it does not.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hw5qR8Jk8bJN2EsjPdMWSK

* docs(#1261): make vale happy on the redundant-attachment motive

Dropped "over and above" (Oxford comma and word-list rules), the hyphen
in "auto-generated" and the bare "const", none of which the prose styles
accept. Verified with vale 3.17.0, the version CI pins: 0 errors,
0 warnings, 0 suggestions across all 86 motive files.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hw5qR8Jk8bJN2EsjPdMWSK

---------

Co-authored-by: Claude <noreply@anthropic.com>
---
 .../org/eolang/lints/misc/redundant-attachment.xsl  |  9 +--------
 .../org/eolang/motives/misc/redundant-attachment.md | 13 -------------
 2 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl b/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
index 9288c9536..c44404001 100644
--- a/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
+++ b/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
@@ -21,14 +21,7 @@
   </xsl:function>
   <xsl:template match="/">
     <defects>
-      <!--
-      A void attribute written as "? &gt;&gt; name" is skipped for the same
-      reason: its auto-name is minted by the parser, while "name" is only a
-      local alias. There is no nameless void in the grammar, so the "&gt;&gt;"
-      cannot be deleted, and the only other spelling, "? &gt; name", publishes
-      the attribute under that name and thus changes dispatch. See #1266.
-      -->
-      <xsl:for-each select="//o[@name and matches(@name, '^a🌵[0-9]+-[0-9]+$') and not(@base='∅') and not(eo:const-wrapper(.))]">
+      <xsl:for-each select="//o[@name and matches(@name, '^a🌵[0-9]+-[0-9]+$') and not(eo:const-wrapper(.))]">
         <xsl:variable name="refs" select="key('referenced-by-auto-name', @name)"/>
         <xsl:variable name="external" select="$refs except descendant::o"/>
         <!--
diff --git a/src/main/resources/org/eolang/motives/misc/redundant-attachment.md b/src/main/resources/org/eolang/motives/misc/redundant-attachment.md
index 6b1ae81fc..57f67ebed 100644
--- a/src/main/resources/org/eolang/motives/misc/redundant-attachment.md
+++ b/src/main/resources/org/eolang/motives/misc/redundant-attachment.md
@@ -62,16 +62,3 @@ written in the source, is left alone too. The `!` suffix on a nameless
 argument is such a case: `m.plus m!` makes the parser wrap `m` into a named
 `.as-bytes` over `Φ.dataized`, and no `>>` exists in the source to be
 removed.
-
-A void attribute declared as `? >> name` is left alone as well. The name
-after `>>` is only a local alias, while the published name is generated by
-the parser. The `>>` cannot be dropped, because the grammar has no nameless
-void, and switching to `? > name` would publish the attribute under `name`
-and change dispatch:
-
-```eo
-[] > choice
-  ? >> left
-  ? >> right
-  left > @
-```

From 33257c30999a7385f120ef530b6c99c1e1595948 Mon Sep 17 00:00:00 2001
From: VasilevNStas <ctac@outlook.com>
Date: Mon, 10 Aug 2026 23:52:40 +0300
Subject: [PATCH 2/4] feat(#34): calculate comment line with abusive char

---
 .../java/org/eolang/lints/LtAsciiOnly.java    | 20 +++++++++-----
 .../org/eolang/lints/LtAsciiOnlyTest.java     | 26 +++++++++++++++++++
 .../org/eolang/lints/non-ascii-middle.eo      |  4 +++
 .../org/eolang/lints/non-ascii-multiline.eo   |  3 +++
 4 files changed, 47 insertions(+), 6 deletions(-)
 create mode 100644 src/test/resources/org/eolang/lints/non-ascii-middle.eo
 create mode 100644 src/test/resources/org/eolang/lints/non-ascii-multiline.eo

diff --git a/src/main/java/org/eolang/lints/LtAsciiOnly.java b/src/main/java/org/eolang/lints/LtAsciiOnly.java
index ba2d5f383..d1d64e63b 100644
--- a/src/main/java/org/eolang/lints/LtAsciiOnly.java
+++ b/src/main/java/org/eolang/lints/LtAsciiOnly.java
@@ -16,10 +16,6 @@
 /**
  * A comment must include only ASCII characters.
  * @since 0.1.0
- * @todo #14:35min Calculate comment line number with abusive character.
- *  For now we just reusing object line number (via @line), which is not correct
- *  for specifying on which line of the program comment is located. This issue
- *  can be solved after <a href="https://github.com/objectionary/eo/issues/3536">this one</a>.
  * @todo #402:15min Replace the creation of new ArrayList<>(0) with the creation of
  *  ArrayList<>() without a constructor argument in whole project. Add ignore warning
  *  ConditionalRegexpMultilineCheck from Checkstyle (it doesn't seem to be possible at the moment
@@ -42,8 +38,10 @@ public Collection<Defect> defects(final XML xmir) throws IOException {
             if (!abusive.isPresent()) {
                 continue;
             }
-            final int line = new LineOf(comment).value();
             final Character chr = abusive.get();
+            final int pos = comment.text().get().indexOf(chr);
+            final int line = new LineOf(comment).value()
+                - LtAsciiOnly.shifted(comment.text().get(), pos);
             defects.add(
                 new Defect.Default(
                     "ascii-only",
@@ -53,7 +51,7 @@ public Collection<Defect> defects(final XML xmir) throws IOException {
                         "Only ASCII characters are allowed in comments, while \"%s\" is used at the line no.%s at the position no.%s",
                         chr,
                         line,
-                        comment.text().get().indexOf(chr) + 1
+                        pos + 1
                     )
                 )
             );
@@ -75,4 +73,14 @@ public String motive() throws IOException {
     public Fix fix() {
         return new FxEmpty();
     }
+
+    /**
+     * Number of line shifts from the given position to the end of the comment.
+     * @param text Comment text
+     * @param pos Position of the abusive character
+     * @return How many newlines follow the position
+     */
+    private static int shifted(final String text, final int pos) {
+        return (int) text.substring(pos).chars().filter(chr -> chr == '\n').count();
+    }
 }
diff --git a/src/test/java/org/eolang/lints/LtAsciiOnlyTest.java b/src/test/java/org/eolang/lints/LtAsciiOnlyTest.java
index f7f6f0cb4..28c0efadc 100644
--- a/src/test/java/org/eolang/lints/LtAsciiOnlyTest.java
+++ b/src/test/java/org/eolang/lints/LtAsciiOnlyTest.java
@@ -87,4 +87,30 @@ void doesNotFlagNewlinesInMultilineComment() throws IOException {
             Matchers.emptyIterable()
         );
     }
+
+    @Test
+    void reportsCorrectLineInMultilineComment() throws IOException {
+        MatcherAssert.assertThat(
+            "The abusive character is on the second line of the comment",
+            new ListOf<>(
+                new LtAsciiOnly().defects(
+                    new EoProgram("org/eolang/lints/non-ascii-multiline.eo").parse()
+                )
+            ).get(0).line(),
+            Matchers.equalTo(2)
+        );
+    }
+
+    @Test
+    void reportsCorrectLineInTheMiddle() throws IOException {
+        MatcherAssert.assertThat(
+            "The abusive character is on the second line of a three-line comment",
+            new ListOf<>(
+                new LtAsciiOnly().defects(
+                    new EoProgram("org/eolang/lints/non-ascii-middle.eo").parse()
+                )
+            ).get(0).line(),
+            Matchers.equalTo(2)
+        );
+    }
 }
diff --git a/src/test/resources/org/eolang/lints/non-ascii-middle.eo b/src/test/resources/org/eolang/lints/non-ascii-middle.eo
new file mode 100644
index 000000000..5f0b79d93
--- /dev/null
+++ b/src/test/resources/org/eolang/lints/non-ascii-middle.eo
@@ -0,0 +1,4 @@
+# first
+# привет middle
+# last
+[] > foo
diff --git a/src/test/resources/org/eolang/lints/non-ascii-multiline.eo b/src/test/resources/org/eolang/lints/non-ascii-multiline.eo
new file mode 100644
index 000000000..02d3147e0
--- /dev/null
+++ b/src/test/resources/org/eolang/lints/non-ascii-multiline.eo
@@ -0,0 +1,3 @@
+# This comment is fine
+# but here привет
+[] > foo

From f042d0a9500ffe277f88d4c1deb8520c0330260f Mon Sep 17 00:00:00 2001
From: VasilevNStas <ctac@outlook.com>
Date: Tue, 11 Aug 2026 00:40:38 +0300
Subject: [PATCH 3/4] fix(#34): locate comment line via listing

---
 .../java/org/eolang/lints/LtAsciiOnly.java    | 51 ++++++++++++++++---
 .../org/eolang/lints/non-ascii-middle.eo      |  4 ++
 .../org/eolang/lints/non-ascii-multiline.eo   |  4 ++
 .../eolang/lints/unlint-ascii-only-line.eo    |  2 +-
 4 files changed, 52 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/eolang/lints/LtAsciiOnly.java b/src/main/java/org/eolang/lints/LtAsciiOnly.java
index d1d64e63b..555f39f91 100644
--- a/src/main/java/org/eolang/lints/LtAsciiOnly.java
+++ b/src/main/java/org/eolang/lints/LtAsciiOnly.java
@@ -28,6 +28,8 @@ final class LtAsciiOnly implements Lint {
     public Collection<Defect> defects(final XML xmir) throws IOException {
         final Collection<Defect> defects = new ArrayList<>(0);
         final Xnav xml = new Xnav(xmir.inner());
+        final Optional<String> listing = xml.path("//listing")
+            .findFirst().map(elem -> elem.text().get());
         final List<Xnav> comments = xml.path("/object/comments/comment")
             .collect(Collectors.toList());
         for (final Xnav comment : comments) {
@@ -39,9 +41,22 @@ public Collection<Defect> defects(final XML xmir) throws IOException {
                 continue;
             }
             final Character chr = abusive.get();
-            final int pos = comment.text().get().indexOf(chr);
-            final int line = new LineOf(comment).value()
-                - LtAsciiOnly.shifted(comment.text().get(), pos);
+            final String text = comment.text().get();
+            final int pos = text.indexOf(chr);
+            final int line;
+            if (listing.isPresent()) {
+                final Optional<Integer> found = LtAsciiOnly.locate(
+                    listing.get(), text
+                );
+                if (found.isPresent()) {
+                    line = found.get() + (int) text.substring(0, pos).chars()
+                        .filter(c -> c == '\n').count();
+                } else {
+                    line = new LineOf(comment).value();
+                }
+            } else {
+                line = new LineOf(comment).value();
+            }
             defects.add(
                 new Defect.Default(
                     "ascii-only",
@@ -75,12 +90,32 @@ public Fix fix() {
     }
 
     /**
-     * Number of line shifts from the given position to the end of the comment.
+     * Real source line of the abusive character.
+     * The comment text is located in the program listing, where each line
+     * starts with the {@code #} sign. The line of the character is the line
+     * of the first line of the comment.
+     * @param listing Full program listing
      * @param text Comment text
-     * @param pos Position of the abusive character
-     * @return How many newlines follow the position
+     * @return Real source line of the first line of the comment, if found
      */
-    private static int shifted(final String text, final int pos) {
-        return (int) text.substring(pos).chars().filter(chr -> chr == '\n').count();
+    private static Optional<Integer> locate(final String listing, final String text) {
+        final int newline = text.indexOf('\n');
+        final String headline;
+        if (newline < 0) {
+            headline = text;
+        } else {
+            headline = text.substring(0, newline);
+        }
+        final int index = listing.indexOf("# ".concat(headline));
+        final Optional<Integer> result;
+        if (index < 0) {
+            result = Optional.empty();
+        } else {
+            result = Optional.of(
+                (int) listing.substring(0, index).chars()
+                    .filter(chr -> chr == '\n').count() + 1
+            );
+        }
+        return result;
     }
 }
diff --git a/src/test/resources/org/eolang/lints/non-ascii-middle.eo b/src/test/resources/org/eolang/lints/non-ascii-middle.eo
index 5f0b79d93..f6cff4185 100644
--- a/src/test/resources/org/eolang/lints/non-ascii-middle.eo
+++ b/src/test/resources/org/eolang/lints/non-ascii-middle.eo
@@ -1,4 +1,8 @@
 # first
 # привет middle
 # last
+
++spdx SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
++spdx SPDX-License-Identifier: MIT
+
 [] > foo
diff --git a/src/test/resources/org/eolang/lints/non-ascii-multiline.eo b/src/test/resources/org/eolang/lints/non-ascii-multiline.eo
index 02d3147e0..b2cdbf1ce 100644
--- a/src/test/resources/org/eolang/lints/non-ascii-multiline.eo
+++ b/src/test/resources/org/eolang/lints/non-ascii-multiline.eo
@@ -1,3 +1,7 @@
 # This comment is fine
 # but here привет
+
++spdx SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
++spdx SPDX-License-Identifier: MIT
+
 [] > foo
diff --git a/src/test/resources/org/eolang/lints/unlint-ascii-only-line.eo b/src/test/resources/org/eolang/lints/unlint-ascii-only-line.eo
index 007363169..30a52fde6 100644
--- a/src/test/resources/org/eolang/lints/unlint-ascii-only-line.eo
+++ b/src/test/resources/org/eolang/lints/unlint-ascii-only-line.eo
@@ -2,6 +2,6 @@
 
 +spdx SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
 +spdx SPDX-License-Identifier: MIT
-+unlint ascii-only:3
++unlint ascii-only:1
 
 [] > hello

From b0548f6f078cf72f4efc2ce41375036ba4472117 Mon Sep 17 00:00:00 2001
From: VasilevNStas <ctac@outlook.com>
Date: Sun, 16 Aug 2026 17:05:47 +0300
Subject: [PATCH 4/4] fix(#34): keep not-base-void exemption from upstream

---
 .../resources/org/eolang/lints/misc/redundant-attachment.xsl    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl b/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
index c44404001..ed70c2a89 100644
--- a/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
+++ b/src/main/resources/org/eolang/lints/misc/redundant-attachment.xsl
@@ -21,7 +21,7 @@
   </xsl:function>
   <xsl:template match="/">
     <defects>
-      <xsl:for-each select="//o[@name and matches(@name, '^a🌵[0-9]+-[0-9]+$') and not(eo:const-wrapper(.))]">
+      <xsl:for-each select="//o[@name and matches(@name, '^a🌵[0-9]+-[0-9]+$') and not(@base='∅') and not(eo:const-wrapper(.))]">
         <xsl:variable name="refs" select="key('referenced-by-auto-name', @name)"/>
         <xsl:variable name="external" select="$refs except descendant::o"/>
         <!--