dtls: take the psk error message as a string_view

ReportPSKError took a const char* and passed it to ToV8Value(), which
already has a std::string_view overload. Every call site hands it a
literal, so the length is known rather than recovered with strlen().

Signed-off-by: James M Snell <jasnell@gmail.com>

Author: jasnell

src/dtls/dtls_context.cc

@@ -663,7 +663,7 @@ void DTLSContext::SetSNIContexts(const FunctionCallbackInfo<Value>& args) {
 // as an uncaughtException. The exception must not still be pending when
 // control returns to OpenSSL, which goes on to build an alert and unwind
 // through Cycle()'s error path.
-void DTLSContext::ReportPSKError(SSL* ssl, const char* message) {
+void DTLSContext::ReportPSKError(SSL* ssl, std::string_view message) {
   DTLSSession* session = static_cast<DTLSSession*>(SSL_get_app_data(ssl));
   if (session == nullptr) return;
 

src/dtls/dtls_context.h

@@ -14,6 +14,7 @@
 #include <openssl/ssl.h>
 
 #include <string>
+#include <string_view>
 #include <unordered_map>
 #include <vector>
 
@@ -94,7 +95,7 @@ class DTLSContext final : public BaseObject {
   // Report a PSK callback that did not throw but gave back something
   // unusable. Returning 0 to OpenSSL is the "no PSK" signal, so without this
   // the caller's mistake arrives as a handshake failure naming no cause.
-  static void ReportPSKError(SSL* ssl, const char* message);
+  static void ReportPSKError(SSL* ssl, std::string_view message);
 
   DTLSContext* SelectSNIContextFromCallback(SSL* ssl, const char* servername);
   // Recover the context a callback without an argument slot belongs to.