Apply dont_error_on_const_folding_with_invalid_input.patch

Author: hackorum

src/backend/executor/execExpr.c

@@ -140,7 +140,17 @@ static void ExecInitJsonCoercion(ExprState *state, JsonReturning *returning,
  * although ExecQual and ExecCheck will accept one (and treat it as "true").
  */
 ExprState *
-ExecInitExpr(Expr *node, PlanState *parent)
+ExecInitExpr(Expr* node, PlanState* parent)
+{
+	return ExecInitExprWithErrorContext(node, parent, NULL);
+}
+
+/*
+ * As ExecInitExpr but attempt to save errors into 'err_context' when
+ * supported by the functions being called. XXX write something better here.
+ */
+ExprState *
+ExecInitExprWithErrorContext(Expr *node, PlanState *parent, fmNodePtr *err_context)
 {
 	ExprState  *state;
 	ExprEvalStep scratch = {0};
@@ -154,6 +164,7 @@ ExecInitExpr(Expr *node, PlanState *parent)
 	state->expr = node;
 	state->parent = parent;
 	state->ext_params = NULL;
+	state->err_context = err_context;
 
 	/* Insert setup steps as needed */
 	ExecCreateExprSetupSteps(state, (Node *) node);
@@ -2736,7 +2747,7 @@ ExecInitFunc(ExprEvalStep *scratch, Expr *node, List *args, Oid funcid,
 
 	/* Initialize function call parameter structure too */
 	InitFunctionCallInfoData(*fcinfo, flinfo,
-							 nargs, inputcollid, NULL, NULL);
+							 nargs, inputcollid, (fmNodePtr) state->err_context, NULL);
 
 	/* Keep extra copies of this info to save an indirection at runtime */
 	scratch->d.func.fn_addr = flinfo->fn_addr;

src/backend/optimizer/util/clauses.c

@@ -32,6 +32,7 @@
 #include "funcapi.h"
 #include "miscadmin.h"
 #include "nodes/makefuncs.h"
+#include "nodes/miscnodes.h"
 #include "nodes/multibitmapset.h"
 #include "nodes/nodeFuncs.h"
 #include "nodes/subscripting.h"
@@ -2705,7 +2706,7 @@ estimate_expression_value(PlannerInfo *root, Node *node)
 	((Node *) evaluate_expr((Expr *) (node), \
 							exprType((Node *) (node)), \
 							exprTypmod((Node *) (node)), \
-							exprCollation((Node *) (node))))
+							exprCollation((Node *) (node)), false))
 
 /*
  * Recursive guts of eval_const_expressions/estimate_expression_value
@@ -3741,7 +3742,8 @@ eval_const_expressions_mutator(Node *node,
 					return (Node *) evaluate_expr((Expr *) svf,
 												  svf->type,
 												  svf->typmod,
-												  InvalidOid);
+												  InvalidOid,
+												  false);
 				else
 					return copyObject((Node *) svf);
 			}
@@ -5293,7 +5295,7 @@ evaluate_function(Oid funcid, Oid result_type, int32 result_typmod,
 	newexpr->location = -1;
 
 	return evaluate_expr((Expr *) newexpr, result_type, result_typmod,
-						 result_collid);
+						 result_collid, true);
 }
 
 /*
@@ -5747,11 +5749,16 @@ sql_inline_error_callback(void *arg)
  *
  * We use the executor's routine ExecEvalExpr() to avoid duplication of
  * code and ensure we get the same result as the executor would get.
+ *
+ * 'null_on_error' may be passed as true to have the expression evalulation
+ * code attempt to supress ERRORs and save them.  This of course requires
+ * functions properly errsave/ereturn rather than elog/ereport.
  */
 Expr *
 evaluate_expr(Expr *expr, Oid result_type, int32 result_typmod,
-			  Oid result_collation)
+			  Oid result_collation, bool null_on_error)
 {
+	ErrorSaveContext escontext = {T_ErrorSaveContext};
 	EState	   *estate;
 	ExprState  *exprstate;
 	MemoryContext oldcontext;
@@ -5775,7 +5782,12 @@ evaluate_expr(Expr *expr, Oid result_type, int32 result_typmod,
 	 * Prepare expr for execution.  (Note: we can't use ExecPrepareExpr
 	 * because it'd result in recursively invoking eval_const_expressions.)
 	 */
-	exprstate = ExecInitExpr(expr, NULL);
+	if (null_on_error)
+		exprstate = ExecInitExprWithErrorContext(expr,
+												 NULL,
+												 (fmNodePtr *) &escontext);
+	else
+		exprstate = ExecInitExpr(expr, NULL);
 
 	/*
 	 * And evaluate it.
@@ -5803,7 +5815,7 @@ evaluate_expr(Expr *expr, Oid result_type, int32 result_typmod,
 	 * data.  (makeConst would handle detoasting anyway, but it's worth a few
 	 * extra lines here so that we can do the copy and detoast in one step.)
 	 */
-	if (!const_is_null)
+	if (!escontext.error_occurred && !const_is_null)
 	{
 		if (resultTypLen == -1)
 			const_val = PointerGetDatum(PG_DETOAST_DATUM_COPY(const_val));
@@ -5814,6 +5826,9 @@ evaluate_expr(Expr *expr, Oid result_type, int32 result_typmod,
 	/* Release all the junk we just created */
 	FreeExecutorState(estate);
 
+	if (escontext.error_occurred)
+		return NULL;
+
 	/*
 	 * Make the constant result node.
 	 */

src/backend/parser/parse_utilcmd.c

@@ -5212,7 +5212,7 @@ transformPartitionBoundValue(ParseState *pstate, Node *val,
 		assign_expr_collations(pstate, value);
 		value = (Node *) expression_planner((Expr *) value);
 		value = (Node *) evaluate_expr((Expr *) value, colType, colTypmod,
-									   partCollation);
+									   partCollation, false);
 		if (!IsA(value, Const))
 			elog(ERROR, "could not evaluate partition bound expression");
 	}

src/include/executor/executor.h

@@ -332,6 +332,8 @@ ExecProcNode(PlanState *node)
  * prototypes from functions in execExpr.c
  */
 extern ExprState *ExecInitExpr(Expr *node, PlanState *parent);
+extern ExprState *ExecInitExprWithErrorContext(Expr *node, PlanState *parent,
+											   fmNodePtr *err_context);
 extern ExprState *ExecInitExprWithParams(Expr *node, ParamListInfo ext_params);
 extern ExprState *ExecInitQual(List *qual, PlanState *parent);
 extern ExprState *ExecInitCheck(List *qual, PlanState *parent);

src/include/nodes/execnodes.h

@@ -146,6 +146,12 @@ typedef struct ExprState
 	PlanState  *parent;			/* parent PlanState node, if any */
 	ParamListInfo ext_params;	/* for compiling PARAM_EXTERN nodes */
 
+	/*
+	 * ErrorSaveContext pointer to record any saved ERRORs into or NULL if
+	 * errors are to be raised right away.
+	 */
+	fmNodePtr *err_context;
+
 	Datum	   *innermost_caseval;
 	bool	   *innermost_casenull;
 

src/include/optimizer/optimizer.h

@@ -151,7 +151,7 @@ extern void convert_saop_to_hashed_saop(Node *node);
 extern Node *estimate_expression_value(PlannerInfo *root, Node *node);
 
 extern Expr *evaluate_expr(Expr *expr, Oid result_type, int32 result_typmod,
-						   Oid result_collation);
+						   Oid result_collation, bool null_on_error);
 
 extern bool var_is_nonnullable(PlannerInfo *root, Var *var,
 							   NotNullSource source);