strengthen backup history filename check

zhjwpku · hackorum · commit bcb846af4642 · 2022-07-25T11:31:08.000Z
Signed-off-by: Junwang Zhao &lt;zhjwpku@gmail.com&gt;
diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h
@@ -251,9 +251,10 @@ BackupHistoryFileName(char *fname, TimeLineID tli, XLogSegNo logSegNo, XLogRecPt
 static inline bool
 IsBackupHistoryFileName(const char *fname)
 {
-	return (strlen(fname) > XLOG_FNAME_LEN &&
+	return (strlen(fname) == XLOG_FNAME_LEN + 9 + strlen(".backup") &&
 			strspn(fname, "0123456789ABCDEF") == XLOG_FNAME_LEN &&
-			strcmp(fname + strlen(fname) - strlen(".backup"), ".backup") == 0);
+			strspn(fname + XLOG_FNAME_LEN + 1, "0123456789ABCDEF") == 8 &&
+			strcmp(fname + XLOG_FNAME_LEN + 9, ".backup") == 0);
 }
 
 static inline void

Original file line number	Diff line number	Diff line change
`@@ -251,9 +251,10 @@ BackupHistoryFileName(char *fname, TimeLineID tli, XLogSegNo logSegNo, XLogRecPt`
`251`	`251`	`static inline bool`
`252`	`252`	`IsBackupHistoryFileName(const char *fname)`
`253`	`253`	`{`
`254`		`- return (strlen(fname) > XLOG_FNAME_LEN &&`
	`254`	`+ return (strlen(fname) == XLOG_FNAME_LEN + 9 + strlen(".backup") &&`
`255`	`255`	`strspn(fname, "0123456789ABCDEF") == XLOG_FNAME_LEN &&`
`256`		`- strcmp(fname + strlen(fname) - strlen(".backup"), ".backup") == 0);`
	`256`	`+ strspn(fname + XLOG_FNAME_LEN + 1, "0123456789ABCDEF") == 8 &&`
	`257`	`+ strcmp(fname + XLOG_FNAME_LEN + 9, ".backup") == 0);`
`257`	`258`	`}`
`258`	`259`
`259`	`260`	`static inline void`