[lint-monster] LintMonster: package-level mutable state cleanup

[github-actions]

Summary

Daily make golint-custom surfaced a small non-largefunc cluster about package-level mutable slice/map state being reassigned, which risks shared-state leakage and data races.

Current findings: 5

Affected paths:

• pkg/parser/virtual_fs.go:46 — builtinVirtualFiles
• pkg/actionpins/data.go:45 — cachedActionPins
• pkg/actionpins/data.go:47 — cachedActionPinsByRepo
• pkg/actionpins/data.go:50 — cachedContainerPins
• pkg/actionpins/data.go:52 — additional reassignment path for cachedContainerPins

Representative diagnostics:

• pkg/parser/virtual_fs.go:46:2: package-level slice/map variable builtinVirtualFiles is mutated via wholesale re-assignment; mutating shared package state risks data races and can leak state across calls
• pkg/actionpins/data.go:45:3: package-level slice/map variable cachedActionPins is mutated via wholesale re-assignment; mutating shared package state risks data races and can leak state across calls

Expected outcome

Refactor the affected code so package-level slice/map data is not reassigned in a way that creates shared mutable state hazards, while preserving existing behavior and call sites.

Remediation checklist

• Keep remediation scoped to the listed package-level mutable-state findings only.
• Prefer minimal, targeted edits such as immutable snapshots, copy-on-write helpers, or encapsulated initialization.
• Preserve public behavior and existing tests.
• Validate with make golint-custom after changes.
• Avoid bundling unrelated cleanup.

Copilot instructions

1. Work only on the pkg/parser/virtual_fs.go and pkg/actionpins/data.go mutable package-state findings.
2. Replace whole-sale reassignment patterns with safer initialization/copy patterns.
3. Keep edits local and behavior-preserving.
4. Do not take on unrelated largefunc cleanup.
5. Validate with make golint-custom before finishing.

Generated by 🧌 LintMonster · gpt54 · 29.2 AIC · ⌖ 4.25 AIC · ⊞ 6K · ◷

• expires on Aug 25, 2026, 6:51 PM UTC-08:00

---

Summary

Daily make golint-custom still shows package-level mutable slice/map state being reassigned, which risks shared-state leakage and data races.

Current findings: 13

Affected paths:

• pkg/parser/virtual_fs.go:46 — builtinVirtualFiles
• pkg/actionpins/data.go:45 — cachedActionPins
• pkg/actionpins/data.go:47 — cachedActionPinsByRepo
• pkg/actionpins/data.go:50 and :52 — cachedContainerPins
• pkg/workflow/engine_definition.go:433 — knownEngineImports
• pkg/workflow/model_aliases.go:93 — builtinOnlyAliasMap
• pkg/workflow/runtime_definitions.go:242 — allManifestFilesBaseCache
• pkg/workflow/samples_validation.go:172 — sortedSafeOutputFieldNames
• pkg/cli/model_costs.go:50 and :73 — modelPriceRecords
• pkg/cli/update_version_labels.go:73 and :86 — versionLabelCache

Representative diagnostics:

• pkg/parser/virtual_fs.go:46:2: package-level slice/map variable builtinVirtualFiles is mutated via wholesale re-assignment; mutating shared package state risks data races and can leak state across calls
• pkg/actionpins/data.go:45:3: package-level slice/map variable cachedActionPins is mutated via wholesale re-assignment; mutating shared package state risks data races and can leak state across calls
• pkg/cli/model_costs.go:73:5: package-level slice/map variable modelPriceRecords is mutated via append() re-assignment; mutating shared package state risks data races and can leak state across calls

Expected outcome

Refactor the affected code so package-level slice/map data is not mutated in shared-state patterns, while preserving behavior and existing callers.

Remediation checklist

• Keep remediation scoped to the listed package-level mutable-state findings only.
• Prefer minimal, targeted edits such as immutable snapshots, copy-on-write helpers, or encapsulated initialization.
• Preserve public behavior and existing tests.
• Validate with make golint-custom after changes.
• Avoid bundling unrelated cleanup.

Copilot instructions

1. Work only on the listed package-level mutable-state findings.
2. Replace whole-sale reassignment, append reassignment, and index assignment patterns with safer initialization/copy patterns.
3. Keep edits local and behavior-preserving.
4. Do not take on unrelated largefunc cleanup.
5. Validate with make golint-custom before finishing.> Generated by 🧌 LintMonster · gpt54 · 33.2 AIC · ⌖ 6.66 AIC · ⊞ 6K · ◷

[github-actions]

🍪 Issue Monster selected this for Copilot

I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

🍪 Om nom nom by Issue Monster · gpt54 · 3.63 AIC · ⌖ 9.62 AIC · ⊞ 8.6K · ◷