Ruby: Cfg replacement wip

Author: aschackmull

ruby/ql/consistency-queries/CfgConsistency.ql

@@ -1,31 +1,2 @@
-import codeql.ruby.controlflow.internal.ControlFlowGraphImpl::Consistency as Consistency
-import Consistency
-import codeql.ruby.AST
 import codeql.ruby.CFG
-import codeql.ruby.controlflow.internal.Completion
-import codeql.ruby.controlflow.internal.ControlFlowGraphImpl as CfgImpl
-
-/**
- * All `Expr` nodes are `PostOrderTree`s
- */
-query predicate nonPostOrderExpr(Expr e, string cls) {
-  cls = e.getPrimaryQlClasses() and
-  not exists(e.getDesugared()) and
-  not e instanceof BodyStmt and
-  exists(AstNode last, Completion c |
-    CfgImpl::last(e, last, c) and
-    last != e and
-    c instanceof NormalCompletion
-  )
-}
-
-query predicate scopeNoFirst(CfgScope scope) {
-  Consistency::scopeNoFirst(scope) and
-  not scope = any(StmtSequence seq | not exists(seq.getAStmt())) and
-  not scope =
-    any(Callable c |
-      not exists(c.getAParameter()) and
-      not c.getBody().hasEnsure() and
-      not exists(c.getBody().getARescue())
-    )
-}
+import ControlFlow::Consistency

ruby/ql/consistency-queries/DataFlowConsistency.ql

@@ -22,17 +22,6 @@ private module Input implements InputSig<Location, RubyDataFlow> {
     not isNonConstantExpr(n.asExpr())
   }
 
-  predicate multipleArgumentCallExclude(ArgumentNode arg, DataFlowCall call) {
-    // An argument such as `x` in `if not x then ...` has two successors (and hence
-    // two calls); one for each Boolean outcome of `x`.
-    exists(CfgNodes::ExprCfgNode n |
-      arg.argumentOf(call, _) and
-      n = call.asCall() and
-      arg.asExpr().getASuccessor(any(ConditionalSuccessor c)).getASuccessor*() = n and
-      n.getASplit() instanceof Split::ConditionalCompletionSplit
-    )
-  }
-
   predicate uniqueTypeExclude(Node n) {
     n =
       any(DataFlow::CallNode call |

ruby/ql/lib/codeql/ruby/CFG.qll

@@ -3,4 +3,3 @@
 import codeql.Locations
 import controlflow.ControlFlowGraph
 import controlflow.CfgNodes as CfgNodes
-import controlflow.BasicBlocks

ruby/ql/lib/codeql/ruby/ast/Statement.qll

@@ -6,22 +6,21 @@ private import codeql.ruby.CFG
 private import internal.AST
 private import internal.TreeSitter
 private import internal.Variable
-private import codeql.ruby.controlflow.internal.ControlFlowGraphImpl as CfgImpl
 
 /**
  * A statement.
  *
  * This is the root QL class for all statements.
  */
 class Stmt extends AstNode, TStmt {
+  /** Gets the control-flow node for this statement, if any. */
+  ControlFlowNode getControlFlowNode() { result.injects(this) }
+
   /** Gets a control-flow node for this statement, if any. */
   CfgNodes::AstCfgNode getAControlFlowNode() { result.getAstNode() = this }
 
-  /** Gets a control-flow entry node for this statement, if any */
-  AstNode getAControlFlowEntryNode() { result = CfgImpl::getAControlFlowEntryNode(this) }
-
   /** Gets the control-flow scope of this statement, if any. */
-  CfgScope getCfgScope() { result = CfgImpl::getCfgScope(this) }
+  CfgScope getCfgScope() { result = getEnclosingCallable(this) }
 
   /** Gets the enclosing callable, if any. */
   Callable getEnclosingCallable() { result = this.getCfgScope() }