From b243377797672acbf7ca56ea92f39a1e27477770 Mon Sep 17 00:00:00 2001
From: "Claude (RC validation pass)" <etienne@etiennelescot.fr>
Date: Sun, 19 Jul 2026 21:16:34 +0200
Subject: [PATCH] fix(test): repair windows-native-checklist.spec.ts's broken
 open-video/open-project flow

Fixes #130. Two tests referenced hudWindow testids
(launch-open-video-button, launch-open-project-button) that don't exist
anywhere in LaunchWindow.tsx -- the spec self-skips off-Windows and CI is
Linux-only, so this had never actually been caught by a real run.

- Add data-testid to EditorEmptyState's Import Video File / Load Project
  buttons (previously untestable, no selector at all).
- Route both tests through the real flow: HUD "Open Studio" -> editor
  empty state -> the new testids.
- Fix the getCurrentVideoPath mock in the load-project test: it stubbed a
  video as already current, which made VideoEditor skip past
  EditorEmptyState entirely once the flow went through it (real bug in
  the mock, exposed by fixing the navigation path).
- Two more bugs the same execution gap let through, fixed while verifying
  locally: a strict-mode-violating "Background" text locator matching two
  elements, and an assertion on the export button before ever opening the
  export panel that renders it.

Verified locally on macOS by temporarily bypassing the win32-only skip:
both previously-broken tests now pass end-to-end (build-vite + playwright
test tests/e2e/windows-native-checklist.spec.ts).
---
 src/components/video-editor/EditorEmptyState.tsx |  2 ++
 tests/e2e/windows-native-checklist.spec.ts       | 15 +++++++++++----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/components/video-editor/EditorEmptyState.tsx b/src/components/video-editor/EditorEmptyState.tsx
index 2a5c49547..3b7bd773c 100644
--- a/src/components/video-editor/EditorEmptyState.tsx
+++ b/src/components/video-editor/EditorEmptyState.tsx
@@ -180,6 +180,7 @@ export function EditorEmptyState({ onVideoImported, onProjectOpened }: EditorEmp
 				<div className="flex flex-col gap-3 w-full max-w-xs">
 					<button
 						type="button"
+						data-testid="editor-empty-import-video-button"
 						onClick={handleImportVideo}
 						className="flex items-center justify-center gap-2.5 w-full px-4 py-3 rounded-xl bg-[#34B27B] hover:bg-[#2d9e6c] active:bg-[#27885c] text-white font-medium text-sm transition-colors outline-none focus-visible:ring-2 focus-visible:ring-[#34B27B] focus-visible:ring-offset-2 focus-visible:ring-offset-[#09090b]"
 					>
@@ -188,6 +189,7 @@ export function EditorEmptyState({ onVideoImported, onProjectOpened }: EditorEmp
 					</button>
 					<button
 						type="button"
+						data-testid="editor-empty-load-project-button"
 						onClick={handleLoadProject}
 						className="flex items-center justify-center gap-2.5 w-full px-4 py-3 rounded-xl bg-white/5 hover:bg-white/10 border border-white/10 text-slate-300 font-medium text-sm transition-colors outline-none focus-visible:ring-2 focus-visible:ring-white/30 focus-visible:ring-offset-2 focus-visible:ring-offset-[#09090b]"
 					>
diff --git a/tests/e2e/windows-native-checklist.spec.ts b/tests/e2e/windows-native-checklist.spec.ts
index d1fdf58be..fa57d8b28 100644
--- a/tests/e2e/windows-native-checklist.spec.ts
+++ b/tests/e2e/windows-native-checklist.spec.ts
@@ -183,12 +183,13 @@ test.describe("Windows native checklist smoke tests", () => {
 				}));
 			}, testVideoInRecordings);
 
-			await hudWindow.getByTestId("launch-open-video-button").click();
+			await hudWindow.getByTestId("launch-open-studio-button").click();
 			const editorWindow = await app.waitForEvent("window", {
 				predicate: (w) => w.url().includes("windowType=editor"),
 				timeout: 15_000,
 			});
 			await editorWindow.waitForLoadState("domcontentloaded");
+			await editorWindow.getByTestId("editor-empty-import-video-button").click();
 			await expect(editorWindow.getByText("Loading video...")).not.toBeVisible({ timeout: 20_000 });
 
 			const playButton = editorWindow.locator(
@@ -208,8 +209,9 @@ test.describe("Windows native checklist smoke tests", () => {
 			await expect.poll(() => seekInput.inputValue(), { timeout: 10_000 }).not.toBe("0");
 
 			await expect(
-				editorWindow.getByText("Background").or(editorWindow.getByText("Arrière-plan")),
+				editorWindow.getByText("Background").or(editorWindow.getByText("Arrière-plan")).first(),
 			).toBeVisible();
+			await editorWindow.getByTestId("testId-export-panel-button").click();
 			await expect(editorWindow.getByTestId("testId-export-button")).toBeVisible();
 		} finally {
 			await closeApp(app);
@@ -262,7 +264,10 @@ test.describe("Windows native checklist smoke tests", () => {
 							return success({ success: false, canceled: true });
 						}
 						if (request.domain === "project" && request.action === "getCurrentVideoPath") {
-							return success({ success: true, path: payload.videoPath });
+							// No video set yet at editor mount time — the editor must show
+							// EditorEmptyState so the test can click "Load Project" itself,
+							// rather than short-circuiting straight into a "loaded" state.
+							return success({ success: false });
 						}
 						if (request.domain === "system" && request.action === "getPlatform") {
 							return success("win32");
@@ -301,13 +306,15 @@ test.describe("Windows native checklist smoke tests", () => {
 				},
 			);
 
-			await hudWindow.getByTestId("launch-open-project-button").click();
+			await hudWindow.getByTestId("launch-open-studio-button").click();
 			const editorWindow = await app.waitForEvent("window", {
 				predicate: (w) => w.url().includes("windowType=editor"),
 				timeout: 15_000,
 			});
 			await editorWindow.waitForLoadState("domcontentloaded");
+			await editorWindow.getByTestId("editor-empty-load-project-button").click();
 			await expect(editorWindow.getByText("Loading video...")).not.toBeVisible({ timeout: 20_000 });
+			await editorWindow.getByTestId("testId-export-panel-button").click();
 			await expect(editorWindow.getByTestId("testId-export-button")).toBeVisible();
 		} finally {
 			await closeApp(app);