Skip to content

windows-native-checklist.spec.ts references testids that don't exist (launch-open-video-button, launch-open-project-button) #130

Description

@EtienneLescot

Summary

While validating v1.7.0-rc.3 (testing the packaged macOS build) I went looking for the "open existing video file from the launch window" flow described in docs/testing/rc-e2e-checklist.md and AGENTS.md, and couldn't find a matching button anywhere in the HUD's compact toolbar.

Tracing it back: tests/e2e/windows-native-checklist.spec.ts has two tests that reference testids which don't exist anywhere in the actual component tree:

tests/e2e/windows-native-checklist.spec.ts:186:  await hudWindow.getByTestId("launch-open-video-button").click();
tests/e2e/windows-native-checklist.spec.ts:304:  await hudWindow.getByTestId("launch-open-project-button").click();
$ grep -rn 'testId={?"launch-\|data-testid="launch-' src/ --include="*.tsx" | sort
src/components/launch/LaunchWindow.tsx:1001:  data-testid="launch-microphone-button"
src/components/launch/LaunchWindow.tsx:1015:  data-testid="launch-webcam-button"
src/components/launch/LaunchWindow.tsx:1029:  data-testid="launch-cursor-mode-button"
src/components/launch/LaunchWindow.tsx:1067:  data-testid="launch-record-button"
src/components/launch/LaunchWindow.tsx:1183:  data-testid="launch-open-studio-button"
src/components/launch/LaunchWindow.tsx:947:  data-testid="launch-tray-layout-button"
src/components/launch/LaunchWindow.tsx:968:  data-testid="launch-source-selector-button"
src/components/launch/LaunchWindow.tsx:988:  data-testid="launch-system-audio-button"

No launch-open-video-button or launch-open-project-button anywhere. The actual "Import Video File…" / "Load Project…" buttons live in EditorEmptyState.tsx (reached via HUD → "Open Studio" → empty editor state when no video is loaded) and have no data-testid at all.

Why this hasn't been caught

windows-native-checklist.spec.ts self-skips on every platform except win32 (test.skip(process.platform !== "win32")), and per AGENTS.md, CI runs on Linux only. So these two tests have (as far as I can tell) never actually executed — they'd fail immediately with a timeout on getByTestId(...).click() the first time someone runs this suite on real Windows.

Impact

  • The underlying feature works fine (verified manually: HUD → Open Studio → Import Video File… successfully loads an existing recording into the editor).
  • But this spec file gives false confidence that it's covered by an automated Windows check, when two of its three tests would fail on first real execution.

Suggested fix

Either:

  1. Add data-testid="launch-open-studio-button"-style testids to the actual buttons in EditorEmptyState.tsx and update the two tests to navigate via "Open Studio" first, or
  2. If there's a reason the HUD used to have direct open-video/open-project buttons and they were removed/refactored away, restore equivalent entry points and testids.

Either way, worth also getting this spec running somewhere in CI (even just linting/typechecking the spec, or a scheduled Windows runner) so silent testid drift like this doesn't recur.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions