From ced24f826a07a2a79d1cdd2b4940b2e9a170e0b9 Mon Sep 17 00:00:00 2001 From: Brandon Corbett Date: Wed, 8 Jul 2026 11:20:58 -0400 Subject: [PATCH 1/2] chore: Node 24 LTS baseline and AGENTS.md standards - .nvmrc -> 24 (single source of truth) - engines.node -> >=24 <25 - CI setup-node uses node-version-file: .nvmrc - AGENTS.md: insert the fells-code baseline working standards block --- .github/workflows/ci.yml | 2 +- .github/workflows/publish.yml | 2 +- .nvmrc | 1 + AGENTS.md | 35 +++++++++++++++++++++++++++++++++++ package.json | 2 +- 5 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 17abceb..f9cc155 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: 20 + node-version-file: '.nvmrc' cache: npm - name: Install dependencies diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index cb4949e..ea9bcf1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -19,7 +19,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: 20 + node-version-file: '.nvmrc' registry-url: https://registry.npmjs.org cache: npm diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 0000000..a45fd52 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +24 diff --git a/AGENTS.md b/AGENTS.md index 6acc1f6..ce0c65b 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -8,6 +8,41 @@ The repo is currently in an early, docs-first stage. Use this file to keep imple - `seamless-auth-api` - `seamless-auth-server` +## Working Standards (fells-code baseline) + +These rules apply to every repository in the fells-code org. Repo-specific +guidance may extend them but must not contradict them. + +### Attribution +- Commit and open PRs solely under the repository owner's identity. Never + commit under an agent or assistant identity. +- Never attribute work to an AI assistant: no `Co-Authored-By: Claude` (or any + assistant) trailers, no "Generated with" / "Created with Claude" notes, and no + assistant branding or emoji anywhere in commit messages, PR or issue titles + and descriptions, changesets, code comments, or docs. + +### Comments +- Comment only when the code genuinely needs explaining: a non-obvious reason, a + gotcha, or an invariant. Never narrate what the code plainly does. + +### TODOs +- Every `TODO`/`FIXME` must reference a ticket, e.g. `// TODO(#123): ...`. + Do not leave a bare TODO. If no ticket exists, create one first. + +### Commits & branches +- Conventional Commits (`feat:`, `fix:`, `chore:`, `docs:`, `ci:`, `test:`). +- Descriptive branch names (`feat/...`, `fix/...`); never a `claude/` or other + tool-generated prefix. + +### Public-facing text +- No em dashes in commit messages, code comments, PR or issue text, changesets, + or docs. Use a comma, parentheses, or a separate sentence. + +### Before declaring work done +- Run the repo's checks (typecheck, lint, format, tests) and report real output. + Never claim a change works without running them. +- Match the surrounding code's style, naming, and comment density. + ## Purpose This repository is the public messaging package system for SeamlessAuth. diff --git a/package.json b/package.json index d3a082c..7505ab0 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "packages/*" ], "engines": { - "node": ">=18" + "node": ">=24 <25" }, "scripts": { "build": "tsc -b", From cf7dc27f62cae7f2ba1854c574a69560f4ad769f Mon Sep 17 00:00:00 2001 From: Brandon Corbett Date: Wed, 8 Jul 2026 12:08:56 -0400 Subject: [PATCH 2/2] chore: running npm format --- .github/workflows/ci.yml | 2 +- .github/workflows/publish.yml | 2 +- AGENTS.md | 6 ++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f9cc155..19a16a5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" cache: npm - name: Install dependencies diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index ea9bcf1..f419da6 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -19,7 +19,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" registry-url: https://registry.npmjs.org cache: npm diff --git a/AGENTS.md b/AGENTS.md index ce0c65b..7e3807f 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -14,6 +14,7 @@ These rules apply to every repository in the fells-code org. Repo-specific guidance may extend them but must not contradict them. ### Attribution + - Commit and open PRs solely under the repository owner's identity. Never commit under an agent or assistant identity. - Never attribute work to an AI assistant: no `Co-Authored-By: Claude` (or any @@ -22,23 +23,28 @@ guidance may extend them but must not contradict them. and descriptions, changesets, code comments, or docs. ### Comments + - Comment only when the code genuinely needs explaining: a non-obvious reason, a gotcha, or an invariant. Never narrate what the code plainly does. ### TODOs + - Every `TODO`/`FIXME` must reference a ticket, e.g. `// TODO(#123): ...`. Do not leave a bare TODO. If no ticket exists, create one first. ### Commits & branches + - Conventional Commits (`feat:`, `fix:`, `chore:`, `docs:`, `ci:`, `test:`). - Descriptive branch names (`feat/...`, `fix/...`); never a `claude/` or other tool-generated prefix. ### Public-facing text + - No em dashes in commit messages, code comments, PR or issue text, changesets, or docs. Use a comma, parentheses, or a separate sentence. ### Before declaring work done + - Run the repo's checks (typecheck, lint, format, tests) and report real output. Never claim a change works without running them. - Match the surrounding code's style, naming, and comment density.