Skip to content

Commit 3687968

Browse files
committed
refactor(plugin-inspect): double-dash the assets package suffix
Separate the '--assets' companion suffix from the plugin's own name segments: @devframes/plugin-inspect-assets -> @devframes/plugin-inspect--assets. The '--' makes the auto-derived assets package visually distinct from a plugin whose name legitimately ends in a single-dash segment. Convention is now '${pkg.name}--assets'; the directory stays plugins/*/assets-pkg.
1 parent ff90e99 commit 3687968

7 files changed

Lines changed: 9 additions & 9 deletions

File tree

knip.jsonc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,15 @@
158158
},
159159
"plugins/inspect": {
160160
// The lockstep assets package is referenced only as a runtime string
161-
// (`${pkg.name}-assets` in `cli.distDir`), never imported, so knip
161+
// (`${pkg.name}--assets` in `cli.distDir`), never imported, so knip
162162
// can't see the dev-only workspace link that makes it resolvable in
163163
// the monorepo. Repeat the `plugins/*` entry glob (a workspace config
164164
// replaces, not merges, it).
165165
"entry": [
166166
"src/{index,cli,vite,constants,types}.ts",
167167
"src/{client,node,rpc,inject,engine,registry}/index.ts"
168168
],
169-
"ignoreDependencies": ["@devframes/plugin-inspect-assets"]
169+
"ignoreDependencies": ["@devframes/plugin-inspect--assets"]
170170
},
171171
"plugins/inspect/assets-pkg": {
172172
// Assets-only package: no source, just a prebuilt `dist` produced by

plugins/inspect/assets-pkg/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@devframes/plugin-inspect-assets",
2+
"name": "@devframes/plugin-inspect--assets",
33
"type": "module",
44
"version": "0.9.0-beta.4",
55
"description": "Prebuilt browser assets (SPA) for @devframes/plugin-inspect, served on demand through devframe's remote-assets back-proxy.",

plugins/inspect/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"devDependencies": {
6464
"@antfu/design": "catalog:frontend",
6565
"@devframes/hub": "workspace:*",
66-
"@devframes/plugin-inspect-assets": "workspace:*",
66+
"@devframes/plugin-inspect--assets": "workspace:*",
6767
"@iconify-json/ph": "catalog:frontend",
6868
"@standard-schema/spec": "catalog:deps",
6969
"@storybook/addon-docs": "catalog:storybook",

plugins/inspect/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import { setupInspect } from './node/index'
66
/** Default devframe id — drives the hosted mount path `/__<id>/`. */
77
const DEFAULT_ID = 'devframes_plugin_inspect'
88

9-
// The Vue SPA ships in the lockstep-versioned `@devframes/plugin-inspect-assets`
9+
// The Vue SPA ships in the lockstep-versioned `@devframes/plugin-inspect--assets`
1010
// package rather than inside this (slim) node package. `resolveFrom` lets a
1111
// locally installed copy (a workspace link in this monorepo, or an explicit
1212
// `npm install` for air-gapped setups) be served with zero network; otherwise
1313
// the assets stream on demand through devframe's caching CDN back-proxy.
1414
const distDir: RemoteAssets = {
15-
package: `${pkg.name}-assets`,
15+
package: `${pkg.name}--assets`,
1616
version: pkg.version,
1717
resolveFrom: import.meta.url,
1818
}

plugins/inspect/src/spa/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default defineConfig({
2222
// SFCs instead of esbuild pre-bundling them.
2323
optimizeDeps: { exclude: ['@antfu/design'] },
2424
build: {
25-
// Emit into the sibling `@devframes/plugin-inspect-assets` package, which
25+
// Emit into the sibling `@devframes/plugin-inspect--assets` package, which
2626
// ships these assets to npm; the node package stays slim and serves them
2727
// on demand through devframe's remote-assets back-proxy.
2828
outDir: fileURLToPath(new URL('../../assets-pkg/dist', import.meta.url)),

plugins/inspect/test/_utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { serveTestContext } from '../../../tests/helpers/serve-test-context'
2020
/**
2121
* Resolve the inspector's SPA to a local directory. Its `distDir` is a
2222
* remote-assets declaration; in this monorepo the lockstep
23-
* `@devframes/plugin-inspect-assets` package is workspace-linked, so
23+
* `@devframes/plugin-inspect--assets` package is workspace-linked, so
2424
* resolution short-circuits to its built `dist`. A store (rather than a
2525
* string) means that build hasn't run.
2626
*/

pnpm-lock.yaml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)