From 90e19dd4d387b21a7b39ee1581d3cdb9714b0320 Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 09:48:59 -0400 Subject: [PATCH 1/6] chore: enable Craft Cloud review notifications --- .github/workflows/notify-craft-cloud-review.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/workflows/notify-craft-cloud-review.yml diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml new file mode 100644 index 00000000..b00335dd --- /dev/null +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -0,0 +1,13 @@ +name: Notify Craft Cloud review requests + +on: + pull_request_target: + types: [review_requested] + +permissions: {} + +jobs: + notify: + uses: craftcms/.github/.github/workflows/notify-craft-cloud-review.yml@v3 + secrets: + slack_webhook_url: ${{ secrets.CRAFT_CLOUD_SLACK_WEBHOOK_URL }} From 749a70e4e4d8c97f6190a367aaeff3e36692e20e Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 09:54:37 -0400 Subject: [PATCH 2/6] chore: skip unrelated review requests --- .github/workflows/notify-craft-cloud-review.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml index b00335dd..4618418f 100644 --- a/.github/workflows/notify-craft-cloud-review.yml +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -8,6 +8,7 @@ permissions: {} jobs: notify: + if: github.event.requested_team.slug == 'craft-cloud' uses: craftcms/.github/.github/workflows/notify-craft-cloud-review.yml@v3 secrets: slack_webhook_url: ${{ secrets.CRAFT_CLOUD_SLACK_WEBHOOK_URL }} From 3813c79a70c3764b5a6b48b0f97b9cd812e05e4f Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 11:48:05 -0400 Subject: [PATCH 3/6] chore: centralize review request filter --- .github/workflows/notify-craft-cloud-review.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml index 4618418f..b00335dd 100644 --- a/.github/workflows/notify-craft-cloud-review.yml +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -8,7 +8,6 @@ permissions: {} jobs: notify: - if: github.event.requested_team.slug == 'craft-cloud' uses: craftcms/.github/.github/workflows/notify-craft-cloud-review.yml@v3 secrets: slack_webhook_url: ${{ secrets.CRAFT_CLOUD_SLACK_WEBHOOK_URL }} From 28f593dd079f82f5c0527f2281a44f73803cea37 Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 11:52:50 -0400 Subject: [PATCH 4/6] chore: configure Craft Cloud review filter --- .github/workflows/notify-craft-cloud-review.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml index b00335dd..a7f127be 100644 --- a/.github/workflows/notify-craft-cloud-review.yml +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -8,6 +8,7 @@ permissions: {} jobs: notify: - uses: craftcms/.github/.github/workflows/notify-craft-cloud-review.yml@v3 + if: github.event.requested_team.slug == 'craft-cloud' + uses: craftcms/.github/.github/workflows/pr-slack-notification.yml@v3 secrets: slack_webhook_url: ${{ secrets.CRAFT_CLOUD_SLACK_WEBHOOK_URL }} From bb5552fd57ab0f03dbdde137a0d7a8616d9b8197 Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 12:14:00 -0400 Subject: [PATCH 5/6] chore: align Cloud Slack secret name --- .github/workflows/notify-craft-cloud-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml index a7f127be..eaca59e7 100644 --- a/.github/workflows/notify-craft-cloud-review.yml +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -11,4 +11,4 @@ jobs: if: github.event.requested_team.slug == 'craft-cloud' uses: craftcms/.github/.github/workflows/pr-slack-notification.yml@v3 secrets: - slack_webhook_url: ${{ secrets.CRAFT_CLOUD_SLACK_WEBHOOK_URL }} + slack_webhook_url: ${{ secrets.SLACK_CLOUD_WEBHOOK_URL }} From c4a70207aac5aabecc30a124ba9a632821a4e307 Mon Sep 17 00:00:00 2001 From: Tim Kelty Date: Tue, 18 Aug 2026 13:15:46 -0400 Subject: [PATCH 6/6] fix: inherit Slack webhook secret --- .github/workflows/notify-craft-cloud-review.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/notify-craft-cloud-review.yml b/.github/workflows/notify-craft-cloud-review.yml index eaca59e7..8f8c6884 100644 --- a/.github/workflows/notify-craft-cloud-review.yml +++ b/.github/workflows/notify-craft-cloud-review.yml @@ -10,5 +10,4 @@ jobs: notify: if: github.event.requested_team.slug == 'craft-cloud' uses: craftcms/.github/.github/workflows/pr-slack-notification.yml@v3 - secrets: - slack_webhook_url: ${{ secrets.SLACK_CLOUD_WEBHOOK_URL }} + secrets: inherit