| Document Page Access Group User Role
-[document_page_approval](document_page_approval/) | 18.0.1.1.1 | | Document Page Approval
+[document_page_approval](document_page_approval/) | 18.0.1.2.0 | | Document Page Approval
[document_page_group](document_page_group/) | 18.0.1.0.0 | | Define access groups on documents
[document_page_partner](document_page_partner/) | 18.0.1.0.0 | | Allows to link doucment pages to a partner
[document_page_product](document_page_product/) | 18.0.1.0.0 | | This module links document pages to products
[document_page_project](document_page_project/) | 18.0.1.0.0 | 
| This module links document pages to projects
[document_page_project_task](document_page_project_task/) | 18.0.2.0.0 | 
| This module links document pages to project tasks
-[document_page_reference](document_page_reference/) | 18.0.2.1.2 | 
| Include references on document pages
+[document_page_reference](document_page_reference/) | 18.0.2.1.3 | | Include references on document pages
[document_page_tag](document_page_tag/) | 18.0.1.0.0 | | Allows you to assign tags or keywords to pages and search for them afterwards
[document_url](document_url/) | 18.0.1.0.1 | | URL attachment
diff --git a/attachment_preview/README.rst b/attachment_preview/README.rst
index 077eec42b44..df487bd0c4d 100644
--- a/attachment_preview/README.rst
+++ b/attachment_preview/README.rst
@@ -11,7 +11,7 @@ Preview attachments
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
- !! source digest: sha256:e9abcd982f1b988dc4c79d2c451320fddb5fc1289f44e8b7c178c917b2bd4d1e
+ !! source digest: sha256:badc7aad1a4bee3f65173d08f56b91d13166d0c26644edf8475aa249016995e1
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
diff --git a/attachment_preview/__manifest__.py b/attachment_preview/__manifest__.py
index b704f59f80d..2d982faf056 100644
--- a/attachment_preview/__manifest__.py
+++ b/attachment_preview/__manifest__.py
@@ -3,7 +3,7 @@
{
"name": "Preview attachments",
- "version": "18.0.1.0.0",
+ "version": "18.0.1.0.1",
"author": "Therp BV," "Onestein," "Odoo Community Association (OCA)",
"website": "https://github.com/OCA/knowledge",
"license": "AGPL-3",
diff --git a/attachment_preview/static/description/index.html b/attachment_preview/static/description/index.html
index 11902dea7ee..d3e04bb22d0 100644
--- a/attachment_preview/static/description/index.html
+++ b/attachment_preview/static/description/index.html
@@ -372,7 +372,7 @@ 
This addon allows to preview attachments supported by diff --git a/attachment_preview/static/src/js/attachmentPreviewWidget.esm.js b/attachment_preview/static/src/js/attachmentPreviewWidget.esm.js index 845ccc78288..0d080055d60 100644 --- a/attachment_preview/static/src/js/attachmentPreviewWidget.esm.js +++ b/attachment_preview/static/src/js/attachmentPreviewWidget.esm.js @@ -35,7 +35,7 @@ export class AttachmentPreviewWidget extends Component { _onPopoutClick() { if (!this.attachments[this.state.activeIndex]) return; - // eslint-disable-next-line no-undef + window.open(this.attachments[this.state.activeIndex].previewUrl); } diff --git a/attachment_preview/static/src/js/mail_core/attachment_list.esm.js b/attachment_preview/static/src/js/mail_core/attachment_list.esm.js index 04fa3eb6eae..6a2583311f6 100644 --- a/attachment_preview/static/src/js/mail_core/attachment_list.esm.js +++ b/attachment_preview/static/src/js/mail_core/attachment_list.esm.js @@ -4,7 +4,6 @@ import {patch} from "@web/core/utils/patch"; patch(AttachmentList.prototype, { _onPreviewAttachment(attachment) { - // eslint-disable-next-line no-undef var $target = $(event.currentTarget); var split_screen = $target.attr("data-target") !== "new"; showPreview( diff --git a/attachment_preview/static/src/js/utils.esm.js b/attachment_preview/static/src/js/utils.esm.js index 85f626a0e68..b6e3c04bc82 100644 --- a/attachment_preview/static/src/js/utils.esm.js +++ b/attachment_preview/static/src/js/utils.esm.js @@ -25,11 +25,9 @@ export function getUrl( var url = ""; if (attachment_url) { if (attachment_url.slice(0, 21) === "/web/static/lib/pdfjs") { - // eslint-disable-next-line no-undef url = (window.location.origin || "") + attachment_url; } else { url = - // eslint-disable-next-line no-undef (window.location.origin || "") + "/attachment_preview/static/lib/ViewerJS/index.html" + "?type=" + @@ -38,13 +36,11 @@ export function getUrl( encodeURIComponent(attachment_title) + "&zoom=automatic" + "#" + - // eslint-disable-next-line no-undef attachment_url.replace(window.location.origin, ""); } return url; } url = - // eslint-disable-next-line no-undef (window.location.origin || "") + "/attachment_preview/static/lib/ViewerJS/index.html" + "?type=" + @@ -74,7 +70,6 @@ export function showPreview( attachment_info_list, }); } else { - // eslint-disable-next-line no-undef window.open( getUrl( attachment_id, diff --git a/attachment_preview/static/src/js/viewerjs_tweaks.js b/attachment_preview/static/src/js/viewerjs_tweaks.js index 813eb4daca0..e5847ca8519 100644 --- a/attachment_preview/static/src/js/viewerjs_tweaks.js +++ b/attachment_preview/static/src/js/viewerjs_tweaks.js @@ -5,13 +5,12 @@ // OpenERP's context (function (original_Viewer) { "use strict"; - // eslint-disable-next-line no-undef + window.Viewer = function (plugin, parameters) { if (!plugin) { - // eslint-disable-next-line no-undef, no-alert + // eslint-disable-next-line no-alert alert("Unsupported file type"); } return original_Viewer(plugin, parameters); }; - // eslint-disable-next-line no-undef })(window.Viewer); diff --git a/checklog-odoo.cfg b/checklog-odoo.cfg index 0b55b7bf663..58d43aa6662 100644 --- a/checklog-odoo.cfg +++ b/checklog-odoo.cfg @@ -1,3 +1,5 @@ [checklog-odoo] ignore= WARNING.* 0 failed, 0 error\(s\).* + WARNING .* Killing chrome descendants-or-self .* + WARNING.* Missing widget: res_partner_many2one for field of type many2one.* diff --git a/document_page/README.rst b/document_page/README.rst index a9cef6b2d17..1541b4bc5fc 100644 --- a/document_page/README.rst +++ b/document_page/README.rst @@ -11,7 +11,7 @@ Document Page !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! source digest: sha256:98a799e3629850c2eeba7be0a3ad000746bc10955ef4a5836a6d86f67c116549 + !! source digest: sha256:657bfefae08e3e02a43481bc40dd11d1ef07f7aa53ebcf3c1dab368212f4dbf6 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png diff --git a/document_page/__manifest__.py b/document_page/__manifest__.py index 17a7f68afb0..9a2368a94e3 100644 --- a/document_page/__manifest__.py +++ b/document_page/__manifest__.py @@ -4,7 +4,7 @@ { "name": "Document Page", - "version": "18.0.2.1.1", + "version": "18.0.2.1.2", "category": "Knowledge Management", "author": "OpenERP SA, Odoo Community Association (OCA)", "images": [ diff --git a/document_page/static/description/index.html b/document_page/static/description/index.html index d56e05651ba..fe5b2faa95a 100644 --- a/document_page/static/description/index.html +++ b/document_page/static/description/index.html @@ -372,7 +372,7 @@
This module allows you to write web pages for internal documentation.
diff --git a/document_page/static/src/js/document_page_kanban_controller.esm.js b/document_page/static/src/js/document_page_kanban_controller.esm.js index 7ad18ada056..84baa01994a 100644 --- a/document_page/static/src/js/document_page_kanban_controller.esm.js +++ b/document_page/static/src/js/document_page_kanban_controller.esm.js @@ -5,7 +5,6 @@ export class DocumentPageKanbanController extends KanbanController { * @param {Object} record */ async openRecord(record) { - // eslint-disable-next-line no-undef const element = document.querySelector( `.o_kanban_record[data-id="${record.id}"] .o_document_page_kanban_boxes a` ); diff --git a/document_page_approval/README.rst b/document_page_approval/README.rst index 73db242b581..bad71157a8d 100644 --- a/document_page_approval/README.rst +++ b/document_page_approval/README.rst @@ -11,7 +11,7 @@ Document Page Approval !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! source digest: sha256:076e3494c42033cf34cf3d9a7a92ea7f0d7982d04738360bec6ff9604ee1b357 + !! source digest: sha256:347ffb497be642e1f10188011bef36f3c3352dfc195b6aed70de618c0e7c79dc !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png diff --git a/document_page_approval/__manifest__.py b/document_page_approval/__manifest__.py index 919a398d285..a05d537df8a 100644 --- a/document_page_approval/__manifest__.py +++ b/document_page_approval/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Document Page Approval", - "version": "18.0.1.1.1", + "version": "18.0.1.2.0", "author": "Savoir-faire Linux, Odoo Community Association (OCA)", "website": "https://github.com/OCA/knowledge", "license": "AGPL-3", diff --git a/document_page_approval/models/document_page.py b/document_page_approval/models/document_page.py index 1977a769999..d57cb9e3073 100644 --- a/document_page_approval/models/document_page.py +++ b/document_page_approval/models/document_page.py @@ -88,6 +88,7 @@ def _compute_approver_group_ids(self): page.approver_group_ids = res @api.depends("is_approval_required", "approver_group_ids") + @api.depends_context("uid") def _compute_am_i_approver(self): """Check if the current user can approve changes to this page.""" for rec in self: @@ -111,6 +112,7 @@ def can_user_approve_this_page(self, user): # to approve, user must belong to any of the approver groups return len(user.groups_id & self.approver_group_ids) > 0 + @api.depends_context("uid") def _compute_has_changes_pending_approval(self): history = self.env["document.page.history"] for rec in self: @@ -119,6 +121,7 @@ def _compute_has_changes_pending_approval(self): ) rec.has_changes_pending_approval = changes > 0 + @api.depends_context("uid") def _compute_user_has_drafts(self): history = self.env["document.page.history"] for rec in self: diff --git a/document_page_approval/models/document_page_history.py b/document_page_approval/models/document_page_history.py index af7558813f4..62499fe1152 100644 --- a/document_page_approval/models/document_page_history.py +++ b/document_page_approval/models/document_page_history.py @@ -2,7 +2,7 @@ # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -from odoo import fields, models +from odoo import api, fields, models from odoo.exceptions import UserError from odoo.tools.misc import clean_context from odoo.tools.translate import _ @@ -143,6 +143,7 @@ def action_cancel_and_draft(self): self.action_cancel() self.action_draft() + @api.depends_context("uid") def _compute_am_i_owner(self): """Check if current user is the owner""" for rec in self: diff --git a/document_page_approval/static/description/index.html b/document_page_approval/static/description/index.html index a6f9022073c..97d65b4bddc 100644 --- a/document_page_approval/static/description/index.html +++ b/document_page_approval/static/description/index.html @@ -372,7 +372,7 @@
This module adds a workflow to approve page modifications and show the diff --git a/document_page_approval/tests/test_document_page_approval.py b/document_page_approval/tests/test_document_page_approval.py index de41f27da76..27cac61b06c 100644 --- a/document_page_approval/tests/test_document_page_approval.py +++ b/document_page_approval/tests/test_document_page_approval.py @@ -23,6 +23,20 @@ def setUpClass(cls): login="test-user2", groups="document_page_approval.group_document_approver_user", ) + cls.user_normal = new_test_user( + cls.env, + login="test_normal", + groups="document_knowledge.group_document_user,document_page.group_document_editor", + name="Test Normal User", + email="normal@example.com", + ) + cls.manager_user = new_test_user( + cls.env, + login="test_manager", + groups="document_page.group_document_manager", + name="Test Manager", + email="manager@example.com", + ) # Ensure user2 has the approver group cls.approver_gid = cls.env.ref( @@ -267,3 +281,64 @@ def test_diff_computation(self): ) chreq2._compute_diff() self.assertIsNotNone(chreq2.diff) + + def test_cache_am_i_approver(self): + """Ensure 'am_i_approver' is computed per-user and not cached globally.""" + page = self.page2 + + # Normal user evaluates the field first (Calculates and caches: False) + self.assertFalse(page.with_user(self.user_normal).am_i_approver) + + # Approver user evaluates it next. + self.assertTrue(page.with_user(self.user2).am_i_approver) + + def test_cache_am_i_owner(self): + """Ensure 'am_i_owner' is computed per-user and not cached globally.""" + page = self.page2 + # Normal user creates the change request (they are the owner) + chreq = self.history_obj.with_user(self.user_normal).create( + { + "page_id": page.id, + "summary": "Cache Test", + "content": "
User Normal Changes
", + } + ) + + # Approver user evaluates the field first (Calculates and caches: False) + self.assertFalse(chreq.with_user(self.user2).am_i_owner) + + # Normal user evaluates it next + self.assertTrue(chreq.with_user(self.user_normal).am_i_owner) + + def test_cache_user_has_drafts(self): + """Ensure 'user_has_drafts' is computed per-user and not cached globally.""" + page = self.page2 + # Normal user creates a draft change request + self.history_obj.with_user(self.user_normal).create( + { + "page_id": page.id, + "state": "draft", + } + ) + + # Approver evaluates the field first + self.assertFalse(page.with_user(self.user2).user_has_drafts) + + # Normal user evaluates it next + self.assertTrue(page.with_user(self.user_normal).user_has_drafts) + + def test_cache_has_changes_pending_approval(self): + """Ensure 'has_changes_pending_approval' is computed per-user and not cached.""" + page = self.page2 + # Create a pending approval change request using the Manager + # so it's NOT owned by the normal user. + chreq = self.history_obj.with_user(self.manager_user).create( + {"page_id": page.id, "content": "Manager Change
"} + ) + chreq.with_user(self.manager_user).action_to_approve() + + # Normal user evaluates the field. + self.assertFalse(page.with_user(self.user_normal).has_changes_pending_approval) + + # Approver user evaluates it. + self.assertTrue(page.with_user(self.user2).has_changes_pending_approval) diff --git a/document_page_reference/README.rst b/document_page_reference/README.rst index 093801cf514..39071b1c8bb 100644 --- a/document_page_reference/README.rst +++ b/document_page_reference/README.rst @@ -11,7 +11,7 @@ Document Page Reference !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! source digest: sha256:99f7203545e099cb72ee70d72c03ea7075435ff2f7e0da356769e877104c62a8 + !! source digest: sha256:7ae4eea4b6e7501b923f3597e005c064c4b58658b2913d8c3bfd25b1a7f9494c !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png diff --git a/document_page_reference/__manifest__.py b/document_page_reference/__manifest__.py index cd14e0a7677..7c370726841 100644 --- a/document_page_reference/__manifest__.py +++ b/document_page_reference/__manifest__.py @@ -5,7 +5,7 @@ "name": "Document Page Reference", "summary": """ Include references on document pages""", - "version": "18.0.2.1.2", + "version": "18.0.2.1.3", "license": "AGPL-3", "author": "Creu Blanca,Odoo Community Association (OCA)", "website": "https://github.com/OCA/knowledge", diff --git a/document_page_reference/static/description/index.html b/document_page_reference/static/description/index.html index 4e7d834ee04..adf3bc02c3d 100644 --- a/document_page_reference/static/description/index.html +++ b/document_page_reference/static/description/index.html @@ -372,7 +372,7 @@
This module allows to add a reference name on documents and simplifies diff --git a/document_page_reference/static/src/js/editor.esm.js b/document_page_reference/static/src/js/editor.esm.js index 416bfb851f4..0bbfa7bbdbb 100644 --- a/document_page_reference/static/src/js/editor.esm.js +++ b/document_page_reference/static/src/js/editor.esm.js @@ -9,7 +9,6 @@ class DocumentPageReferenceField extends HtmlField { this.orm = useService("orm"); this.action = useService("action"); onMounted(() => { - // eslint-disable-next-line no-undef const links = document.querySelectorAll(".oe_direct_line"); links.forEach((link) => { link.addEventListener("click", (event) => diff --git a/eslint.config.cjs b/eslint.config.cjs index 0d5731f89a8..dd0cbe0aef0 100644 --- a/eslint.config.cjs +++ b/eslint.config.cjs @@ -1,3 +1,4 @@ +var globals = require('globals'); jsdoc = require("eslint-plugin-jsdoc"); const config = [{ @@ -16,6 +17,8 @@ const config = [{ openerp: "readonly", owl: "readonly", luxon: "readonly", + QUnit: "readonly", + ...globals.browser, }, ecmaVersion: 2024, @@ -191,7 +194,7 @@ const config = [{ }, }, { - files: ["**/*.esm.js"], + files: ["**/*.esm.js", "**/*test.js"], languageOptions: { ecmaVersion: 2024,