Incorrect degrees symbol in example/demo.cpp

[jwakely]

serialization/example/demo.cpp

Line 66 in 097a6c6

return os << ' ' << gp.degrees << (unsigned char)186 << gp.minutes << '\'' << gp.seconds << '"';

This prints (unsigned char)186 to the output file, which in ISO-8859-1 is the same character as Unicode character U+00BA "Masculine Ordinal Indicator", as in 1º meaning primero in Spanish.

I think the character you intended to use is U+00B0 "Degree sign", which for ISO-8859-1 is encoded as a single character with the decimal value 176, not 186.

Maybe it would make sense to use "\u00B0" for that character, which is valid since C++11. However, the encoding used for that character would depend on compiler flags (GCC and Clang default to UTF8 for the ordinary literal encoding, MSVC ... probably doesn't), so the character written to demo_output.txt would also depend on those flags and so would not be portable.

Using (unsigned char)176) would be portable, and would at least be the correct symbol when the output is treated as ISO-8859-1.

[jwakely]

I'll gladly provide a patch to change the source to write out "\u00B0" and then convert the demo_output.txt to contain the UTF-8 encoding of the U+00B0 character, if that's acceptable. I think it would mean demo.cpp would need to be compiled with special flags for MSVC though.

[jwakely]

Hmm, maybe that's a bad idea, because the demo_output.txt already seems to be MSVC-specific. With libstdc++ and libc++ writing a pointer to an ostream already includes the "0x" prefix, so demo.cpp produces lines like this:

0x0x1876d0e0  35º136'15.456" 133º32'15.3" White House

Note the 0x0x prefix. And the º ordinal indicator which should be ° instead.

So if the output only really matches when using MSVC, assuming UTF-8 for the literal encoding might be a bad idea.

(The output will never match perfectly of course, because the pointer values change each run.)

Still, changing it to use (unsigned char)176 would be an improvement.

[jwakely]

P.S. the std::hex seems redundant here:

serialization/example/demo.cpp

Line 205 in 097a6c6

os << '\n' << std::hex << "0x" << *it << std::dec << ' ' << **it;

Don't all compilers print pointers in hexadecimal notation?