Add Basicrum admin menu icon

Author: Tsvetan Stoychev

plugins/basicrum/assets/images/basicrum-menu-icon.svg

@@ -117,11 +117,38 @@ public function add_menu_page() {
 			'manage_options',
 			self::SLUG,
 			array( $this, 'render_settings_page' ),
-			'dashicons-analytics',
+			$this->get_menu_icon(),
 			null
 		);
 	}
 
+	/**
+	 * Get the monochrome Basicrum mark for the WordPress admin menu.
+	 *
+	 * WordPress recolors base64-encoded SVG menu icons to match the active admin
+	 * color scheme. Fall back to the analytics Dashicon if the packaged SVG
+	 * cannot be read.
+	 *
+	 * @return string SVG data URI or Dashicon class.
+	 */
+	private function get_menu_icon() {
+		$icon_path = Helpers::get_asset_path( 'images/basicrum-menu-icon.svg' );
+
+		if ( ! is_readable( $icon_path ) ) {
+			return 'dashicons-analytics';
+		}
+
+		// phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents -- Reading a trusted packaged SVG.
+		$svg = file_get_contents( $icon_path );
+
+		if ( false === $svg || '' === trim( $svg ) ) {
+			return 'dashicons-analytics';
+		}
+
+		// phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.obfuscation_base64_encode -- Required for a WordPress SVG menu icon data URI.
+		return 'data:image/svg+xml;base64,' . base64_encode( $svg );
+	}
+
 	/**
 	 * Register all settings, sections, and fields.
 	 *

plugins/basicrum/src/Admin/Settings/Page.php

@@ -76,6 +76,34 @@ function( $path ) {
 		$this->assertStringContainsString( 'height="48"', $html );
 	}
 
+	/**
+	 * Test the top-level menu uses the packaged monochrome Basicrum mark.
+	 */
+	public function test_admin_menu_uses_packaged_brand_icon() {
+		$menu_arguments = null;
+
+		Functions\when( 'add_menu_page' )->alias(
+			function() use ( &$menu_arguments ) {
+				$menu_arguments = func_get_args();
+			}
+		);
+
+		$page = new Page();
+		$page->add_menu_page();
+
+		$this->assertIsArray( $menu_arguments );
+		$this->assertArrayHasKey( 5, $menu_arguments );
+		$this->assertStringStartsWith( 'data:image/svg+xml;base64,', $menu_arguments[5] );
+
+		$encoded_svg = substr( $menu_arguments[5], strlen( 'data:image/svg+xml;base64,' ) );
+		$svg         = base64_decode( $encoded_svg, true );
+
+		$this->assertIsString( $svg );
+		$this->assertStringContainsString( 'viewBox="0 0 24 24"', $svg );
+		$this->assertStringContainsString( 'style="fill:#a7aaad"', $svg );
+		$this->assertStringContainsString( 'M0 4h4v16H0z', $svg );
+	}
+
 	/**
 	 * Set up WordPress function stubs.
 	 */

plugins/basicrum/tests/unit/SettingsPageTest.php

@@ -52,6 +52,7 @@ require_entry 'basicrum/assets/js/integrations/cookieyes.js'
 require_entry 'basicrum/assets/js/integrations/generic-opt-in.js'
 require_entry 'basicrum/assets/js/integrations/generic-opt-out.js'
 require_entry 'basicrum/assets/images/basicrum-logo.png'
+require_entry 'basicrum/assets/images/basicrum-menu-icon.svg'
 require_entry 'basicrum/languages/basicrum.pot'
 
 if printf '%s\n' "$ARCHIVE_ENTRIES" | grep -Fqx 'basicrum/assets/js/loaders/consent-api.js'; then