Use ASCII hyphens consistently

Author: Tsvetan Stoychev

AGENTS.md

@@ -21,6 +21,8 @@ namespace, PSR-4 Composer autoloading, PHP 7.4+, and WordPress 6.0+.
 
 - Follow WordPress-Core/WPCS. The text domain is `basicrum`.
 - Guard PHP files with `ABSPATH`; escape output and sanitize all input.
+- Use ASCII hyphens (`-`); do not use typographic dashes in source, comments,
+  documentation, or user-facing text.
 - Prefix hooks with `basicrum_`; use `Assets` handle constants rather than
   hard-coded script handles.
 - Boomerang lives in `assets/js/boomr/`; standard and consent loaders live in

README.md

@@ -4,11 +4,11 @@ This repository now uses a small monorepo-style layout.
 
 ## Layout
 
-- `plugins/basicrum/` — the installable WordPress plugin package
-- `docker/` — Dockerfiles for local development tooling
-- `tools/` — helper scripts for local development and testing
-- `plan-refs/` — planning notes and ADRs
-- `plugin-references/` — external reference implementations kept for study
+- `plugins/basicrum/` - the installable WordPress plugin package
+- `docker/` - Dockerfiles for local development tooling
+- `tools/` - helper scripts for local development and testing
+- `plan-refs/` - planning notes and ADRs
+- `plugin-references/` - external reference implementations kept for study
 
 ## Common Commands
 

plugins/basicrum/readme.txt

@@ -16,13 +16,13 @@ Basicrum is a free, open source Real User Monitoring (RUM) system. This plugin i
 
 **Features:**
 
-* **Real User Monitoring** — Collect page load timing, resource timing, and continuity metrics from actual visitors.
-* **Page Type Detection** — Automatically tags beacons with the WordPress page type (home, post, page, category, archive, search, 404) and WooCommerce types (product, cart, checkout).
-* **Site ID** — UUID v4 identifier to distinguish multiple sites reporting to the same beacon endpoint.
-* **GDPR Consent Mode** — Conditional loading with JavaScript API (`OPT_IN_BASIC_RUM()` / `OPT_OUT_BASIC_RUM()`) for consent banner integration.
-* **3-Tier Script Loading** — Preload → iframe → direct script loading strategy for optimal performance.
-* **Configurable Beacon Delay** — Wait after onload before sending the beacon for more complete data collection.
-* **Cache Plugin Compatibility** — Automatically excluded from optimization by WP Rocket, Autoptimize, LiteSpeed Cache, SG Optimizer, W3 Total Cache, and WP Optimize.
+* **Real User Monitoring** - Collect page load timing, resource timing, and continuity metrics from actual visitors.
+* **Page Type Detection** - Automatically tags beacons with the WordPress page type (home, post, page, category, archive, search, 404) and WooCommerce types (product, cart, checkout).
+* **Site ID** - UUID v4 identifier to distinguish multiple sites reporting to the same beacon endpoint.
+* **GDPR Consent Mode** - Conditional loading with JavaScript API (`OPT_IN_BASIC_RUM()` / `OPT_OUT_BASIC_RUM()`) for consent banner integration.
+* **3-Tier Script Loading** - Preload → iframe → direct script loading strategy for optimal performance.
+* **Configurable Beacon Delay** - Wait after onload before sending the beacon for more complete data collection.
+* **Cache Plugin Compatibility** - Automatically excluded from optimization by WP Rocket, Autoptimize, LiteSpeed Cache, SG Optimizer, W3 Total Cache, and WP Optimize.
 
 **How it works:**
 
@@ -65,9 +65,9 @@ Yes. When WooCommerce is active, the plugin automatically detects shop, product,
 
 == Screenshots ==
 
-1. Admin settings page — General settings with beacon URL and Site ID.
-2. Privacy settings — Consent mode configuration with JS API documentation.
-3. Developer settings — Script position and debug options.
+1. Admin settings page - General settings with beacon URL and Site ID.
+2. Privacy settings - Consent mode configuration with JS API documentation.
+3. Developer settings - Script position and debug options.
 
 == Changelog ==
 

plugins/basicrum/src/Admin/Settings/Page.php

@@ -14,7 +14,7 @@
 }
 
 /**
- * Page class — registers the admin menu, settings sections, and fields.
+ * Page class - registers the admin menu, settings sections, and fields.
  */
 class Page {
 
@@ -33,7 +33,7 @@ class Page {
 	const SLUG = 'basicrum';
 
 	/**
-	 * Constructor — hook into admin_menu and admin_init.
+	 * Constructor - hook into admin_menu and admin_init.
 	 */
 	public function __construct() {
 		add_action( 'admin_menu', array( $this, 'add_menu_page' ) );
@@ -482,8 +482,8 @@ public function render_consent_info() {
 		<div class="basicrum-consent-info" style="background: #f0f0f1; padding: 12px 16px; border-left: 4px solid #2271b1; margin: 8px 0;">
 			<p><strong><?php esc_html_e( 'Consent JavaScript API', 'basicrum' ); ?></strong></p>
 			<p><?php esc_html_e( 'When consent mode is enabled, Boomerang will not load until the user gives consent. Use the following JavaScript API in your consent banner or cookie notice:', 'basicrum' ); ?></p>
-			<p><code>window.OPT_IN_BASIC_RUM()</code> — <?php esc_html_e( 'Call this to grant consent and start monitoring. Sets a BRUM_CONSENT cookie (1 year, Strict, Secure).', 'basicrum' ); ?></p>
-			<p><code>window.OPT_OUT_BASIC_RUM()</code> — <?php esc_html_e( 'Call this to revoke consent. Disables Boomerang and removes tracking cookies.', 'basicrum' ); ?></p>
+			<p><code>window.OPT_IN_BASIC_RUM()</code> - <?php esc_html_e( 'Call this to grant consent and start monitoring. Sets a BRUM_CONSENT cookie (1 year, Strict, Secure).', 'basicrum' ); ?></p>
+			<p><code>window.OPT_OUT_BASIC_RUM()</code> - <?php esc_html_e( 'Call this to revoke consent. Disables Boomerang and removes tracking cookies.', 'basicrum' ); ?></p>
 			<p><strong><?php esc_html_e( 'Example:', 'basicrum' ); ?></strong></p>
 			<pre style="background: #fff; padding: 8px; border: 1px solid #ddd;">&lt;button onclick="OPT_IN_BASIC_RUM()"&gt;Accept&lt;/button&gt;
 &lt;button onclick="OPT_OUT_BASIC_RUM()"&gt;Decline&lt;/button&gt;</pre>

plugins/basicrum/src/Admin/Settings/Validate.php

@@ -14,7 +14,7 @@
 }
 
 /**
- * Validate class — sanitize callback for register_setting().
+ * Validate class - sanitize callback for register_setting().
  *
  * UUID v4 regex ported from basicrum-magento-1 SiteId.php backend model.
  */
@@ -119,7 +119,7 @@ private function sanitize_beacon_url( $input, $defaults ) {
 
 		$url = esc_url_raw( $input['beacon_url'], array( 'https', 'http' ) );
 
-		// Enforce HTTPS — upgrade HTTP to HTTPS.
+		// Enforce HTTPS - upgrade HTTP to HTTPS.
 		if ( 0 === strpos( $url, 'http://' ) ) {
 			$url = 'https://' . substr( $url, 7 );
 

plugins/basicrum/src/Admin/Upgrades.php

@@ -14,14 +14,14 @@
 }
 
 /**
- * Upgrades class — runs sequential migrations when plugin version changes.
+ * Upgrades class - runs sequential migrations when plugin version changes.
  *
  * Pattern from wordpress-plausible/src/Admin/Upgrades.php.
  */
 class Upgrades {
 
 	/**
-	 * Constructor — hook into init to check for pending upgrades.
+	 * Constructor - hook into init to check for pending upgrades.
 	 */
 	public function __construct() {
 		add_action( 'init', array( $this, 'maybe_upgrade' ), 5 );

plugins/basicrum/src/Assets.php

@@ -12,7 +12,7 @@
 }
 
 /**
- * Assets class — enqueues the Boomerang library and inline configuration
+ * Assets class - enqueues the Boomerang library and inline configuration
  * on the frontend using proper WordPress script APIs.
  *
  * Replaces the raw heredoc injection from the PoC's core-functions.php.
@@ -34,7 +34,7 @@ class Assets {
 	const HANDLE_CONFIG = 'basicrum-config';
 
 	/**
-	 * Constructor — register the enqueue hook.
+	 * Constructor - register the enqueue hook.
 	 */
 	public function __construct() {
 		add_action( 'wp_enqueue_scripts', array( $this, 'maybe_enqueue' ), 1 );

plugins/basicrum/src/Compatibility.php

@@ -12,15 +12,15 @@
 }
 
 /**
- * Compatibility class — excludes Basicrum scripts from optimization by
+ * Compatibility class - excludes Basicrum scripts from optimization by
  * popular caching and performance plugins.
  *
  * Modeled after wordpress-plausible/src/Compatibility.php
  */
 class Compatibility {
 
 	/**
-	 * Constructor — register exclusion filters.
+	 * Constructor - register exclusion filters.
 	 */
 	public function __construct() {
 		$this->init();

plugins/basicrum/src/Helpers.php

@@ -12,7 +12,7 @@
 }
 
 /**
- * Helpers class — settings retrieval and utility methods.
+ * Helpers class - settings retrieval and utility methods.
  */
 class Helpers {
 

plugins/basicrum/src/PageTypeDetector.php

@@ -12,7 +12,7 @@
 }
 
 /**
- * PageTypeDetector class — maps WordPress conditional tags to
+ * PageTypeDetector class - maps WordPress conditional tags to
  * human-readable page type labels sent as `p_type` in Boomerang beacons.
  *
  * Reference: basicrum-magento-1 PageTypeDetector.php (27 page types)
@@ -95,7 +95,7 @@ private function detect_woocommerce_page_type() {
 	/**
 	 * Detect standard WordPress page types.
 	 *
-	 * Checked in specificity order — most specific first.
+	 * Checked in specificity order - most specific first.
 	 *
 	 * @return string|null Page type or null if undetectable.
 	 */