From b6c5e4ea18f2e579de770b79fc83ab557f6ce0c6 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Wed, 19 Aug 2026 19:33:35 +0000 Subject: [PATCH] Add tests for @{baseVersion}@ and DEFAULT_FILE_NAME_MAPPING constants Both DEFAULT_FILE_NAME_MAPPING and DEFAULT_FILE_NAME_MAPPING_CLASSIFIER use @{baseVersion}@ but no test ever exercised this expression or these constants. Add four tests: - baseVersionMapping: directly tests @{baseVersion}@ in an expression - defaultFileNameMapping: tests DEFAULT_FILE_NAME_MAPPING constant - defaultFileNameMappingClassifier: tests DEFAULT_FILE_NAME_MAPPING_CLASSIFIER with a classifier - defaultFileNameMappingNullClassifier: tests DEFAULT_FILE_NAME_MAPPING_CLASSIFIER without a classifier Closes #64 --- .../shared/mapping/MappingUtilsTest.java | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/src/test/java/org/apache/maven/shared/mapping/MappingUtilsTest.java b/src/test/java/org/apache/maven/shared/mapping/MappingUtilsTest.java index 3b080cf..a0fd819 100644 --- a/src/test/java/org/apache/maven/shared/mapping/MappingUtilsTest.java +++ b/src/test/java/org/apache/maven/shared/mapping/MappingUtilsTest.java @@ -117,4 +117,46 @@ void mappingWithOptionalClassifier() throws Exception { "maven-test-lib-1.0-classifier.jar", MappingUtils.evaluateFileNameMapping(mappingWithOptionalClassifier2, jar)); } + + @Test + void baseVersionMapping() throws Exception { + Artifact jar = new DefaultArtifact( + "org.apache.sample", "maven-test-lib", "1.0", null, "jar", null, new DefaultArtifactHandler("jar")); + assertEquals( + "maven-test-lib-1.0.jar", + MappingUtils.evaluateFileNameMapping("@{artifactId}@-@{baseVersion}@.@{extension}@", jar)); + } + + @Test + void defaultFileNameMapping() throws Exception { + Artifact jar = new DefaultArtifact( + "org.apache.sample", "maven-test-lib", "1.0", null, "jar", null, new DefaultArtifactHandler("jar")); + assertEquals( + "maven-test-lib-1.0.jar", + MappingUtils.evaluateFileNameMapping(MappingUtils.DEFAULT_FILE_NAME_MAPPING, jar)); + } + + @Test + void defaultFileNameMappingClassifier() throws Exception { + Artifact jar = new DefaultArtifact( + "org.apache.sample", + "maven-test-lib", + "1.0", + null, + "jar", + "classifier", + new DefaultArtifactHandler("jar")); + assertEquals( + "maven-test-lib-1.0-classifier.jar", + MappingUtils.evaluateFileNameMapping(MappingUtils.DEFAULT_FILE_NAME_MAPPING_CLASSIFIER, jar)); + } + + @Test + void defaultFileNameMappingNullClassifier() throws Exception { + Artifact jar = new DefaultArtifact( + "org.apache.sample", "maven-test-lib", "1.0", null, "jar", null, new DefaultArtifactHandler("jar")); + assertEquals( + "maven-test-lib-1.0-.jar", + MappingUtils.evaluateFileNameMapping(MappingUtils.DEFAULT_FILE_NAME_MAPPING_CLASSIFIER, jar)); + } }