From 9d85b0d63e2b31a87f20ed3fed5d3b1be18604b1 Mon Sep 17 00:00:00 2001 From: Minh Vu Date: Sat, 25 Jul 2026 17:15:49 +0200 Subject: [PATCH] fix: compare all snapshot fields --- src/iceberg/snapshot.cc | 1 + src/iceberg/test/snapshot_test.cc | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/iceberg/snapshot.cc b/src/iceberg/snapshot.cc index 421d7439b..0cefa55a8 100644 --- a/src/iceberg/snapshot.cc +++ b/src/iceberg/snapshot.cc @@ -172,6 +172,7 @@ bool Snapshot::Equals(const Snapshot& other) const { return snapshot_id == other.snapshot_id && parent_snapshot_id == other.parent_snapshot_id && sequence_number == other.sequence_number && timestamp_ms == other.timestamp_ms && + manifest_list == other.manifest_list && summary == other.summary && schema_id == other.schema_id && first_row_id == other.first_row_id && added_rows == other.added_rows; } diff --git a/src/iceberg/test/snapshot_test.cc b/src/iceberg/test/snapshot_test.cc index 2be6a1986..090caf3c5 100644 --- a/src/iceberg/test/snapshot_test.cc +++ b/src/iceberg/test/snapshot_test.cc @@ -116,8 +116,16 @@ TEST_F(SnapshotTest, EqualityComparison) { Snapshot snapshot3(67890, {}, 1, TimePointMsFromUnixMs(1615569200000), "s3://example/manifest_list.avro", summary3, {}); + Snapshot snapshot4(12345, {}, 1, TimePointMsFromUnixMs(1615569200000), + "s3://example/other_manifest_list.avro", summary1, {}); + + Snapshot snapshot5(12345, {}, 1, TimePointMsFromUnixMs(1615569200000), + "s3://example/manifest_list.avro", summary3, {}); + EXPECT_EQ(snapshot1, snapshot2); EXPECT_NE(snapshot1, snapshot3); + EXPECT_NE(snapshot1, snapshot4); + EXPECT_NE(snapshot1, snapshot5); } } // namespace iceberg