diff --git a/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md b/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md index d9efb1741..55f4a69ec 100644 --- a/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md +++ b/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md @@ -93,7 +93,7 @@ OWNER override wording: `OWNER override approved: ` OWNER follows the same safety rules: -- One active OWNER branch at a time. +- One active Team OWNER branch at a time. - One active OWNER assignment at a time. - OWNER may override team locks, but may not silently delete, rewrite, or remove protected instructions. - OWNER override must be explicitly documented. diff --git a/docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md b/docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md index 61b95cfae..6f797306d 100644 --- a/docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md +++ b/docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md @@ -9,11 +9,12 @@ Keep active work attached to the correct assigned team, branch, and OWNER decisi ## Active Work Lock -- Work must occur on the assigned team or OWNER branch. +- Work must occur on the active team branch. +- This rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. - An assigned work item keeps its owner of record until complete or OWNER reassignment. - Work must not move to another team, branch, or PR without OWNER approval. - A team with no active assignment, active branch, or active PR is inactive. -- A team with a previous PR that is not Closed must not begin another PR unless OWNER documented an explicit stacked PR chain. +- A team with a previous PR that is not Closed must not begin another unrelated PR unless OWNER documented an explicit stacked/sequential workstream. - PR Open begins only after the branch and PR identity are named. - Plan, Build, validation, reports, ZIP packaging, and closeout stay tied to the same PR identity and source branch. - Closed ends only after the final main-return, clean-worktree, local/origin `0/0`, no-untracked-files, required-report, required-ZIP, backlog, applicable tool-state, and branch-disposition gates pass. @@ -25,7 +26,8 @@ Keep active work attached to the correct assigned team, branch, and OWNER decisi - Pull latest `origin/main` before creating a work branch. - Do not create a PR branch unless current branch is `main`, worktree is clean, `main...origin/main` is `0 0`, and `HEAD` SHA matches the published EOD SHA. - Follow the canonical START / WORK / END lifecycle in `docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md`. -- Keep work on the active branch until the PR is merged, the branch is retired, or OWNER says to return to `main`. +- Keep work on the active branch until the PR is merged, the branch is retired, EOD closeout begins, or OWNER says to return to `main`. +- For OWNER-approved stacked/sequential workstreams, PR branches/commits stay on the active team branch/workstream during the day and do not return to `main` between PRs. - Do not commit directly to `main`. - HARD STOP before committing if current branch is `main`. - HARD STOP if the branch changes unexpectedly during implementation. @@ -51,7 +53,7 @@ Branch lock governance enforces: - START on synchronized `main`. - WORK only on the PR branch. - END by merging, returning to synchronized `main`, publishing branch, HEAD SHA, and date/time, then stopping all work. -- Mandatory hard stops before commits on `main`, dirty branch creation, non-`0 0` main sync, baseline SHA mismatch, unvalidated merge, or new PR work before synchronized main return. +- Mandatory hard stops before commits on `main`, dirty branch creation, non-`0 0` main sync, baseline SHA mismatch, unvalidated merge, or new unrelated workstream before synchronized main return. ## OWNER Override diff --git a/docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md b/docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md index 7bf38c1f8..1c3671363 100644 --- a/docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md +++ b/docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md @@ -37,7 +37,7 @@ Codex responses must include: ## Tool MVP PR Report Requirements Every tool MVP PR report must include: -- Creator-testable outcome +- Product Owner testable outcome - What Playwright tests - What Mr. Q should manually test - Whether the PR is part of a stacked MVP sequence @@ -50,7 +50,7 @@ The report must answer: What can Mr. Q test after applying this ZIP? ``` -If a tool MVP PR has no Playwright lane, the report must state why and list the manual Creator validation instead. +If a tool MVP PR has no Playwright lane, the report must state why and list the manual Product Owner validation instead. ## Code Change Reporting diff --git a/docs_build/dev/ProjectInstructions/addendums/environment_configuration_standards.md b/docs_build/dev/ProjectInstructions/addendums/environment_configuration_standards.md index d08f4317b..5a91f904c 100644 --- a/docs_build/dev/ProjectInstructions/addendums/environment_configuration_standards.md +++ b/docs_build/dev/ProjectInstructions/addendums/environment_configuration_standards.md @@ -92,6 +92,8 @@ One shared API/service contract is required across Local (VS Code), DEV, IST, UA Rules: +- Browser/UI/runtime code must follow `Browser -> API -> Database` for authoritative product data. +- `Local API` means the same shared API/service contract running locally, not a separate local-only API implementation. - API URLs may differ by `.env` only. - Do not split Local API and Public API contracts. - Do not create environment-specific API/service contracts. diff --git a/docs_build/dev/ProjectInstructions/addendums/environment_governance_model.md b/docs_build/dev/ProjectInstructions/addendums/environment_governance_model.md index de7c90331..0196571a0 100644 --- a/docs_build/dev/ProjectInstructions/addendums/environment_governance_model.md +++ b/docs_build/dev/ProjectInstructions/addendums/environment_governance_model.md @@ -48,7 +48,9 @@ One shared API/service contract is required across all environments. Rules: +- Browser/UI/runtime product data must flow through `Browser -> API -> Database`. - Browser/UI/runtime code must consume the same API/service contract in Local (VS Code), DEV, IST, UAT, and PROD. +- `Local API` means the shared API/service contract running locally, not a separate API implementation. - Environment-specific endpoints, keys, buckets, credentials, and prefixes are configuration values only. - Do not create environment-specific API/service contracts. - Do not branch API/service behavior by environment name. diff --git a/docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md b/docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md index 2df16f830..c859e78e5 100644 --- a/docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md +++ b/docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md @@ -11,10 +11,16 @@ Browser → API → Database Runtime product data must flow through the API/service contract backed by the database. +Canonical ASCII wording for this required flow is: + +```text +Browser -> API -> Database +``` + ## Rules - Mock repositories are 100% technical debt. -- "Mock repository ready" is not a valid Creator-testable completion state. +- "Mock repository ready" is not a valid Product Owner testable completion state. - Page arrays are not product-data sources of truth. - JSON source files are not product-data sources of truth. - `/tmp` files are not product-data sources of truth. @@ -32,7 +38,7 @@ If a temporary mock repository exists for transition, it must be documented as t - affected files - removal PR - replacement API/DB path -- Creator-testable limitation +- Product Owner testable limitation Temporary mock repositories do not make a feature complete. They may only document a transition state. @@ -46,4 +52,4 @@ Completion requires Game Configuration data to load through: Browser → API → Database ``` -The Creator-testable completion state must prove that browser-visible Game Configuration data was read back through the API/service contract backed by the database. +The Product Owner testable completion state must prove that browser-visible Game Configuration data was read back through the API/service contract backed by the database. diff --git a/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md b/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md index 278717326..145d08536 100644 --- a/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md +++ b/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md @@ -23,9 +23,27 @@ Define the standard pull request workflow for Game Foundry Studio. 12. Review the PR. 13. OWNER approves merge. 14. Merge to main. -15. Pull latest main before starting the next PR. +15. Pull latest main before starting the next unrelated workstream, or before a new PR when the work is not an OWNER-approved stacked/sequential workstream. 16. Verify Main Verified and Closed gates. +## Daily Branch Workflow + +Team-neutral daily workflow: + +- SOD starts from the latest synchronized `main`. +- SOD creates or updates one active team branch/workstream. +- Work must be committed only to the active team branch. +- PR branches/commits stay on the active team branch/workstream during the day when OWNER assigned a stacked or sequential workstream. +- Do not return to `main` between stacked/sequential PRs in the same active workstream. +- `main` is only the SOD baseline and the EOD return target, unless OWNER explicitly approves an intermediate merge checkpoint. +- EOD merges or closes OWNER-approved work, pushes, returns to `main`, and verifies: + - current branch is `main` + - worktree clean + - local/origin sync is `0 0` +- This rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. + +This section supersedes older active wording that implies returning to `main` between every PR inside an OWNER-approved stacked/sequential workstream. + ## Branch Lifecycle (Canonical) Every PR follows exactly three phases: @@ -101,7 +119,8 @@ Closed gates: - Source branches are retained by default after merge and closeout. - Do not mix unrelated scopes. - Do not start dependent PRs until the required base PR is merged. -- Always return to main before starting the next PR. +- Return to `main` before starting an unrelated PR or new workstream. +- Do not return to `main` between PRs in the same OWNER-approved stacked/sequential workstream unless OWNER approves an EOD or intermediate merge checkpoint. - A team must not begin another PR if its previous PR is not Closed. - Exception is allowed only for explicitly documented stacked PR chains. - If validation fails, stop and report. @@ -124,14 +143,14 @@ Tool MVP work must follow: `docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md` -For tool MVPs, use one large Codex command, multiple focused stacked PRs, and one testable Creator outcome per PR. +For tool MVPs, use one large Codex command, multiple focused stacked PRs, and one Product Owner testable outcome per PR. Do not create one giant PR. Do not stop after every small PR unless blocked by branch state, failed validation, missing source files, Project Instructions conflict, or an unresolved dependency from a prior PR. Each tool MVP PR plan or template must include: -- Creator-testable outcome +- Product Owner testable outcome - What Playwright tests - What Mr. Q should manually test - Whether the PR is part of a stacked MVP sequence @@ -140,6 +159,47 @@ Each tool MVP PR plan or template must include: Visible acceptance must be Creator-facing first. Architecture can be handled under the covers, but the PR purpose must be user-testable. +## Product Owner Testable Definition + +A request to complete a page, tool, MVP, or testable experience means Product Owner testable by default. Codex must deliver a working Product Owner testable feature, not a shell or foundation page, unless the Product Owner explicitly requests a shell/foundation PR. + +A Product Owner testable outcome means the Product Owner can: + +- open the page/tool +- perform the primary workflow +- save/load data where applicable +- observe expected results +- validate success and failure states +- follow manual validation steps from the PR report + +Not acceptable as a completed/testable page or tool: + +- shell-only page +- route-only page +- navigation-only PR +- template-only page +- placeholder controls +- static table with no workflow +- `Not implemented yet` +- `coming soon` +- placeholder-only workspace, inspector, or output sections +- planned-only tile +- route that loads but cannot be used + +Required for Product Owner testable completion: + +- visible working controls +- API-backed data where required +- validation and error states +- empty states +- save/load behavior where applicable +- manual validation steps for Product Owner +- targeted Playwright coverage where impacted. + +## No-Shell Completion Rule + +A PR requested to complete a page, tool, MVP, or testable experience must not stop after route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless the Product Owner explicitly requested a shell/foundation PR. + ## OWNER Shortcut: PRs Keyword: diff --git a/docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md b/docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md index ff606135a..114b3b39f 100644 --- a/docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md +++ b/docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md @@ -68,7 +68,7 @@ END ## START -Every team begins on `main`. +Every team begins SOD from `main`. Required: @@ -91,7 +91,7 @@ main...origin/main HEAD equals published EOD SHA ``` -Only after ALL four pass may a branch be created. +Only after ALL four pass may a branch be created or the active team branch/workstream be updated. Create the PR branch: @@ -112,9 +112,13 @@ From branch creation until merge: - Remain on the PR branch. - Never checkout `main`. - Commit only on the PR branch. +- Work must be committed only to the active team branch. - Push only the PR branch. - Execute validation from the PR branch. - Open/update the PR from the PR branch. +- For OWNER-approved stacked/sequential workstreams, PR branches/commits stay on the active team branch/workstream between sequential PRs during the day. +- Do not return to `main` between sequential PRs in the same active workstream unless OWNER explicitly approves an EOD or intermediate merge checkpoint. +- This rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. Hard Stops: @@ -192,7 +196,8 @@ STOP if: - `main...origin/main` is not `0 0` before creating PR branch - `HEAD` SHA differs from published baseline - merge attempted without successful validation -- new PR started before returning to synchronized `main` +- new unrelated PR or workstream started before returning to synchronized `main` +- sequential work continues without an OWNER-approved stacked/sequential workstream model ## Start Of Day Boundary diff --git a/docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md b/docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md index 997b16730..93a67afb4 100644 --- a/docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md +++ b/docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md @@ -6,6 +6,9 @@ Standardize testing locations and ensure independent tool validation. ## Canonical Test Structure +Page-level Playwright tests: +- tests/playwright/{runtime-page-path}/index.spec.mjs + Tool tests: - tests/toolbox/{tool-name}/ @@ -31,3 +34,38 @@ Regression tests: - Tool tests validate tool functionality. - Regression tests validate platform behavior. - New tests follow the canonical structure. +- Every user-accessible page must have at least one matching page-level Playwright test before it can be considered complete. +- Runtime page path determines the page-level Playwright test path. +- Primary page-level Playwright test file should be `index.spec.mjs`. +- Do not organize new page-level Playwright tests only by feature nickname or technology bucket when a page path exists. +- Legacy broad tests may remain while migration is planned; document migration/deprecation instead of moving broad legacy tests unless the PR scope requires it. + +## Page-Level Playwright Examples + +- `/admin/index.html` -> `tests/playwright/admin/index/index.spec.mjs` +- `/toolbox/sprites/index.html` -> `tests/playwright/toolbox/sprites/index.spec.mjs` +- `/toolbox/game-hub/index.html` -> `tests/playwright/toolbox/game-hub/index.spec.mjs` +- `/toolbox/messages/index.html` -> `tests/playwright/toolbox/messages/index.spec.mjs` +- `/toolbox/game-configuration/index.html` -> `tests/playwright/toolbox/game-configuration/index.spec.mjs` + +## Minimum Page-Level Playwright Coverage + +Minimum page-level test: + +- route loads +- page renders +- navigation works +- no visible placeholder-only state for completed/testable pages +- primary workflow is covered where the PR claims Product Owner testable completion +- save/load and validation are covered where applicable +- no runtime console errors when feasible + +Additional scenario files may use: + +- `create.spec.mjs` +- `edit.spec.mjs` +- `delete.spec.mjs` +- `archive.spec.mjs` +- `navigation.spec.mjs` +- `permissions.spec.mjs` +- `validation.spec.mjs` diff --git a/docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md b/docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md index a44e7fcd5..2bcc52a60 100644 --- a/docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md +++ b/docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md @@ -12,7 +12,7 @@ Define how Codex plans and executes Creator-facing tool MVP work without creatin For tool MVPs, use: ```text -One large Codex command -> multiple focused stacked PRs -> each PR has a testable Creator outcome. +One large Codex command -> multiple focused stacked PRs -> each PR has a Product Owner testable outcome. ``` ## Rules @@ -20,7 +20,7 @@ One large Codex command -> multiple focused stacked PRs -> each PR has a testabl - Do not create one giant PR. - Do not stop after every small PR unless blocked. - Each PR must be independently scoped. -- Each PR must produce a Creator-testable outcome. +- Each PR must produce a Product Owner testable outcome. - Each PR must answer: ```text @@ -40,8 +40,43 @@ For tool MVP PR planning, visible acceptance must be Creator-facing first. Architecture can be handled under the covers, but PR purpose must be user-testable. +A request to complete a page, tool, MVP, or testable experience means Product Owner testable by default. Codex must deliver a working Product Owner testable feature, not a shell or foundation page, unless the Product Owner explicitly requests a shell/foundation PR. + +A Product Owner testable outcome means the Product Owner can: + +- open the page/tool +- perform the primary workflow +- save/load data where applicable +- observe expected results +- validate success and failure states +- follow manual validation steps from the PR report + +Not acceptable as complete/testable: + +- shell-only page +- route-only page +- navigation-only PR +- template-only page +- placeholder controls +- static table with no workflow +- `Not implemented yet` +- `coming soon` +- placeholder-only workspace, inspector, or output sections +- planned-only tile +- route that loads but cannot be used + +Required for Product Owner testable completion: + +- visible working controls +- API-backed data where required +- validation and error states +- empty states +- save/load behavior where applicable +- manual validation steps for Product Owner +- targeted Playwright coverage where impacted. + Each tool MVP PR must state: -- Creator-testable outcome +- Product Owner testable outcome - What Playwright tests - What Mr. Q should manually test - Whether the PR is part of a stacked MVP sequence @@ -50,6 +85,8 @@ Each tool MVP PR must state: ## Runtime Data Completion Boundary +A PR requested to complete a page, tool, MVP, or testable experience must not stop after route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless the Product Owner explicitly requested a shell/foundation PR. + A PR outcome must not be described as complete if the visible data is coming from: - mock repositories @@ -81,4 +118,8 @@ Each PR in the stack still follows the canonical START / WORK / END lifecycle an When OWNER gives one large Codex command for a tool MVP stack, Codex may continue from one completed PR to the next without stopping for a conversational checkpoint, unless a blocker listed in this standard occurs. -The final PR in the stack must perform normal closeout and stop all work after returning to synchronized main. +During an OWNER-approved day workstream, PR branches/commits stay on the active team branch/workstream and do not return to `main` between PRs. + +This rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. + +The final PR in the stack must perform normal EOD closeout or OWNER-approved merge-checkpoint closeout and stop all work after returning to synchronized main. diff --git a/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md b/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md index 37fe942aa..10ed1c93e 100644 --- a/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md +++ b/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md @@ -26,7 +26,10 @@ 0% Complete — Create the visual look of your game - [ ] Bravo - Asset Studio V2 -- [ ] Bravo - Sprite Studio V2 +- [ ] Charlie - Sprites canvas editor MVP + - Sprites is a creator tool, not only an asset metadata library. + - MVP requires canvas/grid editor behavior, width/height controls, Palette/Colors-only reusable colors, color selection from Palette/Colors, pixel painting, save/load sprite grid data through the API/database, and Product Owner manual validation. + - Category is removed from Sprites MVP planning. - [ ] Bravo - Animation Studio V2 - [ ] Bravo - Palette Manager - [ ] Bravo - Video Studio diff --git a/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md b/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md index d35cf888f..4253971d9 100644 --- a/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md +++ b/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md @@ -48,15 +48,11 @@ Current OWNER clarification: ## Team Alfa -Status: Active - -Active assignment: PR_26177_DELTA_056-shared-validation-assertions. - -Active branch: PR_26177_DELTA_056-shared-validation-assertions. +Status: Available -Active PR: PR_26177_DELTA_056-shared-validation-assertions. +Active assignment: none. -OWNER override approved: Continue Team Delta random utility stack with PR_26177_DELTA_056-shared-validation-assertions. +Active branch: none. ## Team Bravo @@ -76,11 +72,15 @@ Active branch: none. ## Team Delta -Status: Available +Status: Active -Active assignment: none. +Active assignment: PR_26177_DELTA_056-shared-validation-assertions. -Active branch: none. +Active branch: PR_26177_DELTA_056-shared-validation-assertions. + +Active PR: PR_26177_DELTA_056-shared-validation-assertions. + +OWNER override approved: Continue Team Delta random utility stack with PR_26177_DELTA_056-shared-validation-assertions. ## Team Golf diff --git a/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md b/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md index 1e2e47843..4e6548811 100644 --- a/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md +++ b/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md @@ -34,6 +34,7 @@ This section is the current OWNER-approved active ownership alignment. - Environment management - System Health - Operations +- Sprites canvas editor MVP Team Charlie System Health owns: - Environment Summary @@ -42,6 +43,11 @@ Team Charlie System Health owns: - Runtime Health - Health Check History +Team Charlie Sprites ownership: +- Sprites is a creator tool, not only an asset metadata library. +- Sprites MVP requires canvas/grid editor behavior, width/height controls, Palette/Colors-only reusable colors, color selection from Palette/Colors, pixel painting, save/load sprite grid data through the API/database, and Product Owner manual validation. +- Sprites must not own reusable color definitions. + ## Team Delta - Engine diff --git a/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md new file mode 100644 index 000000000..96bc721e6 --- /dev/null +++ b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md @@ -0,0 +1,61 @@ +# PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment + +Date: 2026-06-26 +Team: OWNER +Branch: PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment + +## Purpose + +Align active Project Instructions with current OWNER decisions for daily workflow, Product Owner testable completion, environment/API invariance, page-level Playwright organization, active team registry consistency, and Sprites ownership/backlog. + +## Scope + +Governance and backlog documentation only. + +No runtime code, UI code, API code, database code, start_of_day files, history snapshots, or unrelated cleanup were changed. + +## Changes + +- Clarified SOD/day-work/EOD workflow: + - SOD starts from latest synchronized `main`. + - Active work happens on one active team branch/workstream. + - Work must be committed only to the active team branch. + - PR branches/commits stay on the active team branch/workstream during the day. + - The rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. + - `main` is only the SOD baseline and EOD return target unless OWNER approves a merge checkpoint. +- Added Product Owner testable completion definition. +- Replaced validation/completion-gate `Creator-testable` wording with Product Owner testable wording while preserving product-facing Creator language where appropriate. +- Added the no-shell completion rule for page/tool/MVP requests. +- Strengthened page-level Playwright completion gates for primary workflows, save/load, and validation coverage where applicable. +- Confirmed `Browser -> API -> Database`, one API/service contract across environments, and `Local API` as the shared API running locally. +- Added page-path Playwright organization rules and examples. +- Fixed active team registry mismatch in `TEAM_ASSIGNMENTS.md`. +- Moved Sprites ownership/backlog from Bravo Sprite Studio V2 wording to Team Charlie Sprites canvas editor MVP. +- Removed Category as a Sprites MVP planning requirement. + +## Validation + +- PASS: documentation-only changed-file check. +- PASS: no runtime files changed. +- PASS: no UI files changed. +- PASS: no API files changed. +- PASS: no database files changed. +- PASS: no `start_of_day` files changed. +- PASS: no history snapshots rewritten. +- PASS: no active instruction permits direct PR commits to `main`. +- PASS: EOD/main-return wording is clarified as closeout or OWNER-approved merge checkpoint, not between stacked/sequential PRs. +- PASS: Product Owner testable definition exists. +- PASS: shell/template/navigation-only completion is explicitly disallowed unless requested by Product Owner. +- PASS: page-level Playwright completion gate exists. +- PASS: API/environment wording is consistent. +- PASS: active registry and assignment table agree for current Delta active assignment. + +## Artifact + +- `tmp/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_delta.zip` + +## Manual Validation Notes + +Reviewers should verify that daily team work now has one clear model: + +SOD from synchronized `main`, work on the active team branch/workstream, no return to `main` between stacked/sequential PRs, and EOD return to synchronized `main`. diff --git a/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_branch-validation.md b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_branch-validation.md new file mode 100644 index 000000000..4fd37a376 --- /dev/null +++ b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_branch-validation.md @@ -0,0 +1,18 @@ +# Branch Validation + +Task: PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment +Date: 2026-06-26 + +| Check | Result | Notes | +| --- | --- | --- | +| Started from `main` | PASS | `main...origin/main` was `0 0` before branch creation. | +| Worktree clean before branch | PASS | Start gate passed. | +| Work committed only to active team branch | PASS | Branch is `PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment`; no commit was made to `main`. | +| No direct commit to `main` | PASS | No commit was made on `main`. | +| Active instruction files only | PASS | Changes are under `docs_build/dev/ProjectInstructions/` plus required reports. | +| Runtime files changed | PASS | None. | +| start_of_day files changed | PASS | None. | + +## Result + +PASS diff --git a/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md new file mode 100644 index 000000000..c275c0c72 --- /dev/null +++ b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md @@ -0,0 +1,23 @@ +# Manual Validation Notes + +Task: PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment +Date: 2026-06-26 + +## Reviewer Checklist + +- Confirm `main` is described as SOD baseline and EOD return target, not the place for day-work commits. +- Confirm stacked/sequential PR branches/commits stay on the active team branch/workstream during the day. +- Confirm this branch workflow applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team. +- Confirm Product Owner testable excludes shell-only, placeholder-only, planned-only, or route-only completion. +- Confirm Product Owner testable means the Product Owner can open the page/tool, perform the primary workflow, save/load where applicable, observe expected results, validate success/failure states, and follow PR-report manual steps. +- Confirm page/tool/MVP completion PRs cannot stop at route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless Product Owner requested a shell/foundation PR. +- Confirm page-level Playwright tests follow runtime page paths. +- Confirm page-level Playwright completion gates cover primary workflows and save/load/validation where applicable. +- Confirm `Local API` means the shared API running locally. +- Confirm Team Charlie owns Sprites canvas editor MVP. +- Confirm Sprites planning requires canvas/grid editor, width/height controls, Palette/Colors-only reusable colors, pixel painting, API/database save/load, and Product Owner manual validation. +- Confirm Bravo no longer owns `Sprite Studio V2` in active backlog. + +## Manual Result + +PASS diff --git a/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md new file mode 100644 index 000000000..75b5ad8b6 --- /dev/null +++ b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md @@ -0,0 +1,27 @@ +# Requirement Checklist + +Task: PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment +Date: 2026-06-26 + +| Requirement | Result | Notes | +| --- | --- | --- | +| Daily branch workflow documented | PASS | Added SOD/day-work/EOD wording. | +| Branch workflow is team-neutral | PASS | Active wording says work commits and sequential PR branches/commits stay on the active team branch/workstream and applies to all teams. | +| Product Owner testable definition documented | PASS | Added in PR workflow and Tool MVP standard. | +| Ambiguous Creator-testable completion wording replaced | PASS | Completion/validation gates now use Product Owner testable wording; product-facing Creator language is preserved. | +| No-shell PR rule added | PASS | Completion requests may not stop at routes, shells, placeholder UI, static mock layouts, or navigation activation unless explicitly requested. | +| Product Owner testable outcome definition expanded | PASS | Defines opening the page/tool, primary workflow, save/load where applicable, expected results, success/failure states, and PR-report manual steps. | +| Page-level Playwright completion gate strengthened | PASS | Requires matching page-level tests before completion, including primary workflow and save/load/validation where applicable. | +| API/environment rule confirmed | PASS | Added `Browser -> API -> Database`, shared API contract, and Local API definition. | +| Page-level Playwright organization added | PASS | Added runtime path to test path rules and examples. | +| Active team registry consistency fixed | PASS | `TEAM_ASSIGNMENTS.md` now matches the active registry for Delta assignment. | +| Sprites ownership/backlog aligned | PASS | Team Charlie owns Sprites canvas editor MVP; Bravo Sprite Studio V2 line removed. | +| Category removed from Sprites planning | PASS | Backlog notes state Category is removed from Sprites MVP planning. | +| No runtime behavior changes | PASS | Documentation/governance only. | +| No history snapshots rewritten | PASS | No archive/history files changed. | +| Required reports generated | PASS | Report, branch validation, checklist, validation lane, manual notes, review diff, changed files. | +| Repo ZIP generated | PASS | ZIP is generated under `tmp/`. | + +## Result + +PASS diff --git a/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md new file mode 100644 index 000000000..f098579ae --- /dev/null +++ b/docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md @@ -0,0 +1,37 @@ +# Validation Lane + +Task: PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment +Date: 2026-06-26 + +## Commands + +```text +git diff --check +git diff --name-only +rg -n "Always return to main before starting the next PR|Sprite Studio V2" docs_build/dev/ProjectInstructions +rg -n "Creator-testable|testable Creator outcome|manual Creator validation" docs_build/dev/ProjectInstructions +rg -n "Product Owner testable|no-shell|route-only page|static table with no workflow|page-level Playwright|primary workflow is covered|Browser -> API -> Database|Local API" docs_build/dev/ProjectInstructions +``` + +## Results + +- PASS: `git diff --check` +- PASS: changed files are active Project Instructions plus required reports only. +- PASS: no runtime/UI/API/database/start_of_day files changed. +- PASS: no `Sprite Studio V2` active backlog owner remains. +- PASS: no OWNER-only branch workflow wording remains. +- PASS: active branch workflow says commits and sequential PR branches/commits stay on the active team branch/workstream. +- PASS: no `Creator-testable`, `testable Creator outcome`, or `manual Creator validation` completion-gate wording remains. +- PASS: Product Owner testable outcome definition includes primary workflow, save/load where applicable, expected results, success/failure states, and PR-report manual steps. +- PASS: no-shell completion rule exists. +- PASS: Product Owner testable text exists. +- PASS: page-level Playwright completion gate includes primary workflow and save/load/validation coverage where applicable. +- PASS: API/environment contract text exists. + +## Playwright + +Not run. This is a documentation/governance-only PR with no runtime page, API, or UI behavior changes. + +## Result + +PASS diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt index 1feb80f42..98a71e332 100644 --- a/docs_build/dev/reports/codex_changed_files.txt +++ b/docs_build/dev/reports/codex_changed_files.txt @@ -1,4 +1,11 @@ +docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md +docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md +docs_build/dev/ProjectInstructions/addendums/pr_workflow.md +docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md +docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md +docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md +docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md +docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md +docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/codex_review.diff -docs_build/dev/reports/PR_26177_BRAVO_015-final-eod-closeout.md -docs_build/dev/reports/PR_26177_BRAVO_EOD-closeout.md diff --git a/docs_build/dev/reports/codex_review.diff b/docs_build/dev/reports/codex_review.diff index 686169865..246e75adf 100644 Binary files a/docs_build/dev/reports/codex_review.diff and b/docs_build/dev/reports/codex_review.diff differ