From a5d2f8c26cbd55453d395f9ff5bdafbd3655ae00 Mon Sep 17 00:00:00 2001 From: Delta Team Date: Wed, 24 Jun 2026 11:53:22 -0400 Subject: [PATCH] PR_26175_ALFA_015: consolidate Alfa foundation runtime changes --- ..._ALFA_015-alfa-foundation-consolidation.md | 80 ++ .../dev/reports/codex_changed_files.txt | 18 +- docs_build/dev/reports/codex_review.diff | 735 ++---------------- .../game-journey-mock-repository.js | 2 +- .../playwright/tools/GameJourneyTool.spec.mjs | 2 + 5 files changed, 135 insertions(+), 702 deletions(-) create mode 100644 docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md diff --git a/docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md b/docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md new file mode 100644 index 000000000..b2e2375f4 --- /dev/null +++ b/docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md @@ -0,0 +1,80 @@ +# PR_26175_ALFA_015 - Alfa Foundation Consolidation + +Branch: `PR_26175_ALFA_015-alfa-foundation-consolidation` +Team: Alfa +Source PRs represented: #96, #97, #98, #99, #100, #101 +Playwright impacted: YES + +## Executive Summary + +This PR carries forward a concrete runtime consolidation from the Alfa foundation stack onto current `main`. + +Current `main` already contains the broad Game Hub, Game Journey, and Idea Board foundation behavior from the #96-#101 chain. Instead of recreating stale branch conflicts or producing another report-only PR, this branch fixes a remaining Game Journey repository issue in that foundation layer: + +- Recommended target records now calculate their insertion order from the resolved bucket note, not the legacy default design-pass note. +- The Game Journey Playwright coverage now asserts that the persisted Hero recommended target belongs to the Objects bucket with the expected bucket-local order. + +## Runtime Files Changed + +| File | Change | +| --- | --- | +| `src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js` | Updates recommended target item ordering to use the resolved Game Journey bucket note key. | + +## Tests Updated + +| File | Change | +| --- | --- | +| `tests/playwright/tools/GameJourneyTool.spec.mjs` | Adds regression assertions for persisted recommended target `gameKey` and bucket-local `order`. | + +## Reports Generated + +| File | Purpose | +| --- | --- | +| `docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md` | This implementation and validation report. | +| `docs_build/dev/reports/codex_changed_files.txt` | Changed file inventory for the PR. | +| `docs_build/dev/reports/codex_review.diff` | Review diff for the PR. | +| `tmp/PR_26175_ALFA_015-alfa-foundation-consolidation_delta.zip` | Repo-structured delta ZIP. | + +## Branch Validation + +| Check | Result | Notes | +| --- | --- | --- | +| Started from `main` | PASS | `main` confirmed before branch creation. | +| Worktree clean before branch | PASS | No local changes before branch creation. | +| `main` and `origin/main` synced | PASS | Local/origin sync confirmed as `0 0`. | +| `git pull --ff-only` before branch | PASS | Already up to date. | +| Runtime scope only | PASS | Runtime change is limited to Game Journey mock repository behavior. | +| No unrelated cleanup | PASS | Generated validation coverage noise was restored after the blocked Playwright run. | + +## Requirement Checklist + +| Requirement | Result | Notes | +| --- | --- | --- | +| Read all Project Instructions | PASS | Active files and archived history markers were read before implementation. | +| Implement actual runtime changes from #96-#101 foundation scope | PASS | Corrects Game Journey recommended target ordering in the foundation repository layer. | +| Do not create report-only PR | PASS | Includes runtime and test changes. | +| Carry forward real code changes onto current `main` | PASS | Applies a current-main consolidation fix rather than stale branch artifacts. | +| Runtime files changed | PASS | `game-journey-mock-repository.js` changed. | +| Tests updated | PASS | `GameJourneyTool.spec.mjs` changed. | +| Reports generated | PASS | Required report files are included. | +| Playwright impacted | PASS | Marked as impacted and targeted lane invoked. | +| Run targeted tests only | PASS | Only the requested targeted Playwright specs were invoked. | +| Create repo-structured ZIP under `tmp/` | PASS | ZIP generated at the required path. | +| Do not delete branches | PASS | No branch deletion performed. | +| Do not merge GitHub PRs directly | PASS | No source PRs were merged directly. | + +## Validation Lane Report + +| Validation | Result | Command / Notes | +| --- | --- | --- | +| Direct repository smoke | PASS | Inline Node smoke verified Hero target persists to the Objects bucket with `order: 2`. | +| Diff whitespace check | PASS | `git diff --check` returned no whitespace errors; Git reported an existing CRLF warning for the touched spec. | +| Playwright browser install | FAIL | `npx playwright install chromium` timed out after 600 seconds and did not install `chromium-1217`. | +| Targeted Playwright lane | BLOCKED | `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs tests/playwright/tools/GameJourneyTool.spec.mjs tests/playwright/tools/GameHubMockRepository.spec.mjs --reporter=line` failed all 37 tests before launch because `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe` is missing. | + +## Manual Validation Notes + +- Manual browser validation was not performed because the local Playwright Chromium executable is missing. +- The direct repository smoke covers the changed persistence behavior without browser startup. +- The requested Playwright specs were invoked and failed before executing product behavior due to the missing browser dependency. +- No runtime code outside the Alfa Game Journey foundation path was modified. diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt index 4aa64ab71..9856718b2 100644 --- a/docs_build/dev/reports/codex_changed_files.txt +++ b/docs_build/dev/reports/codex_changed_files.txt @@ -1,17 +1,5 @@ -docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md -docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md -docs_build/dev/ProjectInstructions/addendums/multi_team.md -docs_build/dev/ProjectInstructions/addendums/pr_workflow.md -docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md -docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md -docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md -docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md -docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md -docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md -docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md -docs_build/dev/reports/PR_REVIEW_003.md -docs_build/dev/reports/PR_REVIEW_050.md -docs_build/dev/reports/PR_REVIEW_051.md -docs_build/dev/reports/PR_REVIEW_118.md +src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js +tests/playwright/tools/GameJourneyTool.spec.mjs +docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/codex_review.diff diff --git a/docs_build/dev/reports/codex_review.diff b/docs_build/dev/reports/codex_review.diff index 5be4429c8..b292eddb4 100644 --- a/docs_build/dev/reports/codex_review.diff +++ b/docs_build/dev/reports/codex_review.diff @@ -1,689 +1,52 @@ -diff --git a/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md b/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md -index 3314b3dea..20d6ae342 100644 ---- a/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md -+++ b/docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md -@@ -59,0 +60,22 @@ Rules: -+ -+## Current Active Ownership Lanes -+ -+OWNER override approved. -+ -+The current active ownership lanes are: -+ -+- Team Alfa -+- Team Bravo -+- Team Charlie -+- Team Delta -+- Team Golf -+- Team OWNER -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+Rules: -+- Do not rewrite historical PR references that mention Team Gamma. -+- Do not rename historical branches that contain Gamma. -+- Team Golf may own newly assigned work, review packets, cleanup, release, or OWNER-directed cross-team work. -+- Team Golf must not silently take backlog ownership from Alfa, Bravo, Charlie, or Delta; cross-team work requires OWNER approval. -diff --git a/docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md b/docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md -index 12f74cb1f..d0118f63a 100644 ---- a/docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md -+++ b/docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md -@@ -92,0 +93,22 @@ Work only that assignment. -+## Start Team Golf -+ -+Ready-to-copy command: -+ -+```text -+OWNER override approved: Start Team Golf from the ProjectInstructions release gate. -+ -+Read docs_build/dev/ProjectInstructions/README.txt first. -+Read docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md. -+Read docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md. -+Read docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md. -+ -+Stop if Team Golf already has an active branch. -+Stop if Team Golf already has an active assignment. -+Stop if OWNER has not explicitly assigned Team Golf work. -+Stop if the selected work conflicts with current Alfa, Bravo, Charlie, or Delta ownership. -+ -+Record the selected assignment under Team Golf in TEAM_ASSIGNMENTS.md. -+Create or use one Team Golf branch for the selected assignment. -+Work only that assignment. -+``` -+ -diff --git a/docs_build/dev/ProjectInstructions/addendums/multi_team.md b/docs_build/dev/ProjectInstructions/addendums/multi_team.md -index 797a8834e..190813840 100644 ---- a/docs_build/dev/ProjectInstructions/addendums/multi_team.md -+++ b/docs_build/dev/ProjectInstructions/addendums/multi_team.md -@@ -15,0 +16,22 @@ Rules: -+## Current Active Ownership Lanes -+ -+OWNER override approved. -+ -+The current active ownership lanes are: -+ -+- Team Alfa -+- Team Bravo -+- Team Charlie -+- Team Delta -+- Team Golf -+- Team OWNER -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+Rules: -+- Historical PR references and branch names that mention Gamma remain unchanged for traceability. -+- New active work that would previously have used Team Gamma routes to Team Golf. -+- Team Golf work requires OWNER assignment, an active branch, an active draft/open PR, or active release/cleanup responsibility. -+- If Team Golf work touches Alfa, Bravo, Charlie, or Delta ownership areas, the PR must document the OWNER cross-team decision. -+ -diff --git a/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md b/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md -index cadfee261..e4b0ba1de 100644 ---- a/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md -+++ b/docs_build/dev/ProjectInstructions/addendums/pr_workflow.md -@@ -56,0 +57,2 @@ Applies to: -+- Team Delta -+- Team Golf -diff --git a/docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md b/docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md -index d73cfcb9f..521758eeb 100644 ---- a/docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md -+++ b/docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md -@@ -6,0 +7,5 @@ This gate prevents Team Alfa, Team Bravo, Team Charlie, or Team OWNER from start -+Current OWNER clarification: -+- This gate also applies to Team Delta and Team Golf. -+- Team Gamma is retired. Team Golf is the replacement active ownership lane. -+- Historical wording that listed fewer teams remains traceable, but it must not exclude Delta or Golf from current active ownership governance. -+ -diff --git a/docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md b/docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md -index e1018c155..d6af3271c 100644 ---- a/docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md -+++ b/docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md -@@ -33,0 +34,22 @@ Each team start must confirm the selected backlog item is inside that team's own -+## Current Active Ownership Start Map -+ -+OWNER override approved. -+ -+The current active ownership start map includes: -+ -+- Team Alfa -+- Team Bravo -+- Team Charlie -+- Team Delta -+- Team Golf -+- Team OWNER -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+Clarification: -+- The four-team start set remains the backlog ownership start set for Alfa, Bravo, Charlie, and Delta. -+- Team Golf is valid for OWNER-assigned, branch-backed, PR-backed, release, review packet, or cleanup work. -+- Historical Gamma references and branch names must remain unchanged. -+- Golf work must not silently take ownership from Alfa, Bravo, Charlie, or Delta; cross-team work requires OWNER approval. -+ -diff --git a/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md b/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md -index 0b8942261..ed2f85a4b 100644 ---- a/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md -+++ b/docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md -@@ -164,0 +165,7 @@ -+Current OWNER clarification: -+- The backlog alignment below preserves the current Alfa, Bravo, Charlie, and Delta ownership model. -+- Team Gamma is retired. Team Golf is the replacement active ownership lane. -+- Team Golf has no standing backlog ownership area in this file unless OWNER assigns one. -+- Golf work may be OWNER-assigned, branch-backed, PR-backed, release, review packet, or cleanup work and must not silently replace Alfa, Bravo, Charlie, or Delta ownership. -+- Historical Gamma PR references and branch names are not renamed by this clarification. -+ -diff --git a/docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md b/docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md -index 5ca625819..6ddf25619 100644 ---- a/docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md -+++ b/docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md -@@ -30,0 +31,5 @@ If a team has no assignment, no active branch, and no active PR, it is inactive -+| Team Alfa | none | none | none | Available | Active ownership lane | -+| Team Bravo | none | none | none | Available | Active ownership lane | -+| Team Charlie | none | none | none | Available | Active ownership lane | -+| Team Delta | none | none | none | Available | Active ownership lane | -+| Team Golf | none | none | none | Available | Replacement active ownership lane for retired Team Gamma | -@@ -32,0 +38,11 @@ If a team has no assignment, no active branch, and no active PR, it is inactive -+## Current Active Ownership Lanes -+ -+OWNER override approved. -+ -+The current active ownership lanes are Team Alfa, Team Bravo, Team Charlie, Team Delta, Team Golf, and Team OWNER. -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+Historical Gamma PR references and branch names remain unchanged for traceability. -+ -diff --git a/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md b/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md -index acefbba8e..afe4efa91 100644 ---- a/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md -+++ b/docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md -@@ -6,0 +7,6 @@ -+| Team Alfa | none | none | none | Available | -+| Team Bravo | none | none | none | Available | -+| Team Charlie | none | none | none | Available | -+| Team Delta | none | none | none | Available | -+| Team Golf | none | none | none | Available | -+| Team OWNER | none | none | none | Available | -@@ -29,0 +36,6 @@ it is currently inactive. -+Current OWNER clarification: -+- The active ownership lanes are Team Alfa, Team Bravo, Team Charlie, Team Delta, Team Golf, and Team OWNER. -+- Team Gamma is retired. Team Golf is the replacement active ownership lane. -+- Do not rewrite historical PR references that mention Team Gamma. -+- Do not rename historical branches that contain Gamma. -+ -@@ -67,0 +80,10 @@ Active branch: none. -+## Team Golf -+ -+Status: Available -+ -+Active assignment: none. -+ -+Active branch: none. -+ -+OWNER decision: Replacement active ownership lane for retired Team Gamma. -+ -diff --git a/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md b/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md -index 865cca551..bc4808b6f 100644 ---- a/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md -+++ b/docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md -@@ -54,0 +55,23 @@ Each team may pull only from its ownership area unless OWNER explicitly reassign -+## Current Active Ownership Lanes -+ -+OWNER override approved. -+ -+The current active ownership lanes are: -+ -+- Team Alfa -+- Team Bravo -+- Team Charlie -+- Team Delta -+- Team Golf -+- Team OWNER -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+Clarification: -+- The four-team rule remains the current backlog ownership model for Alfa, Bravo, Charlie, and Delta. -+- Team Golf does not receive a standing backlog ownership area in this file. -+- Team Golf work requires OWNER assignment, an active branch, an active draft/open PR, or active release/review/cleanup responsibility. -+- Golf work that touches Alfa, Bravo, Charlie, or Delta areas must document the OWNER cross-team decision. -+- Historical Gamma PR references and branch names remain unchanged for traceability. -+ -diff --git a/docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md b/docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md -new file mode 100644 -index 000000000..055d7c1cb ---- /dev/null -+++ b/docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md -@@ -0,0 +1,87 @@ -+# PR_26175_OWNER_046-pr-targeted-review-packets -+ -+OWNER override approved. -+ -+## Summary -+ -+This PR updates active Project Instructions governance from Team Gamma to Team Golf and creates targeted GitHub-authoritative review packets for PR #3, #50, #51, and #118. No runtime behavior changes, PR merges, PR closures, or branch deletions were performed. -+ -+Migration note: -+Team Gamma is retired. Team Golf is the replacement active ownership lane. -+ -+## Branch Validation -+ -+| Check | Result | Evidence | -+|---|---|---| -+| Started from main | PASS | Started from `main`, pulled with `--ff-only`, and created the OWNER_046 branch from updated main. | -+| Current branch | PASS | `PR_26175_OWNER_046-pr-targeted-review-packets` | -+| Expected branch | PASS | `PR_26175_OWNER_046-pr-targeted-review-packets` | -+| Base sync | PASS | Branch base `d39cc8c8e8f0673cb523547bc58264ab26bbcf3b`; main `d39cc8c8e8f0673cb523547bc58264ab26bbcf3b`; origin/main `d39cc8c8e8f0673cb523547bc58264ab26bbcf3b`. | -+| Worktree before edits | PASS | Clean before branch creation and file generation. | -+ -+## Requirement Checklist -+ -+| Requirement | Result | Notes | -+|---|---|---| -+| Read all Project Instructions | PASS | Read 47 files under `docs_build/dev/ProjectInstructions/`. | -+| Replace active Team Gamma ownership with Team Golf | PASS | Active governance now routes retired Gamma lane to Team Golf. | -+| New active teams include Alfa | PASS | Active ownership map includes Team Alfa. | -+| New active teams include Bravo | PASS | Active ownership map includes Team Bravo. | -+| New active teams include Charlie | PASS | Active ownership map includes Team Charlie. | -+| New active teams include Delta | PASS | Active ownership map includes Team Delta. | -+| New active teams include Golf | PASS | Active ownership map includes Team Golf. | -+| New active teams include OWNER | PASS | Active ownership map includes Team OWNER. | -+| Do not rewrite historical PR references | PASS | No archive/history PR references were edited. | -+| Do not rename historical branches | PASS | Review packets preserve historical Gamma branch names exactly. | -+| Add migration note | PASS | Added exact note: "Team Gamma is retired. Team Golf is the replacement active ownership lane." | -+| Generate PR #3 packet | PASS | Created `docs_build/dev/reports/PR_REVIEW_003.md`. | -+| Generate PR #50 packet | PASS | Created `docs_build/dev/reports/PR_REVIEW_050.md`. | -+| Generate PR #51 packet | PASS | Created `docs_build/dev/reports/PR_REVIEW_051.md`. | -+| Generate PR #118 packet | PASS | Created `docs_build/dev/reports/PR_REVIEW_118.md`. | -+| Include required packet fields | PASS | Each packet includes title, team, branch, dates, file lists, diff summary, purpose, risks, dependencies, and recommendation. | -+| No merges | PASS | No merge action performed. | -+| No PR closures | PASS | No PR close action performed. | -+| No branch deletions | PASS | No branch deletion performed. | -+| No runtime behavior changes | PASS | Governance/report packet files changed only. | -+| Required reports | PASS | Generated summary report, `codex_changed_files.txt`, and `codex_review.diff`. | -+| Repo ZIP under tmp/ | PASS | Created `tmp/PR_26175_OWNER_046-pr-targeted-review-packets_delta.zip`. | -+ -+## Validation Lane Report -+ -+| Lane | Result | Evidence | -+|---|---|---| -+| Governance lane | PASS | Updated active Project Instructions files only; history snapshots left untouched. | -+| GitHub authority lane | PASS | PR metadata and file lists fetched from GitHub REST API for #3, #50, #51, and #118. | -+| Review packet lane | PASS | Four review packet files generated. | -+| Scope lane | PASS | No runtime files modified by this branch. | -+| Whitespace lane | PASS | `git diff --check` passed after artifact generation. | -+| ZIP lane | PASS | ZIP created and contents verified as repo-structured. | -+ -+## Review Packet Index -+ -+| PR | Team | Changed Files | Code Files | Recommendation | Packet | -+|---|---|---:|---:|---|---| -+| #3 | Team Bravo | 15 | 4 | Owner Decision Required. Review Bravo ownership, branch freshness, and current Messages/Emotion direction before merge/closure. | `docs_build/dev/reports/PR_REVIEW_003.md` | -+| #50 | Team Golf (historical Gamma lane) | 5 | 0 | Review First. Likely final historical Gamma/SQLite status packet, now routed to Team Golf for active ownership decisions. | `docs_build/dev/reports/PR_REVIEW_050.md` | -+| #51 | Team OWNER | 12 | 0 | Owner Decision Required. Historical governance bootstrap overlaps current ProjectInstructions state and must not be merged or archived without OWNER decision. | `docs_build/dev/reports/PR_REVIEW_051.md` | -+| #118 | Team Alfa | 7 | 0 | Review First. Treat as owner closeout evidence for the Alfa stack; do not merge until stack/order review is complete. | `docs_build/dev/reports/PR_REVIEW_118.md` | -+ -+## Changed Governance Files -+ -+- `docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md` -+- `docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md` -+- `docs_build/dev/ProjectInstructions/addendums/multi_team.md` -+- `docs_build/dev/ProjectInstructions/addendums/pr_workflow.md` -+- `docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md` -+- `docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md` -+- `docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md` -+- `docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md` -+- `docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md` -+- `docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md` -+ -+## Manual Validation Notes -+ -+- Confirmed Team Gamma retirement was added as an active governance migration note without editing historical PR references or branch names. -+- Confirmed Team Golf is now the replacement active ownership lane in current governance. -+- Confirmed PR review packets preserve GitHub titles and branch names exactly, including historical Gamma/Master/Alfa naming. -+- Confirmed no runtime behavior files were edited for this branch. -diff --git a/docs_build/dev/reports/PR_REVIEW_003.md b/docs_build/dev/reports/PR_REVIEW_003.md -new file mode 100644 -index 000000000..c5b44b288 ---- /dev/null -+++ b/docs_build/dev/reports/PR_REVIEW_003.md -@@ -0,0 +1,98 @@ -+# PR Review Packet #003 -+ -+## 1. Title -+ -+Pr/PR 26171 006 message emotion profile management -+ -+## 2. Team -+ -+Team Bravo -+ -+## 3. Branch -+ -+`pr/PR_26171_006-message-emotion-profile-management` -+ -+## 4. Created Date -+ -+2026-06-20T01:02:11Z -+ -+## 5. Updated Date -+ -+2026-06-20T01:08:39Z -+ -+## Status And Age -+ -+- Status: Open -+- Age: 4d 2h -+- Author: ToolboxAid -+- URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/3 -+ -+## 6. Full Changed File List -+ -+- docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-manual-validation.md (added, +11/-0) -+- docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-validation.txt (added, +30/-0) -+- docs_build/dev/reports/PR_26171_006-message-emotion-profile-management.md (added, +53/-0) -+- docs_build/dev/reports/codex_changed_files.txt (updated, +8/-9) -+- docs_build/dev/reports/codex_review.diff (updated, +352/-305) -+- docs_build/pr/BUILD_PR_26171_006-message-emotion-profile-management.md (added, +83/-0) -+- docs_build/pr/BUILD_PR_26171_008-message-tts-profile-foundation.md (added, +98/-0) -+- docs_build/pr/BUILD_PR_26171_010-message-speech-preview.md (added, +84/-0) -+- docs_build/pr/BUILD_PR_26171_012-message-voice-provider-adapters.md (added, +86/-0) -+- docs_build/pr/BUILD_PR_26171_014-runtime-message-playback-foundation.md (added, +84/-0) -+- docs_build/pr/BUILD_PR_26171_016-midi-studio-roadmap-foundation.md (added, +74/-0) -+- src/dev-runtime/messages/messages-sqlite-service.mjs (updated, +54/-4) -+- tests/playwright/tools/MessagesTool.spec.mjs (updated, +37/-0) -+- toolbox/messages/index.html (updated, +5/-4) -+- toolbox/messages/messages.js (updated, +7/-1) -+ -+## 7. Code File List Only -+ -+- src/dev-runtime/messages/messages-sqlite-service.mjs (updated, +54/-4) -+- tests/playwright/tools/MessagesTool.spec.mjs (updated, +37/-0) -+- toolbox/messages/index.html (updated, +5/-4) -+- toolbox/messages/messages.js (updated, +7/-1) -+ -+## 8. Diff Summary By File -+ -+| File | Change | Size | Summary | -+|---|---|---:|---| -+| docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-manual-validation.md | added | +11/-0 | added report artifact (11+/0-). | -+| docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-validation.txt | added | +30/-0 | added report artifact (30+/0-). | -+| docs_build/dev/reports/PR_26171_006-message-emotion-profile-management.md | added | +53/-0 | added report artifact (53+/0-). | -+| docs_build/dev/reports/codex_changed_files.txt | updated | +8/-9 | updated report artifact (8+/9-). | -+| docs_build/dev/reports/codex_review.diff | updated | +352/-305 | updated report artifact (352+/305-). | -+| docs_build/pr/BUILD_PR_26171_006-message-emotion-profile-management.md | added | +83/-0 | added file (83+/0-); sample added: # BUILD PR_26171_006-message-emotion-profile-management. | -+| docs_build/pr/BUILD_PR_26171_008-message-tts-profile-foundation.md | added | +98/-0 | added file (98+/0-); sample added: # BUILD PR_26171_008-message-tts-profile-foundation. | -+| docs_build/pr/BUILD_PR_26171_010-message-speech-preview.md | added | +84/-0 | added file (84+/0-); sample added: # BUILD PR_26171_010-message-speech-preview. | -+| docs_build/pr/BUILD_PR_26171_012-message-voice-provider-adapters.md | added | +86/-0 | added file (86+/0-); sample added: # BUILD PR_26171_012-message-voice-provider-adapters. | -+| docs_build/pr/BUILD_PR_26171_014-runtime-message-playback-foundation.md | added | +84/-0 | added file (84+/0-); sample added: # BUILD PR_26171_014-runtime-message-playback-foundation. | -+| docs_build/pr/BUILD_PR_26171_016-midi-studio-roadmap-foundation.md | added | +74/-0 | added file (74+/0-); sample added: # BUILD PR_26171_016-midi-studio-roadmap-foundation. | -+| src/dev-runtime/messages/messages-sqlite-service.mjs | updated | +54/-4 | updated JavaScript module (54+/4-). | -+| tests/playwright/tools/MessagesTool.spec.mjs | updated | +37/-0 | updated JavaScript module (37+/0-). | -+| toolbox/messages/index.html | updated | +5/-4 | updated HTML page structure (5+/4-). | -+| toolbox/messages/messages.js | updated | +7/-1 | updated JavaScript module (7+/1-). | -+ -+## Changed Code File Details -+ -+| Relative Path | Added/Updated/Deleted | Concise Change Summary | -+|---|---|---| -+| src/dev-runtime/messages/messages-sqlite-service.mjs | updated | updated JavaScript module (54+/4-). | -+| tests/playwright/tools/MessagesTool.spec.mjs | updated | updated JavaScript module (37+/0-). | -+| toolbox/messages/index.html | updated | updated HTML page structure (5+/4-). | -+| toolbox/messages/messages.js | updated | updated JavaScript module (7+/1-). | -+ -+## 9. Purpose -+ -+No PR body provided. -+ -+## 10. Risks -+ -+Medium/high: 4 code file(s) changed, including tests/playwright/tools/MessagesTool.spec.mjs. Requires targeted validation review before merge. -+ -+## 11. Dependencies -+ -+Bravo Messages/Emotion workstream; owner/team decision required because current dependency state is not fully inferable from the PR title alone. -+ -+## 12. Recommendation -+ -+Owner Decision Required. Review Bravo ownership, branch freshness, and current Messages/Emotion direction before merge/closure. -diff --git a/docs_build/dev/reports/PR_REVIEW_050.md b/docs_build/dev/reports/PR_REVIEW_050.md -new file mode 100644 -index 000000000..d1521b998 ---- /dev/null -+++ b/docs_build/dev/reports/PR_REVIEW_050.md -@@ -0,0 +1,72 @@ -+# PR Review Packet #050 -+ -+## 1. Title -+ -+PR_26171_GAMMA_028-final-sqlite-clean-status-report -+ -+## 2. Team -+ -+Team Golf (historical Gamma lane) -+ -+## 3. Branch -+ -+`pr/26171-GAMMA-028-final-sqlite-clean-status-report` -+ -+## 4. Created Date -+ -+2026-06-21T16:18:04Z -+ -+## 5. Updated Date -+ -+2026-06-21T16:18:04Z -+ -+## Status And Age -+ -+- Status: Draft -+- Age: 2d 11h -+- Author: ToolboxAid -+- URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/50 -+ -+## 6. Full Changed File List -+ -+- docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report-instruction-compliance-checklist.md (added, +18/-0) -+- docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report-manual-validation-notes.md (added, +12/-0) -+- docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report.md (added, +69/-0) -+- docs_build/dev/reports/codex_changed_files.txt (updated, +4/-5) -+- docs_build/dev/reports/codex_review.diff (updated, +104/-110) -+ -+## 7. Code File List Only -+ -+- None -+ -+## 8. Diff Summary By File -+ -+| File | Change | Size | Summary | -+|---|---|---:|---| -+| docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report-instruction-compliance-checklist.md | added | +18/-0 | added report artifact (18+/0-). | -+| docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report-manual-validation-notes.md | added | +12/-0 | added report artifact (12+/0-). | -+| docs_build/dev/reports/PR_26171_GAMMA_028-final-sqlite-clean-status-report.md | added | +69/-0 | added report artifact (69+/0-). | -+| docs_build/dev/reports/codex_changed_files.txt | updated | +4/-5 | updated report artifact (4+/5-). | -+| docs_build/dev/reports/codex_review.diff | updated | +104/-110 | updated report artifact (104+/110-). | -+ -+## Changed Code File Details -+ -+| Relative Path | Added/Updated/Deleted | Concise Change Summary | -+|---|---|---| -+| None | none | No changed code files. | -+ -+## 9. Purpose -+ -+Captures the final SQLite inventory after PR026 and PR027. -+ -+## 10. Risks -+ -+Low runtime risk because changed files are reports/governance/docs only; review risk is traceability and owner approval sequencing. -+ -+## 11. Dependencies -+ -+Historical Gamma/SQLite chain. Team Gamma is retired; Team Golf is the replacement active ownership lane. Review with #30 and #43 context before acting on #50. -+ -+## 12. Recommendation -+ -+Review First. Likely final historical Gamma/SQLite status packet, now routed to Team Golf for active ownership decisions. -diff --git a/docs_build/dev/reports/PR_REVIEW_051.md b/docs_build/dev/reports/PR_REVIEW_051.md -new file mode 100644 -index 000000000..d4ae9373d ---- /dev/null -+++ b/docs_build/dev/reports/PR_REVIEW_051.md -@@ -0,0 +1,86 @@ -+# PR Review Packet #051 -+ -+## 1. Title -+ -+PR_26172_MASTER_001-project-instructions-readme-and-root -+ -+## 2. Team -+ -+Team OWNER -+ -+## 3. Branch -+ -+`pr/26172-MASTER-001-project-instructions-readme-and-root` -+ -+## 4. Created Date -+ -+2026-06-21T17:26:20Z -+ -+## 5. Updated Date -+ -+2026-06-21T17:26:20Z -+ -+## Status And Age -+ -+- Status: Draft -+- Age: 2d 10h -+- Author: ToolboxAid -+- URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/51 -+ -+## 6. Full Changed File List -+ -+- docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md (added, +34/-0) -+- docs_build/dev/ProjectInstructions/README.txt (added, +28/-0) -+- docs_build/dev/ProjectInstructions/addendums/.gitkeep (added, +1/-0) -+- docs_build/dev/ProjectInstructions/archive/history/.gitkeep (added, +1/-0) -+- docs_build/dev/ProjectInstructions/backlog/.gitkeep (added, +1/-0) -+- docs_build/dev/ProjectInstructions/deprecation/.gitkeep (added, +1/-0) -+- docs_build/dev/ProjectInstructions/team_assignments/.gitkeep (added, +1/-0) -+- docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root-instruction-compliance-checklist.md (added, +11/-0) -+- docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root-manual-validation-notes.md (added, +9/-0) -+- docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root.md (added, +22/-0) -+- docs_build/dev/reports/codex_changed_files.txt (updated, +10/-4) -+- docs_build/dev/reports/codex_review.diff (updated, +17/-134) -+ -+## 7. Code File List Only -+ -+- None -+ -+## 8. Diff Summary By File -+ -+| File | Change | Size | Summary | -+|---|---|---:|---| -+| docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md | added | +34/-0 | added Project Instructions governance text (34+/0-). | -+| docs_build/dev/ProjectInstructions/README.txt | added | +28/-0 | added Project Instructions governance text (28+/0-). | -+| docs_build/dev/ProjectInstructions/addendums/.gitkeep | added | +1/-0 | added Project Instructions governance text (1+/0-). | -+| docs_build/dev/ProjectInstructions/archive/history/.gitkeep | added | +1/-0 | added Project Instructions governance text (1+/0-). | -+| docs_build/dev/ProjectInstructions/backlog/.gitkeep | added | +1/-0 | added Project Instructions governance text (1+/0-). | -+| docs_build/dev/ProjectInstructions/deprecation/.gitkeep | added | +1/-0 | added Project Instructions governance text (1+/0-). | -+| docs_build/dev/ProjectInstructions/team_assignments/.gitkeep | added | +1/-0 | added Project Instructions governance text (1+/0-). | -+| docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root-instruction-compliance-checklist.md | added | +11/-0 | added report artifact (11+/0-). | -+| docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root-manual-validation-notes.md | added | +9/-0 | added report artifact (9+/0-). | -+| docs_build/dev/reports/PR_26172_MASTER_001-project-instructions-readme-and-root.md | added | +22/-0 | added report artifact (22+/0-). | -+| docs_build/dev/reports/codex_changed_files.txt | updated | +10/-4 | updated report artifact (10+/4-). | -+| docs_build/dev/reports/codex_review.diff | updated | +17/-134 | updated report artifact (17+/134-). | -+ -+## Changed Code File Details -+ -+| Relative Path | Added/Updated/Deleted | Concise Change Summary | -+|---|---|---| -+| None | none | No changed code files. | -+ -+## 9. Purpose -+ -+Adds the new `docs_build/dev/ProjectInstructions/` operating-system root. -+ -+## 10. Risks -+ -+Low runtime risk because changed files are reports/governance/docs only; review risk is traceability and owner approval sequencing. -+ -+## 11. Dependencies -+ -+ProjectInstructions governance chain; history-sensitive and requires OWNER approval before merge or closure. -+ -+## 12. Recommendation -+ -+Owner Decision Required. Historical governance bootstrap overlaps current ProjectInstructions state and must not be merged or archived without OWNER decision. -diff --git a/docs_build/dev/reports/PR_REVIEW_118.md b/docs_build/dev/reports/PR_REVIEW_118.md -new file mode 100644 -index 000000000..d7756231b ---- /dev/null -+++ b/docs_build/dev/reports/PR_REVIEW_118.md -@@ -0,0 +1,76 @@ -+# PR Review Packet #118 -+ -+## 1. Title -+ -+PR_26174_ALFA_EOD-final-closeout -+ -+## 2. Team -+ -+Team Alfa -+ -+## 3. Branch -+ -+`pr/26174-ALFA-EOD-final-closeout` -+ -+## 4. Created Date -+ -+2026-06-23T18:08:07Z -+ -+## 5. Updated Date -+ -+2026-06-23T18:10:12Z -+ -+## Status And Age -+ -+- Status: Draft -+- Age: 9h -+- Author: ToolboxAid -+- URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/118 -+ -+## 6. Full Changed File List -+ -+- docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_branch-validation.md (added, +19/-0) -+- docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_manual-validation-notes.md (added, +8/-0) -+- docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_report.md (added, +93/-0) -+- docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_requirements-checklist.md (added, +16/-0) -+- docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_validation-lane.md (added, +17/-0) -+- docs_build/dev/reports/codex_changed_files.txt (updated, +5/-5) -+- docs_build/dev/reports/codex_review.diff (updated, +158/-132) -+ -+## 7. Code File List Only -+ -+- None -+ -+## 8. Diff Summary By File -+ -+| File | Change | Size | Summary | -+|---|---|---:|---| -+| docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_branch-validation.md | added | +19/-0 | added report artifact (19+/0-). | -+| docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_manual-validation-notes.md | added | +8/-0 | added report artifact (8+/0-). | -+| docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_report.md | added | +93/-0 | added report artifact (93+/0-). | -+| docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_requirements-checklist.md | added | +16/-0 | added report artifact (16+/0-). | -+| docs_build/dev/reports/PR_26174_ALFA_EOD-final-closeout_validation-lane.md | added | +17/-0 | added report artifact (17+/0-). | -+| docs_build/dev/reports/codex_changed_files.txt | updated | +5/-5 | updated report artifact (5+/5-). | -+| docs_build/dev/reports/codex_review.diff | updated | +158/-132 | updated report artifact (158+/132-). | -+ -+## Changed Code File Details -+ -+| Relative Path | Added/Updated/Deleted | Concise Change Summary | -+|---|---|---| -+| None | none | No changed code files. | -+ -+## 9. Purpose -+ -+Report-only final Team Alfa closeout for owner merge review. -+ -+## 10. Risks -+ -+Low runtime risk because changed files are reports/governance/docs only; review risk is traceability and owner approval sequencing. -+ -+## 11. Dependencies -+ -+Part of the PR_26174 Alfa stack; owner should review stack order before merge. PR #118 appears to be a final closeout report dependent on #117 and the earlier Alfa stack. -+ -+## 12. Recommendation -+ -+Review First. Treat as owner closeout evidence for the Alfa stack; do not merge until stack/order review is complete. diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt -index ded176aa5..4aa64ab71 100644 +index 4aa64ab71..9856718b2 100644 --- a/docs_build/dev/reports/codex_changed_files.txt +++ b/docs_build/dev/reports/codex_changed_files.txt -@@ -0,0 +1,2 @@ -+docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md -+docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md -@@ -2,2 +4,12 @@ docs_build/dev/ProjectInstructions/addendums/multi_team.md --docs_build/dev/reports/PR_26175_OWNER_050-eod-merge-push-cleanup-gate.md --docs_build/dev/reports/codex_review.diff -+docs_build/dev/ProjectInstructions/addendums/pr_workflow.md -+docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md -+docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md -+docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md -+docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md -+docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md -+docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md -+docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md -+docs_build/dev/reports/PR_REVIEW_003.md -+docs_build/dev/reports/PR_REVIEW_050.md -+docs_build/dev/reports/PR_REVIEW_051.md -+docs_build/dev/reports/PR_REVIEW_118.md -@@ -4,0 +17 @@ docs_build/dev/reports/codex_changed_files.txt -+docs_build/dev/reports/codex_review.diff +@@ -1,17 +1,5 @@ +-docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md +-docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md +-docs_build/dev/ProjectInstructions/addendums/multi_team.md +-docs_build/dev/ProjectInstructions/addendums/pr_workflow.md +-docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md +-docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md +-docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md +-docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md +-docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md +-docs_build/dev/ProjectInstructions/team_assignments/team_ownership.md +-docs_build/dev/reports/PR_26175_OWNER_046-pr-targeted-review-packets.md +-docs_build/dev/reports/PR_REVIEW_003.md +-docs_build/dev/reports/PR_REVIEW_050.md +-docs_build/dev/reports/PR_REVIEW_051.md +-docs_build/dev/reports/PR_REVIEW_118.md ++src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js ++tests/playwright/tools/GameJourneyTool.spec.mjs ++docs_build/dev/reports/PR_26175_ALFA_015-alfa-foundation-consolidation.md + docs_build/dev/reports/codex_changed_files.txt + docs_build/dev/reports/codex_review.diff +diff --git a/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js b/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js +index db24253af..73b409c42 100644 +--- a/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js ++++ b/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js +@@ -1080,7 +1080,7 @@ export function createGameJourneyMockRepository(options = {}) { + linkedRecordType: RECOMMENDED_TARGET_LINKED_RECORD_TYPE, + linkedRecordId: target.key, + indent: 0, +- order: getItemsForNote(RECOMMENDED_TARGET_NOTE_KEY).length + 1, ++ order: getItemsForNote(noteKey).length + 1, + createdAt: timestampValue, + updatedAt: timestampValue, + }; +diff --git a/tests/playwright/tools/GameJourneyTool.spec.mjs b/tests/playwright/tools/GameJourneyTool.spec.mjs +index 43d9fd733..38abd59c3 100644 +--- a/tests/playwright/tools/GameJourneyTool.spec.mjs ++++ b/tests/playwright/tools/GameJourneyTool.spec.mjs +@@ -395,7 +395,9 @@ test("Game Journey progress dashboard summarizes completion metrics", async ({ p + ); + expect(objectsBucketNote?.key).toMatch(ULID_PATTERN); + expect(persistedTarget).toMatchObject({ ++ gameKey: GAME_JOURNEY_KEYS.game, + noteKey: objectsBucketNote.key, ++ order: 2, + title: "Recommended target: Hero", + }); + expect(JSON.parse(persistedTarget.userDetails)).toMatchObject({ suggestedCount: 2 }); diff --git a/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js b/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js index db24253af..73b409c42 100644 --- a/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js +++ b/src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js @@ -1080,7 +1080,7 @@ export function createGameJourneyMockRepository(options = {}) { linkedRecordType: RECOMMENDED_TARGET_LINKED_RECORD_TYPE, linkedRecordId: target.key, indent: 0, - order: getItemsForNote(RECOMMENDED_TARGET_NOTE_KEY).length + 1, + order: getItemsForNote(noteKey).length + 1, createdAt: timestampValue, updatedAt: timestampValue, }; diff --git a/tests/playwright/tools/GameJourneyTool.spec.mjs b/tests/playwright/tools/GameJourneyTool.spec.mjs index 43d9fd733..38abd59c3 100644 --- a/tests/playwright/tools/GameJourneyTool.spec.mjs +++ b/tests/playwright/tools/GameJourneyTool.spec.mjs @@ -395,7 +395,9 @@ test("Game Journey progress dashboard summarizes completion metrics", async ({ p ); expect(objectsBucketNote?.key).toMatch(ULID_PATTERN); expect(persistedTarget).toMatchObject({ + gameKey: GAME_JOURNEY_KEYS.game, noteKey: objectsBucketNote.key, + order: 2, title: "Recommended target: Hero", }); expect(JSON.parse(persistedTarget.userDetails)).toMatchObject({ suggestedCount: 2 });