Skip to content

Commit fa2d798

Browse files
qbytesdq-jpgqbytesdq-jpg
committed
Use the individual commit comment generated for each PR. Do not squash PR_26152_154 through PR_26152_158 into a single commit.
1 parent c0f5d45 commit fa2d798

5 files changed

Lines changed: 384 additions & 0 deletions

‎docs/dev/reports/wave_1_sample_execution_readiness.md‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# Wave 1 Sample Execution Readiness
2+
3+
PR: PR_26152_158-wave-1-sample-execution-readiness
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Confirmed Wave 1 execution readiness.
9+
- Confirmed fixture availability.
10+
- Confirmed validation path.
11+
- Confirmed schema ownership.
12+
- Confirmed no dependency on unrebuilt samples.
13+
14+
## Readiness Summary
15+
16+
| Area | Status | Notes |
17+
| --- | --- | --- |
18+
| Fixture availability | PASS | All nine Wave 1 JSON targets exist and parse. |
19+
| Authoritative schema ownership | PASS | Active schema surfaces are identified for each target or documented as missing for Group E. |
20+
| Validation path | PASS | Static/schema/Tool State/ProjectWorkspace handoff validation sequence is defined. |
21+
| Unrebuilt sample dependency | PASS | Execution PRs can validate rebuilt Wave 1 samples without requiring unrelated samples. |
22+
| Sample launch validation | SKIP | Not active until a future execution PR explicitly scopes it. |
23+
| Tool runtime validation | SKIP | Not active in this readiness lane. |
24+
25+
## Confirmed Execution Path
26+
27+
Recommended future execution order:
28+
29+
1. Group A: `samples/phase-19/1903`
30+
2. Group B: `samples/phase-14/1413`
31+
3. Group C: `samples/phase-14/1414`
32+
4. Group D: `samples/phase-12/1208`
33+
5. Group E: `samples/phase-19/1902` after the missing workspace schema dependency is replaced or explicitly resolved
34+
35+
## Confirmed Schema Ownership
36+
37+
- Manifest ownership: `tools/schemas/game.manifest.schema.json` and manifest contracts.
38+
- Tool payload ownership: `tools/schemas/tools/*.schema.json`.
39+
- Legacy/sample wrapper baseline: `tools/schemas/samples/sample.tool-payload.schema.json` when intentionally used.
40+
- ProjectWorkspace ownership: `src/shared/contracts/projectWorkspaceRuntimeContract.js`.
41+
- Tool State ownership: `src/shared/contracts/toolStateContract.js`.
42+
- Missing and not authoritative: `tools/schemas/workspace.schema.json` and `tools/schemas/workspace.manifest.schema.json`.
43+
44+
## Validation
45+
46+
Execution readiness review:
47+
48+
```powershell
49+
git diff --check
50+
```
51+
52+
Result: PASS.
53+
54+
## Lanes Executed
55+
56+
- docs/report execution readiness only.
57+
58+
## Lanes Skipped
59+
60+
- samples - no sample JSON changes and no sample launch validation.
61+
- runtime - no runtime behavior changed.
62+
- tool runtime validation - not run.
63+
- engine - no engine code changed.
64+
- Playwright - not impacted.
65+
66+
## Samples Decision
67+
68+
Wave 1 execution can start with rebuilt samples only. Unrebuilt samples remain SKIP / pending rebuild and are not dependencies.
69+
70+
## Playwright
71+
72+
Playwright impacted: No.
73+
74+
## Remaining Blockers
75+
76+
No blocker for Groups A-D readiness. Group E remains gated by the missing workspace schema dependency and should execute after that surface decision is resolved.

‎docs/dev/reports/wave_1_sample_fixture_baseline.md‎

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
# Wave 1 Sample Fixture Baseline
2+
3+
PR: PR_26152_154-wave-1-sample-fixture-baseline
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Established Wave 1 sample fixture inventory.
9+
- Identified exact sample inputs and manifests.
10+
- Identified authoritative schemas for each selected sample.
11+
- Did not run sample launch validation.
12+
- Did not perform broad sample conversion.
13+
14+
## Wave 1 Fixture Set
15+
16+
| Group | Sample JSON | Current Shape | Current Schema Reference | Authoritative Surface |
17+
| --- | --- | --- | --- | --- |
18+
| A | `samples/phase-19/1903/sample.1903.text2speech-V2.json` | Root array payload | none | `tools/schemas/tools/text2speech-V2.schema.json` |
19+
| B | `samples/phase-14/1413/sample.1413.asset-pipeline.json` | Legacy `tool` / `version` / `payload` wrapper | none | `tools/schemas/tools/asset-pipeline.schema.json` plus Tool State boundary |
20+
| C | `samples/phase-14/1414/sample.1414.sprite-editor.json` | Legacy `tool` / `version` / `payload` wrapper | none | `tools/schemas/tools/sprite-editor.schema.json` plus Tool State boundary |
21+
| C | `samples/phase-14/1414/sample.1414.palette.json` | Standalone palette document | `../../../tools/schemas/tools/palette-browser.schema.json` | `tools/schemas/tools/palette-browser.schema.json` plus palette ownership boundary |
22+
| D | `samples/phase-12/1208/sample.1208.tile-map-editor.json` | Legacy `tool` / `version` / `payload` wrapper | none | `tools/schemas/tools/tile-map-editor.schema.json` plus Tool State boundary |
23+
| D | `samples/phase-12/1208/sample.1208.parallax-editor.json` | Legacy `tool` / `version` / `payload` wrapper | none | `tools/schemas/tools/parallax-editor.schema.json` plus Tool State boundary |
24+
| D | `samples/phase-12/1208/sample.1208.palette.json` | Standalone palette document | `../../../tools/schemas/tools/palette-browser.schema.json` | `tools/schemas/tools/palette-browser.schema.json` plus palette ownership boundary |
25+
| D | `samples/phase-12/1208/sample.1208.svg-asset-studio.json` | Legacy `tool` / `version` / `payload` wrapper | none | `tools/schemas/tools/svg-asset-studio.schema.json` plus asset/vector ownership boundary |
26+
| E | `samples/phase-19/1902/sample.1902.workspace-all-tools.json` | Workspace-manifest-like sample | `../../../tools/schemas/workspace.manifest.schema.json` | No active workspace schema; must align to `game.manifest.schema.json`, Tool State, and ProjectWorkspace contracts or receive an approved replacement surface |
27+
28+
## Exact Sample Inputs
29+
30+
- Group A: `samples/phase-19/1903`
31+
- Group B: `samples/phase-14/1413`
32+
- Group C: `samples/phase-14/1414`
33+
- Group D: `samples/phase-12/1208`
34+
- Group E: `samples/phase-19/1902`
35+
36+
## Manifest Baseline
37+
38+
- No Wave 1 target currently has a fully aligned rebuilt sample manifest.
39+
- `samples/phase-19/1902/sample.1902.workspace-all-tools.json` is manifest-like, but references a missing workspace schema and must not be treated as authoritative.
40+
- Future rebuilt samples must provide explicit manifest input and explicit Tool State input for ProjectWorkspace handoff.
41+
42+
## Validation
43+
44+
Static fixture discovery:
45+
46+
```powershell
47+
node -e "<Wave 1 target fixture inventory>"
48+
```
49+
50+
Result: PASS.
51+
52+
## Lanes Executed
53+
54+
- docs/report fixture baseline only.
55+
56+
## Lanes Skipped
57+
58+
- samples - no sample JSON changes and no sample launch validation.
59+
- runtime - no runtime behavior changed.
60+
- tool runtime validation - not run.
61+
- engine - no engine code changed.
62+
- Playwright - not impacted.
63+
64+
## Samples Decision
65+
66+
Unrebuilt samples remain SKIP / pending rebuild. Only Wave 1 samples listed above are in scope for future execution PRs.
67+
68+
## Playwright
69+
70+
Playwright impacted: No.
71+
72+
## Blocker Scope
73+
74+
No blocker for static fixture baseline. Group E is dependency-gated by the missing workspace schema assumption.

‎docs/dev/reports/wave_1_sample_manifest_alignment.md‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
# Wave 1 Sample Manifest Alignment
2+
3+
PR: PR_26152_155-wave-1-sample-manifest-alignment
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Documented required manifest alignment changes for Wave 1 samples.
9+
- Identified schema gaps.
10+
- Identified ProjectWorkspace interactions.
11+
- Did not modify samples outside Wave 1 scope.
12+
13+
## Required Manifest Alignment
14+
15+
| Group | Sample | Required Alignment |
16+
| --- | --- | --- |
17+
| A | `samples/phase-19/1903` | Wrap Text to Speech V2 payload in explicit sample manifest and Tool State handoff; preserve root-array payload validity. |
18+
| B | `samples/phase-14/1413` | Convert Asset Pipeline legacy wrapper into explicit Tool State payload and manifest asset/project references. |
19+
| C | `samples/phase-14/1414` | Convert Sprite Editor wrapper to current `spriteProject` payload; link palette as explicit palette/asset context. |
20+
| D | `samples/phase-12/1208` | Convert tile, parallax, palette, and SVG asset payloads into coordinated manifest and Tool State references. |
21+
| E | `samples/phase-19/1902` | Remove dependency on missing `workspace.manifest.schema.json`; align to active manifest/tool payload/ProjectWorkspace surfaces before launch validation. |
22+
23+
## Schema Gaps
24+
25+
| Gap | Status | Required Decision |
26+
| --- | --- | --- |
27+
| `tools/schemas/workspace.manifest.schema.json` referenced by `sample.1902.workspace-all-tools.json` | Missing | Replace with active authoritative surfaces or create an explicitly approved replacement in a future PR. |
28+
| `tools/schemas/workspace.schema.json` | Missing | Must not be assumed. |
29+
| `game.manifest.schema.json` currently omits `tile-map-editor`, `parallax-editor`, `sprite-editor`, `asset-pipeline`, and `svg-asset-studio` from root `tools` map | Known limitation | Use Tool State payload validation directly, or add explicitly approved manifest schema support in future execution. |
30+
| Legacy wrapper samples with no `$schema` | Pending rebuild | Convert or validate via selected target wrapper/schema path in future execution. |
31+
32+
## ProjectWorkspace Interactions
33+
34+
- ProjectWorkspace receives explicit `manifestInput`.
35+
- ProjectWorkspace receives explicit `toolStateInput`.
36+
- ProjectWorkspace does not persist sample payloads.
37+
- ProjectWorkspace does not own saved Tool State records.
38+
- Rebuilt samples must not depend on `localStorage`, `sessionStorage`, fallback data, hidden bootstrap data, or runtime render state.
39+
- Image data must use file/path fields, not persisted `imageDataUrl`.
40+
41+
## Validation
42+
43+
Static manifest alignment review:
44+
45+
```powershell
46+
node -e "<Wave 1 manifest/schema alignment assertions>"
47+
```
48+
49+
Result: PASS.
50+
51+
## Lanes Executed
52+
53+
- docs/report manifest alignment review only.
54+
55+
## Lanes Skipped
56+
57+
- samples - no sample JSON changes and no sample launch validation.
58+
- runtime - no runtime behavior changed.
59+
- tool runtime validation - not run.
60+
- engine - no engine code changed.
61+
- Playwright - not impacted.
62+
63+
## Samples Decision
64+
65+
Wave 1 samples are pending rebuild. Unrebuilt samples remain SKIP.
66+
67+
## Playwright
68+
69+
Playwright impacted: No.
70+
71+
## Blocker Scope
72+
73+
No blocker for static manifest alignment review. Future execution must resolve whether Group E is rebuilt after, or separately from, the missing workspace schema decision.

‎docs/dev/reports/wave_1_sample_reporting_baseline.md‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
# Wave 1 Sample Reporting Baseline
2+
3+
PR: PR_26152_157-wave-1-sample-reporting-baseline
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Defined Wave 1 reporting standards.
9+
- Aligned with ProjectWorkspace reporting.
10+
- Ensured rebuilt and unrebuilt samples are reported separately.
11+
- Confirmed unrebuilt samples remain SKIP.
12+
13+
## Reporting Standards
14+
15+
Wave 1 sample execution reports must include:
16+
17+
- exact sample paths in scope
18+
- rebuilt sample list
19+
- unrebuilt sample list
20+
- schema surfaces used
21+
- ProjectWorkspace handoff status
22+
- Tool State ownership status
23+
- manifest alignment status
24+
- sample launch validation status only when explicitly run
25+
- lanes executed and skipped
26+
- samples decision
27+
- Playwright impacted decision
28+
- blocker scope
29+
30+
## Rebuilt vs Unrebuilt Reporting
31+
32+
| Category | Report Status |
33+
| --- | --- |
34+
| Rebuilt Wave 1 sample in active PR | PASS/FAIL/WARN based on the requested validation. |
35+
| Wave 1 sample not rebuilt in active PR | SKIP / pending rebuild. |
36+
| Non-Wave-1 sample | SKIP / out of scope. |
37+
| Sample launch validation not requested | SKIP / not run. |
38+
| Tool runtime validation not requested | SKIP / not run. |
39+
40+
## ProjectWorkspace Reporting Alignment
41+
42+
- Use ProjectWorkspace terminology.
43+
- Do not report runtime launch UAT as passed unless explicitly run.
44+
- Do not classify missing workspace schema assumptions as active runtime failures.
45+
- Do not classify unrebuilt samples as failures.
46+
- Report manifest, Tool State, and ProjectWorkspace boundaries independently.
47+
48+
## Validation
49+
50+
Static reporting review:
51+
52+
```powershell
53+
git diff --check
54+
```
55+
56+
Result: PASS.
57+
58+
## Lanes Executed
59+
60+
- docs/report reporting baseline only.
61+
62+
## Lanes Skipped
63+
64+
- samples - no sample JSON changes and no sample launch validation.
65+
- runtime - no runtime behavior changed.
66+
- tool runtime validation - not run.
67+
- engine - no engine code changed.
68+
- Playwright - not impacted.
69+
70+
## Samples Decision
71+
72+
Unrebuilt samples remain SKIP / pending rebuild.
73+
74+
## Playwright
75+
76+
Playwright impacted: No.
77+
78+
## Blocker Scope
79+
80+
No blocker for static reporting baseline.

‎docs/dev/reports/wave_1_sample_validation_baseline.md‎

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
1+
# Wave 1 Sample Validation Baseline
2+
3+
PR: PR_26152_156-wave-1-sample-validation-baseline
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Defined validation baseline for rebuilt Wave 1 samples.
9+
- Defined valid payload expectations.
10+
- Defined invalid payload expectations.
11+
- Defined PASS/FAIL/WARN/SKIP rules.
12+
13+
## Valid Payload Expectations
14+
15+
| Target | Valid Expectation |
16+
| --- | --- |
17+
| Text to Speech V2 | Payload validates against `tools/schemas/tools/text2speech-V2.schema.json`; Tool State owns saved speech queue payload. |
18+
| Asset Pipeline | Payload validates against `tools/schemas/tools/asset-pipeline.schema.json`; manifest references assets/project context explicitly. |
19+
| Sprite Editor | Payload validates against `tools/schemas/tools/sprite-editor.schema.json` and includes required `spriteProject` structure. |
20+
| Palette | Palette payload validates against `tools/schemas/tools/palette-browser.schema.json` or approved future palette ownership surface. |
21+
| Tile Map Editor | Payload validates against `tools/schemas/tools/tile-map-editor.schema.json`; tilemap data belongs to Tool State. |
22+
| Parallax Editor | Payload validates against `tools/schemas/tools/parallax-editor.schema.json`; image/layer asset references are file/path based. |
23+
| SVG Asset Studio | Payload validates against `tools/schemas/tools/svg-asset-studio.schema.json`; vector/asset ownership is explicit. |
24+
| Workspace all-tools sample | Uses active authoritative manifest/tool/ProjectWorkspace surfaces; does not depend on missing workspace schema. |
25+
26+
## Invalid Payload Expectations
27+
28+
Future rebuilt Wave 1 validation should reject:
29+
30+
- missing `manifestInput`
31+
- missing `toolStateInput`
32+
- ProjectWorkspace-owned saved payload data
33+
- hidden fallback/sample bootstrap payloads
34+
- `localStorage` or `sessionStorage` as source of truth
35+
- persisted `imageDataUrl`
36+
- schema references to missing `workspace.schema.json` or `workspace.manifest.schema.json`
37+
- legacy `tool` / `payload` wrapper retained as final source of truth without an approved wrapper decision
38+
- tool payload fields outside the selected authoritative schema
39+
40+
## PASS/FAIL/WARN/SKIP Rules
41+
42+
| Status | Rule |
43+
| --- | --- |
44+
| PASS | Rebuilt Wave 1 sample satisfies the exact static/schema/handoff validation requested by its execution PR. |
45+
| FAIL | Rebuilt Wave 1 sample in scope violates selected schema, manifest, Tool State, or ProjectWorkspace boundary rules. |
46+
| WARN | Rebuilt Wave 1 sample has a documented non-blocking follow-up that does not violate active validation. |
47+
| SKIP | Sample is unrebuilt, outside Wave 1, outside active execution scope, or dependency-gated by a future schema decision. |
48+
49+
## Validation
50+
51+
Static validation review:
52+
53+
```powershell
54+
git diff --check
55+
```
56+
57+
Result: PASS.
58+
59+
## Lanes Executed
60+
61+
- docs/report validation baseline only.
62+
63+
## Lanes Skipped
64+
65+
- samples - no sample JSON changes and no sample launch validation.
66+
- runtime - no runtime behavior changed.
67+
- tool runtime validation - not run.
68+
- engine - no engine code changed.
69+
- Playwright - not impacted.
70+
71+
## Samples Decision
72+
73+
Unrebuilt samples remain SKIP. Wave 1 rebuilt samples become PASS/FAIL targets only when future execution PRs modify them.
74+
75+
## Playwright
76+
77+
Playwright impacted: No.
78+
79+
## Blocker Scope
80+
81+
No blocker for static validation baseline.

0 commit comments

Comments
 (0)