Close out root migration structure and stale path cleanup - PR_26154_017-root-migration-closeout-bundle

Author: qbytesdq-jpg

docs_build/dev/codex_commands.md

@@ -2,22 +2,25 @@
 
 Task:
 
-- `PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup`
+- `PR_26154_017-root-migration-closeout-bundle`
 
 Commands run:
 
 - `Get-Content .codex/skills/repo-build/SKILL.md`
 - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
 - `git status --short --untracked-files=all`
-- Targeted `Get-ChildItem` and `Get-Content` inspection for:
+- Targeted `Get-ChildItem`, `Get-Content`, and `Test-Path` inspection for:
+  - `GameFoundryStudio/`
   - `assets/theme/v1/`
-  - `assets/theme/v2/images/`
-  - `assets/theme/v2/css/theme/v2/`
   - `src/engine/theme/`
-  - `src/engine/ui/toolboxaid-header.html`
-  - `tools/shared/tooling/CapturePreviewRuntime.js`
-  - `tools/dev/checkStyleSystemGuard.mjs`
-  - `tools/dev/checkSharedExtractionGuard.baseline.json`
+  - `samples/`
+  - `favicon.ico`
+  - `favicon.svg`
+  - `LICENSE`
+  - `docs/`
+  - `docs_build/`
+  - `games/index.html`
+  - `tools/tools-page-accordions.js`
 - Targeted ownership inventory for:
   - `tools/`
   - `old-tools/`
@@ -31,32 +34,28 @@ Commands run:
   - `src/engine/theme/`
   - `assets/theme/v1/`
   - `favicon.ico`
-- Moved `assets/theme/v1/images/toolboxaid-header.png` to `assets/theme/v2/images/toolboxaid-header.png`.
-- Updated `src/engine/ui/toolboxaid-header.html`.
-- Updated `tools/shared/tooling/CapturePreviewRuntime.js`.
-- Updated `tools/dev/checkStyleSystemGuard.mjs`.
-- Updated `tools/dev/checkSharedExtractionGuard.baseline.json`.
-- Deleted `assets/theme/v1/`.
-- Deleted `src/engine/theme/`.
-- `node tools/dev/checkStyleSystemGuard.mjs`
-- `node --check tools/shared/tooling/CapturePreviewRuntime.js`
-- `node --check tools/dev/checkStyleSystemGuard.mjs`
-- Node static validation for changed HTML, JS, CSS, JSON, and Markdown files.
+  - deprecated root `samples/`
+- Updated active script references from root `samples/` to `old_samples/` where the intended path was clear.
+- Verified `games/index.html` game-type tile hrefs and images.
+- Verified `tools/index.html` group and tile alphabetical ordering through `tools/tools-page-accordions.js`.
+- Verified `/favicon.svg` canonical icon and proprietary/restrictive `LICENSE`.
+- Node static validation for changed HTML, JS, CSS, JSON, Markdown, PowerShell, and Python files.
 - `git diff --check`
 - `git status --short -- start_of_day old-tools old_games old_samples`
 - `npm run codex:review-artifacts`
-- ZIP packaging for `tmp/PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup_delta.zip`
+- ZIP packaging for `tmp/PR_26154_017-root-migration-closeout-bundle_delta.zip`
 
 Validation summary:
 
-- PASS `assets/theme/v1/` removed.
-- PASS `src/engine/theme/` removed.
-- PASS active header image now resolves from `assets/theme/v2/images/toolboxaid-header.png`.
-- PASS no active stale references remain for `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, or `favicon.ico`.
-- PASS active structure inventory completed for active and deprecated ownership areas.
-- PASS `node tools/dev/checkStyleSystemGuard.mjs`.
-- PASS syntax checks for changed JS files.
-- PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files.
+- PASS no active stale references remain for `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, `favicon.ico`, or root `samples/`.
+- PASS active/deprecated structure inventory completed.
+- PASS `/docs/` user-facing only and `/docs_build/` build/governance ownership confirmed.
+- PASS active game and tool structure confirmed.
+- PASS `/favicon.svg` is canonical and `favicon.ico` is absent.
+- PASS `LICENSE` is proprietary/restrictive.
+- PASS `games/index.html` tile links and images resolve.
+- PASS `tools/index.html` groups and group contents are alphabetically sorted.
+- PASS static validation for changed HTML, JS, CSS, JSON, Markdown, PowerShell, and Python files.
 - PASS `git diff --check`.
 - PASS no `start_of_day/`, `old-tools/`, `old_games/`, or `old_samples/` changes.
 - PASS review artifact generation.

docs_build/dev/commit_comment.txt

@@ -1,9 +1,9 @@
-Final theme engine removal and active structure cleanup
+Root migration closeout bundle
 
-PR: PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup
+PR: PR_26154_017-root-migration-closeout-bundle
 
-- Move the final V1 header image to `assets/theme/v2/images/toolboxaid-header.png`.
-- Delete `assets/theme/v1/` and `src/engine/theme/` after active reference removal.
-- Remove active `src/engine/theme` dependencies from capture tooling and dev guards.
-- Produce final active-vs-deprecated ownership inventory and cleanup candidate report.
-- Validate targeted active references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
+- Normalize remaining active root `samples/` references to `old_samples/` where the intended owner is clear.
+- Confirm active stale paths are gone for `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, `favicon.ico`, and deprecated root `samples/`.
+- Confirm active/deprecated ownership for docs, docs_build, tools, games, old-tools, old_games, and old_samples.
+- Confirm `/favicon.svg`, proprietary LICENSE, games index tiles, and alphabetized tools index ordering.
+- Validate targeted active paths, changed static/script files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.

docs_build/dev/reports/root_migration_closeout_bundle_report.md

@@ -0,0 +1,79 @@
+# PR_26154_017 Root Migration Closeout Bundle Report
+
+Task: `PR_26154_017-root-migration-closeout-bundle`
+
+## Scope
+
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Closed out active path references for the root migration.
+- Verified current active/deprecated structure ownership.
+- Normalized remaining active references to deprecated root `samples/` paths where the intended path was clearly `old_samples/`.
+- Did not modify `old-tools/`, `old_games/`, `old_samples/`, or `start_of_day/`.
+- Did not rebuild tools or add feature work.
+
+## Changes
+
+| File | Change |
+| --- | --- |
+| `scripts/PS/audit-sample-json-js-references.ps1` | Default sample root and comment now use `old_samples`. |
+| `scripts/PS/audit-samples-only-palette-json.ps1` | Help text and default sample root now use `old_samples`. |
+| `scripts/audit-sample-json-ownership.mjs` | Sample root, metadata path, report path, regexes, and report text now use `old_samples` and `docs_build/dev/reports`. |
+| `scripts/engine_usage_audit.py` | Sample bucket detection now uses `old_samples`. |
+| `scripts/run-targeted-test-lanes.mjs` | Removed the obsolete active `samples/` lane check while keeping `old_samples/` and `tests/samples/`. |
+| `tools/dev/checkInternalBarrelGuard.mjs` | Sample entrypoint pattern now uses `old_samples`. |
+| `tools/shared/preview/generate-list-previews.html` | Preview input parser now recognizes `old_samples/phase...` paths. |
+| `tools/schemas/README.md` | Removed an ambiguous trailing slash from the schema `samples` layout label; the actual schema path is unchanged. |
+
+## Active Path Closeout
+
+Targeted active-path validation found no active references to:
+
+- `GameFoundryStudio/`
+- `src/engine/theme/`
+- `assets/theme/v1/`
+- `favicon.ico`
+- deprecated root `samples/`
+
+The scan excluded `docs_build/`, tests, reports, `old-tools/`, `old_games/`, `old_samples/`, `start_of_day/`, and `tmp/` so historical records and deprecated references remain preserved.
+
+## Structure Confirmation
+
+| Area | Status |
+| --- | --- |
+| `/docs/` | User-facing documentation only: `index.html`, `faq.html`, `reference.html`, `support.html`, and `README.md`. |
+| `/docs_build/` | Build, dev, PR, reports, schema docs, design/reference/release/tool docs, and workflow content. |
+| `/tools/` | Active tool surfaces use `tools/[toolname]/index.html`; support folders remain under `tools/dev`, `tools/shared`, and `tools/schemas`. |
+| `/old-tools/` | Deprecated tools live under `old-tools/`. |
+| `/games/` | Active game category pages live under `games/`; `games/index.html` exists and links to game-type tiles. |
+| `/old_games/` | Deprecated playable games live under `old_games/`. |
+| `/old_samples/` | Deprecated samples live under `old_samples/`. |
+| `/favicon.svg` | Canonical active site icon; `/favicon.ico` is absent. |
+| `LICENSE` | Proprietary/restrictive license notice is present. |
+
+## Games And Tools
+
+- PASS: `games/index.html` exists.
+- PASS: `games/index.html` exposes 7 game-type tiles and every tile href/image resolves.
+- PASS: `tools/index.html` loads the active accordion data source.
+- PASS: Tool groups are alphabetically sorted: AI, Assets, Audio, Colors, Input, Objects, Worlds.
+- PASS: Tool tiles inside every group are alphabetically sorted by visible tool name.
+- PASS: 19 active tool href/image references resolve.
+
+## Cleanup
+
+- `GameFoundryStudio/`, `samples/`, `assets/theme/v1/`, `src/engine/theme/`, and `favicon.ico` are absent.
+- No empty tracked legacy folders remained to delete.
+- Deprecated `old-tools/`, `old_games/`, and `old_samples/` were not modified.
+
+## Validation
+
+- PASS: Targeted active-path reference validation.
+- PASS: Canonical favicon validation.
+- PASS: LICENSE proprietary/restrictive validation.
+- PASS: Games index tile link/image validation.
+- PASS: Tools index alphabetical ordering validation.
+- PASS: Static validation for changed HTML, JS, CSS, JSON, Markdown, plus touched PowerShell/Python scripts.
+- PASS: `git diff --check`.
+- PASS: `git status --short -- start_of_day old-tools old_games old_samples` returned no output.
+- SKIPPED: `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
+- SKIPPED: old tools, old games, old samples, and full samples smoke tests per request.

docs_build/dev/reports/root_migration_remaining_work_report.md

@@ -0,0 +1,31 @@
+# PR_26154_017 Root Migration Remaining Work Report
+
+Task: `PR_26154_017-root-migration-closeout-bundle`
+
+## Remaining Cleanup Candidates
+
+These items were identified during closeout but intentionally not moved in this PR:
+
+| Candidate | Reason Deferred |
+| --- | --- |
+| `tools/_templates-v2/` | Still present with an `index.html`; confirm whether it is an active template surface or should move to deprecated template ownership. |
+| `tools/dev/`, `tools/shared/`, `tools/schemas/` | Active support folders under `tools/`, not user-facing tool surfaces. Move only if a new support-code ownership target is approved. |
+| `tools/renderToolsIndex.js` and `tools/toolRegistry.js` | Active root-level tool support files. Consolidation would require a separate import/launcher audit. |
+| `games/assets/` | Active game support assets, not a game category page. No move recommended without a new assets ownership PR. |
+| `docs_build/` historical archives and reports | Historical records still mention old paths by design; not active runtime references. |
+| `old-tools/`, `old_games/`, `old_samples/` | Deprecated reference/playable areas preserved by request. |
+
+## Confirmed Closed
+
+- No active `GameFoundryStudio/` references.
+- No active `src/engine/theme/` references.
+- No active `assets/theme/v1/` references.
+- No active `favicon.ico` references.
+- No active deprecated root `samples/` references.
+- `/favicon.svg` is the canonical active site icon.
+- `LICENSE` is proprietary/restrictive.
+
+## Notes
+
+- `old_samples/` references remain where they preserve deprecated sample access or validation routing.
+- `tools/shared/samples/` and `tools/schemas/samples/` are active support/schema namespaces, not deprecated root sample paths.

scripts/PS/audit-sample-json-js-references.ps1

@@ -1,5 +1,5 @@
 param(
-  [string]$SamplesRoot = "$PSScriptRoot\..\..\samples",
+  [string]$SamplesRoot = "$PSScriptRoot\..\..\old_samples",
   [string]$OutputPath = "docs_build/dev/reports/sample_json_js_reference_audit.csv",
   [switch]$FailOnMissing,
   [switch]$Details,
@@ -40,7 +40,7 @@ function Get-SampleRootForFile {
     return $null
   }
 
-  # Handle JSON files directly under a first-level folder (for example samples/metadata/*.json).
+  # Handle JSON files directly under a first-level folder (for example old_samples/metadata/*.json).
   if ($parts.Count -eq 2 -and [System.IO.Path]::GetExtension($parts[1]) -eq '.json') {
     return Join-Path $SamplesRootFull $parts[0]
   }

scripts/PS/audit-samples-only-palette-json.ps1

@@ -1,9 +1,9 @@
 <#
 .SYNOPSIS
-  Recursively audits samples/** and reports sample folders where the only JSON files are palette JSON files.
+  Recursively audits old_samples/** and reports sample folders where the only JSON files are palette JSON files.
 
 .DESCRIPTION
-  A palette-only sample folder is a leaf sample directory under samples/** that contains one or more *.json files,
+  A palette-only sample folder is a leaf sample directory under old_samples/** that contains one or more *.json files,
   and every JSON file in that folder matches *.palette.json.
 
   Output:
@@ -12,14 +12,14 @@
     - total count at the end
 
 .PARAMETER SamplesRoot
-  Root samples directory. Defaults to "samples" relative to the current repo root.
+  Root samples directory. Defaults to "old_samples" relative to the current repo root.
 
 .PARAMETER CsvPath
   Optional CSV output path. Defaults to docs_build/dev/reports/samples_only_palette_json_audit.csv.
 #>
 
 param(
-    [string]$SamplesRoot = "samples",
+    [string]$SamplesRoot = "old_samples",
     [string]$CsvPath = "docs_build/dev/reports/samples_only_palette_json_audit.csv"
 )
 

scripts/audit-sample-json-ownership.mjs

@@ -7,12 +7,12 @@ const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 const repoRoot = path.resolve(__dirname, "..");
 
-const SAMPLES_ROOT = path.join(repoRoot, "samples");
+const SAMPLES_ROOT = path.join(repoRoot, "old_samples");
 const METADATA_PATH = path.join(SAMPLES_ROOT, "metadata", "samples.index.metadata.json");
-const REPORT_PATH = path.join(repoRoot, "docs", "dev", "reports", "PR_11_41_sample_json_ownership_audit.md");
+const REPORT_PATH = path.join(repoRoot, "docs_build", "dev", "reports", "PR_11_41_sample_json_ownership_audit.md");
 
 const SAMPLE_JSON_PATTERN = /^sample(?:\.|-)\d{4}[.-].+\.json$/i;
-const SAMPLE_PATH_PATTERN = /^samples\/phase-\d{2}\/\d{4}\//;
+const SAMPLE_PATH_PATTERN = /^old_samples\/phase-\d{2}\/\d{4}\//;
 const EXEMPT_WORKSPACE_SAMPLE_ID = "1902";
 const EXEMPT_WORKSPACE_FILE = "sample.1902.workspace-all-tools.json";
 
@@ -224,7 +224,7 @@ async function main() {
 
   const rows = [];
   for (const relPath of sampleJsonFiles) {
-    const folderMatch = relPath.match(/^samples\/phase-\d{2}\/(\d{4})\//);
+    const folderMatch = relPath.match(/^old_samples\/phase-\d{2}\/(\d{4})\//);
     const folderSampleId = folderMatch ? folderMatch[1] : "";
     const fileName = path.basename(relPath);
     const fileIdentity = parseSampleFileIdentity(fileName);
@@ -287,12 +287,12 @@ async function main() {
     "# PR 11.41 Sample JSON Ownership Audit",
     "",
     "## Scope",
-    "- Audited sample-owned JSON files under `samples/phase-*/####/sample*.json`.",
-    "- Cross-checked against `samples/metadata/samples.index.metadata.json` roundtrip tool preset mappings.",
+    "- Audited sample-owned JSON files under `old_samples/phase-*/####/sample*.json`.",
+    "- Cross-checked against `old_samples/metadata/samples.index.metadata.json` roundtrip tool preset mappings.",
     "- Cross-checked sample-local entrypoint/source references (`index.html`, `main.js`, sibling JSON/MD references).",
     "",
     "## Sample 1902 Exemption",
-    "- `samples/phase-19/1902/sample.1902.workspace-all-tools.json` is marked **EXEMPT WORKSPACE SAMPLE**.",
+    "- `old_samples/phase-19/1902/sample.1902.workspace-all-tools.json` is marked **EXEMPT WORKSPACE SAMPLE**.",
     "- Single-tool KEEP/MOVE/DELETE ownership rules were not applied to 1902.",
     "- 1902 was validated only as a workspace integration manifest source.",
     "",

scripts/engine_usage_audit.py

@@ -62,8 +62,8 @@ def main():
         if p.suffix.lower() in JS_EXT and p.is_file():
             rel = p.relative_to(root)
             parts = rel.parts
-            if len(parts) >= 2 and parts[0] in ("samples", "old_games"):
-                key = "/".join(parts[:2])  # samples/SampleXXX or old_games/<name>
+            if len(parts) >= 2 and parts[0] in ("old_samples", "old_games"):
+                key = "/".join(parts[:2])  # old_samples/<phase> or old_games/<name>
                 buckets[key] |= scan_file(p)
 
     # Print report

scripts/run-targeted-test-lanes.mjs

@@ -656,7 +656,7 @@ function routeLanesForChangedFiles(changedFiles) {
       || normalized.startsWith("tests/input/")
       || normalized.startsWith("tests/render/")) {
       routed.add("engine-src");
-    } else if (normalized.startsWith("samples/") || normalized.startsWith("old_samples/") || normalized.startsWith("tests/samples/")) {
+    } else if (normalized.startsWith("old_samples/") || normalized.startsWith("tests/samples/")) {
       continue;
     }
   }

tools/dev/checkInternalBarrelGuard.mjs

@@ -155,7 +155,7 @@ function isGameEntryIndex(relativePath) {
 }
 
 function isSampleEntryIndex(relativePath) {
-  return /^samples\/phase-\d{2}\/\d{4}\/index\.js$/.test(relativePath);
+  return /^old_samples\/phase-\d{2}\/\d{4}\/index\.js$/.test(relativePath);
 }
 
 function isToolEntryIndex(relativePath, fullPath) {