Complete engine input runtime ownership for Input Mapping V2 - PR_26140_118-complete-engine-input-runtime-ownership

Author: qbytesdq-jpg

docs/dev/reports/engine_input_runtime_ownership_completion_report.md

@@ -0,0 +1,63 @@
+# Engine Input Runtime Ownership Completion Report
+
+PR: `PR_26140_118-complete-engine-input-runtime-ownership`
+
+## Summary
+- Extended `InputCaptureSession` into an engine-owned runtime state machine for capture lifecycle, timing lifecycle, combo-visible state, release state, double-click state, drag state, wheel validation, gamepad result handling, and visual complete/cancel reset timing.
+- Added an engine state-change subscription path so Input Mapping V2 renders capture state changes from the engine instead of owning capture timers locally.
+- Rewired `ToolStarterApp.js` to delegate keyboard, mouse, wheel, combo, gamepad, release, double-click, and drag capture sequencing through `InputCaptureSession` runtime methods.
+- Removed remaining tool-local capture timeout, pending double-click timeout, visual-state timer, and gesture-specific sequencing branches where the engine session can own the lifecycle.
+- Preserved existing Input Mapping V2 UI behavior, Action Mapping(s) naming, Workspace Manager V2 launch behavior, and filtered JSON export excluding empty actions.
+- Did not tighten schema `minItems`, and did not touch sample JSON.
+
+## Files Changed
+- `src/engine/input/InputCaptureSession.js`
+- `tools/input-mapping-v2/js/ToolStarterApp.js`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `docs/dev/commit_comment.txt`
+- `docs/dev/codex_commands.md`
+- `docs/dev/reports/engine_input_runtime_ownership_completion_report.md`
+
+## Playwright Impact
+- Playwright impacted: Yes.
+- Expected pass behavior: Workspace V2 validation passes while Input Mapping V2 captures keyboard, mouse, wheel, drag, combo, and gamepad inputs through engine runtime paths.
+- Expected fail behavior: tests fail if the tool recreates local capture timers/sequencing, if engine runtime methods do not execute combo/release/hold/double-click/drag flows, if game.manifest discovery breaks, or if exported JSON includes empty actions.
+
+## Runtime Coverage Added/Updated
+- Added in-browser runtime verification for engine-owned capture lifecycle and timeout/visual-reset lifecycle.
+- Added runtime verification for engine-backed combo capture through `InputService` combo state and `InputCaptureSession.handleComboRecord`.
+- Added runtime verification for keyboard release and hold flows through `InputCaptureSession`.
+- Added runtime verification for mouse double-click, wheel validation, drag start/move/release, and pointer drag bounds through engine runtime methods.
+- Added runtime verification for gamepad button press, hold, and release through engine gamepad snapshots and `captureGamepadInput`.
+- Updated the engine ownership assertion to prove the tool subscribes/renders engine session state and no longer contains local capture pending/timeout/visual timer fields.
+- Preserved existing Workspace Manager V2 coverage for active `game.manifest.json` registration, Workspace Manager discovery/runtime load path, and filtered JSON export excluding empty actions.
+
+## Validation
+- PASS: `node --check src/engine/input/InputCaptureSession.js`
+- PASS: `node --check tools/input-mapping-v2/js/ToolStarterApp.js`
+- PASS: `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- PASS: targeted engine import validation with `node --input-type=module`.
+- PASS: focused drag runtime/UI regression check passed 1/1 test.
+- PASS: focused Input Mapping V2 Playwright run passed 12/12 tests.
+- PASS: `npm run test:workspace-v2` passed 71/71 tests.
+- PASS: `git diff --check` reported no whitespace errors. It emitted the existing Windows LF-to-CRLF warning for `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
+
+## Coverage Report
+- Browser V8 coverage was generated by the workspace-v2 run.
+- Changed runtime JS coverage lines are present in `docs/dev/reports/playwright_v8_coverage_report.txt`:
+  - `(89%) src/engine/input/InputCaptureSession.js - changed JS file with browser V8 coverage`
+  - `(94%) tools/input-mapping-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage`
+- `docs/dev/reports/coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+
+## Manual Test Notes
+1. Open `tools/input-mapping-v2/index.html`.
+2. Add/select an `Action Mapping(s)` tile.
+3. Select `Input Device(s)` and a compatible `Capture Gestures` entry, then capture keyboard release, keyboard combo, mouse double-click, mouse drag release, mouse wheel, and gamepad button release inputs.
+4. Expected result: capture state messages visibly progress through waiting/pending/complete or warning, mappings appear on the selected tile, and invalid gesture/input combinations do not create mappings.
+5. Click JSON or Copy JSON.
+6. Expected result: exported/copied JSON omits actions with empty `inputs` arrays and keeps mapped actions intact.
+7. Open Workspace Manager V2, select Asteroids, and launch Input Mapping V2.
+8. Expected result: Input Mapping V2 is discoverable from the active game manifest and loads through the Workspace Manager runtime path.
+
+## Full Samples Smoke Test
+- Not run, per request and project instructions. This PR is scoped to engine input runtime ownership, Input Mapping V2, and Workspace V2 validation.