|
2 | 2 |
|
3 | 3 | Task: |
4 | 4 |
|
5 | | -- `PR_26154_014-tools-index-sort-cleanup` |
| 5 | +- `PR_26154_015-theme-v1-removal-fontawesome-v2` |
6 | 6 |
|
7 | 7 | Commands run: |
8 | 8 |
|
9 | 9 | - `Get-Content .codex/skills/repo-build/SKILL.md` |
10 | 10 | - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md` |
11 | 11 | - `git status --short --untracked-files=all` |
12 | | -- `Get-Content tools/index.html` |
13 | | -- `Get-Content tools/tools-page-accordions.js` |
14 | | -- `rg -n "GameFoundryStudio/|src/engine/theme/|assets/theme/v2/assets/|assets/theme/v2/images/games/|favicon\\.ico" tools/index.html tools/tools-page-accordions.js` |
15 | | -- Node scoped rewrite for `tools/tools-page-accordions.js` group and tile ordering. |
16 | | -- `rg --files | rg -i "localization|localisation|localize|translate|translation"` |
17 | | -- `Get-ChildItem assets/theme/v2/images/tools` |
18 | | -- `rg -n "localization\\.png|localization-studio|Localization|localization" tools assets docs docs_build -g "!*old*"` |
19 | | -- `rg -n "tools-page-accordions\\.js" -g "*.html" -g "*.js" -g "*.md" -g "*.json" .` |
20 | | -- `node --check tools/tools-page-accordions.js` |
| 12 | +- Targeted `Get-ChildItem` and `Get-Content` inspection for: |
| 13 | + - `assets/theme/v1/` |
| 14 | + - `assets/theme/v2/fonts/` |
| 15 | + - `src/engine/theme/` |
| 16 | + - `src/engine/ui/toolboxaid-header.html` |
| 17 | + - `src/engine/theme/toolboxaid-header.html` |
| 18 | +- Targeted `rg` reference checks for: |
| 19 | + - `assets/theme/v1` |
| 20 | + - `assets/theme/v1/fontawesome` |
| 21 | + - `fontawesome` |
| 22 | + - `assets/theme/v2/fonts/fontawesome` |
| 23 | + - `CapturePreviewRuntime` |
| 24 | + - `src/engine/theme` |
| 25 | +- Node verified move of `assets/theme/v1/fontawesome/` to `assets/theme/v2/fonts/fontawesome/`. |
| 26 | +- Updated `src/engine/theme/main.css`. |
| 27 | +- Updated `assets/theme/v1/README.md`. |
| 28 | +- Updated `src/engine/theme/README.md`. |
21 | 29 | - Node targeted validator for: |
22 | | - - active Tools index group ordering |
23 | | - - tile ordering within each group |
24 | | - - active tool href/image file existence |
25 | | - - `tools/index.html` local ref file existence |
26 | | - - stale active path strings |
| 30 | + - old Font Awesome V1 source removal |
| 31 | + - moved Font Awesome destination file existence |
| 32 | + - absence of active old Font Awesome path refs |
| 33 | + - remaining active V1 references |
| 34 | + - active V2 Font Awesome import resolution |
| 35 | + - `src/engine/theme/CapturePreviewRuntime.js` absence |
| 36 | + - `src/engine/theme/` non-empty status |
27 | 37 | - Node static validation for changed HTML, JS, CSS, JSON, and Markdown files. |
28 | 38 | - `git diff --check` |
29 | | -- `git status --short -- start_of_day old_games old_samples` |
| 39 | +- `git status --short -- start_of_day old_games old_samples old-tools` |
30 | 40 | - `npm run codex:review-artifacts` |
31 | | -- ZIP packaging for `tmp/PR_26154_014-tools-index-sort-cleanup_delta.zip` |
| 41 | +- ZIP packaging for `tmp/PR_26154_015-theme-v1-removal-fontawesome-v2_delta.zip` |
32 | 42 |
|
33 | 43 | Validation summary: |
34 | 44 |
|
35 | | -- PASS `tools/tools-page-accordions.js` syntax validation. |
36 | | -- PASS active Tools index group order is alphabetical. |
37 | | -- PASS active Tools index tile order is alphabetical within every group. |
38 | | -- PASS 19 active tool href/image references resolve. |
39 | | -- PASS 4 `tools/index.html` local refs resolve. |
40 | | -- PASS no targeted stale path strings remain in `tools/index.html` or `tools/tools-page-accordions.js`. |
| 45 | +- PASS `assets/theme/v1/fontawesome/` moved out of Theme V1. |
| 46 | +- PASS Font Awesome CSS and font files exist under `assets/theme/v2/fonts/fontawesome/`. |
| 47 | +- PASS `src/engine/theme/main.css` imports the V2 Font Awesome path. |
| 48 | +- PASS no active old Font Awesome V1-path references remain. |
| 49 | +- PASS remaining active `assets/theme/v1` refs are limited to runtime header image consumers. |
| 50 | +- PASS `src/engine/theme/CapturePreviewRuntime.js` was already absent and has no active exact-path refs. |
| 51 | +- PASS `src/engine/theme/` remains non-empty and was not deleted. |
41 | 52 | - PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files. |
42 | 53 | - PASS `git diff --check`. |
43 | | -- PASS no `start_of_day/`, `old_games/`, or `old_samples/` changes. |
| 54 | +- PASS no `start_of_day/`, `old_games/`, `old_samples/`, or `old-tools/` changes. |
44 | 55 | - PASS review artifact generation. |
45 | 56 | - PASS repo-structured delta ZIP packaging. |
46 | 57 | - SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed. |
47 | | -- SKIPPED old games, old samples, and full samples smoke validation per request. |
| 58 | +- SKIPPED old games, old samples, old tools, and full samples smoke validation per request. |
0 commit comments