Skip to content

Commit 5cd5d02

Browse files
committed
Remove unused Theme V1 assets and move Font Awesome into Theme V2 fonts - PR_26154_015-theme-v1-removal-fontawesome-v2
1 parent 9993a12 commit 5cd5d02

10 files changed

Lines changed: 115 additions & 35 deletions

File tree

assets/theme/v1/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,7 @@
33
This folder is reserved for legacy public Theme V1 assets.
44

55
Current contents:
6-
- `fontawesome/` contains the legacy Font Awesome assets used by `src/engine/theme/main.css`.
76
- `images/toolboxaid-header.png` contains the legacy shared header image used by runtime header templates.
7+
8+
Moved content:
9+
- `fontawesome/` moved to `assets/theme/v2/fonts/fontawesome/` for PR_26154_015.

assets/theme/v1/fontawesome/css/font-awesome.min.css renamed to assets/theme/v2/fonts/fontawesome/css/font-awesome.min.css

File renamed without changes.

assets/theme/v1/fontawesome/fonts/fontawesome-webfont.ttf renamed to assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.ttf

File renamed without changes.

assets/theme/v1/fontawesome/fonts/fontawesome-webfont.woff renamed to assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.woff

File renamed without changes.

assets/theme/v1/fontawesome/fonts/fontawesome-webfont.woff2 renamed to assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.woff2

File renamed without changes.

docs_build/dev/codex_commands.md

Lines changed: 36 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,46 +2,57 @@
22

33
Task:
44

5-
- `PR_26154_014-tools-index-sort-cleanup`
5+
- `PR_26154_015-theme-v1-removal-fontawesome-v2`
66

77
Commands run:
88

99
- `Get-Content .codex/skills/repo-build/SKILL.md`
1010
- `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
1111
- `git status --short --untracked-files=all`
12-
- `Get-Content tools/index.html`
13-
- `Get-Content tools/tools-page-accordions.js`
14-
- `rg -n "GameFoundryStudio/|src/engine/theme/|assets/theme/v2/assets/|assets/theme/v2/images/games/|favicon\\.ico" tools/index.html tools/tools-page-accordions.js`
15-
- Node scoped rewrite for `tools/tools-page-accordions.js` group and tile ordering.
16-
- `rg --files | rg -i "localization|localisation|localize|translate|translation"`
17-
- `Get-ChildItem assets/theme/v2/images/tools`
18-
- `rg -n "localization\\.png|localization-studio|Localization|localization" tools assets docs docs_build -g "!*old*"`
19-
- `rg -n "tools-page-accordions\\.js" -g "*.html" -g "*.js" -g "*.md" -g "*.json" .`
20-
- `node --check tools/tools-page-accordions.js`
12+
- Targeted `Get-ChildItem` and `Get-Content` inspection for:
13+
- `assets/theme/v1/`
14+
- `assets/theme/v2/fonts/`
15+
- `src/engine/theme/`
16+
- `src/engine/ui/toolboxaid-header.html`
17+
- `src/engine/theme/toolboxaid-header.html`
18+
- Targeted `rg` reference checks for:
19+
- `assets/theme/v1`
20+
- `assets/theme/v1/fontawesome`
21+
- `fontawesome`
22+
- `assets/theme/v2/fonts/fontawesome`
23+
- `CapturePreviewRuntime`
24+
- `src/engine/theme`
25+
- Node verified move of `assets/theme/v1/fontawesome/` to `assets/theme/v2/fonts/fontawesome/`.
26+
- Updated `src/engine/theme/main.css`.
27+
- Updated `assets/theme/v1/README.md`.
28+
- Updated `src/engine/theme/README.md`.
2129
- Node targeted validator for:
22-
- active Tools index group ordering
23-
- tile ordering within each group
24-
- active tool href/image file existence
25-
- `tools/index.html` local ref file existence
26-
- stale active path strings
30+
- old Font Awesome V1 source removal
31+
- moved Font Awesome destination file existence
32+
- absence of active old Font Awesome path refs
33+
- remaining active V1 references
34+
- active V2 Font Awesome import resolution
35+
- `src/engine/theme/CapturePreviewRuntime.js` absence
36+
- `src/engine/theme/` non-empty status
2737
- Node static validation for changed HTML, JS, CSS, JSON, and Markdown files.
2838
- `git diff --check`
29-
- `git status --short -- start_of_day old_games old_samples`
39+
- `git status --short -- start_of_day old_games old_samples old-tools`
3040
- `npm run codex:review-artifacts`
31-
- ZIP packaging for `tmp/PR_26154_014-tools-index-sort-cleanup_delta.zip`
41+
- ZIP packaging for `tmp/PR_26154_015-theme-v1-removal-fontawesome-v2_delta.zip`
3242

3343
Validation summary:
3444

35-
- PASS `tools/tools-page-accordions.js` syntax validation.
36-
- PASS active Tools index group order is alphabetical.
37-
- PASS active Tools index tile order is alphabetical within every group.
38-
- PASS 19 active tool href/image references resolve.
39-
- PASS 4 `tools/index.html` local refs resolve.
40-
- PASS no targeted stale path strings remain in `tools/index.html` or `tools/tools-page-accordions.js`.
45+
- PASS `assets/theme/v1/fontawesome/` moved out of Theme V1.
46+
- PASS Font Awesome CSS and font files exist under `assets/theme/v2/fonts/fontawesome/`.
47+
- PASS `src/engine/theme/main.css` imports the V2 Font Awesome path.
48+
- PASS no active old Font Awesome V1-path references remain.
49+
- PASS remaining active `assets/theme/v1` refs are limited to runtime header image consumers.
50+
- PASS `src/engine/theme/CapturePreviewRuntime.js` was already absent and has no active exact-path refs.
51+
- PASS `src/engine/theme/` remains non-empty and was not deleted.
4152
- PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files.
4253
- PASS `git diff --check`.
43-
- PASS no `start_of_day/`, `old_games/`, or `old_samples/` changes.
54+
- PASS no `start_of_day/`, `old_games/`, `old_samples/`, or `old-tools/` changes.
4455
- PASS review artifact generation.
4556
- PASS repo-structured delta ZIP packaging.
4657
- SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
47-
- SKIPPED old games, old samples, and full samples smoke validation per request.
58+
- SKIPPED old games, old samples, old tools, and full samples smoke validation per request.

docs_build/dev/commit_comment.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
Tools index sort cleanup
1+
Theme V1 removal and Font Awesome V2 migration
22

3-
PR: PR_26154_014-tools-index-sort-cleanup
3+
PR: PR_26154_015-theme-v1-removal-fontawesome-v2
44

5-
- Sort active Tools index groups alphabetically by group name.
6-
- Sort tool tiles alphabetically by visible tool name within each existing group.
7-
- Preserve all existing group assignments, tool names, and launch hrefs.
8-
- Fix the active Localization tile image path to the existing `localization-studio.png` asset.
9-
- Validate active Tools index ordering, resolved local href/image paths, stale path strings, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
5+
- Move `assets/theme/v1/fontawesome/` to `assets/theme/v2/fonts/fontawesome/`.
6+
- Update `src/engine/theme/main.css` to import Font Awesome from the V2 fonts path.
7+
- Keep `assets/theme/v1/` because two active runtime header templates still consume `images/toolboxaid-header.png`.
8+
- Confirm `src/engine/theme/CapturePreviewRuntime.js` is already absent and `src/engine/theme/` remains non-empty/runtime-owned.
9+
- Validate targeted references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# PR_26154_015 Theme V1 Removal Font Awesome V2 Report
2+
3+
Task: `PR_26154_015-theme-v1-removal-fontawesome-v2`
4+
5+
## Scope
6+
7+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
8+
- Audited active references to `assets/theme/v1` excluding docs, tests, reports, `old-tools/`, `old_games/`, `old_samples/`, and `start_of_day/`.
9+
- Moved Font Awesome from Theme V1 assets to Theme V2 fonts.
10+
- Updated the active runtime import that consumed Font Awesome.
11+
- Checked `src/engine/theme/CapturePreviewRuntime.js` and `src/engine/theme/`.
12+
- Did not modify `start_of_day/`, `old_games/`, `old_samples/`, or `old-tools/`.
13+
14+
## Changes
15+
16+
| Change | Result |
17+
| --- | --- |
18+
| Move `assets/theme/v1/fontawesome/` | Moved to `assets/theme/v2/fonts/fontawesome/`. |
19+
| Update Font Awesome import | `src/engine/theme/main.css` now imports `/assets/theme/v2/fonts/fontawesome/css/font-awesome.min.css`. |
20+
| Update V1 asset note | `assets/theme/v1/README.md` now lists only the remaining V1 header image and records the Font Awesome move. |
21+
| Update runtime theme note | `src/engine/theme/README.md` now documents the split between the V1 header image and V2 Font Awesome package. |
22+
| Delete `src/engine/theme/CapturePreviewRuntime.js` | No deletion needed; file was already absent. |
23+
| Delete `src/engine/theme/` | Not deleted; the folder remains non-empty and runtime-owned. |
24+
25+
## Active V1 References
26+
27+
`assets/theme/v1/` was not deleted because active runtime references remain:
28+
29+
| File | Reference |
30+
| --- | --- |
31+
| `src/engine/theme/toolboxaid-header.html` | `/assets/theme/v1/images/toolboxaid-header.png` |
32+
| `src/engine/ui/toolboxaid-header.html` | `/assets/theme/v1/images/toolboxaid-header.png` |
33+
34+
No active references remain to `assets/theme/v1/fontawesome/`.
35+
36+
## Font Awesome Destination
37+
38+
Moved files:
39+
40+
- `assets/theme/v2/fonts/fontawesome/css/font-awesome.min.css`
41+
- `assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.ttf`
42+
- `assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.woff`
43+
- `assets/theme/v2/fonts/fontawesome/fonts/fontawesome-webfont.woff2`
44+
45+
## Capture Preview Runtime
46+
47+
- `src/engine/theme/CapturePreviewRuntime.js` was already absent.
48+
- Targeted active reference search found no exact-path consumers of `src/engine/theme/CapturePreviewRuntime.js`.
49+
- `tools/shared/tooling/CapturePreviewRuntime.js` remains out of scope; it is a separate active shared tooling file.
50+
51+
## Validation
52+
53+
- PASS: Source `assets/theme/v1/fontawesome/` removed.
54+
- PASS: Destination `assets/theme/v2/fonts/fontawesome/` exists with the moved CSS and font files.
55+
- PASS: No active old Font Awesome V1-path references remain.
56+
- PASS: Active `assets/theme/v1` references are limited to the two runtime header image consumers listed above.
57+
- PASS: Active `assets/theme/v2/fonts/fontawesome` reference resolves from `src/engine/theme/main.css`.
58+
- PASS: `src/engine/theme/CapturePreviewRuntime.js` absent and no active exact-path refs found.
59+
- PASS: `src/engine/theme/` remains non-empty with runtime-owned files.
60+
- PASS: Static validation for changed HTML, JS, CSS, JSON, and Markdown files.
61+
- PASS: `git diff --check`.
62+
- PASS: `git status --short -- start_of_day old_games old_samples old-tools` returned no output.
63+
- SKIPPED: `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
64+
- SKIPPED: old games, old samples, old tools, and full samples smoke tests per request.

src/engine/theme/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212
- `Theme.js` and `ThemeTokens.js` provide runtime theme helpers used by tooling.
1313
- `accordionV2/` contains the runtime accordion component CSS and JS.
1414

15-
Static legacy assets consumed by this runtime surface now live under `assets/theme/v1/`.
15+
Static runtime assets currently consumed by this surface:
16+
17+
- `assets/theme/v1/images/toolboxaid-header.png` remains a legacy runtime header image.
18+
- `assets/theme/v2/fonts/fontawesome/` contains the Font Awesome font package imported by `main.css`.
1619

1720
## Import
1821

src/engine/theme/main.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
@import url('./tokens.css');
2-
@import url('/assets/theme/v1/fontawesome/css/font-awesome.min.css');
2+
@import url('/assets/theme/v2/fonts/fontawesome/css/font-awesome.min.css');
33
@import url('./layout.css');
44
@import url('./header.css');
55
@import url('./nav.css');

0 commit comments

Comments
 (0)