Skip to content

Commit 04dfaf6

Browse files
committed
Link Build Path tool names and show badges - PR_26156_119-build-path-tool-links-badges
1 parent df0093d commit 04dfaf6

37 files changed

Lines changed: 446 additions & 173 deletions

docs_build/dev/codex_commands.md

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,3 +590,58 @@ Required reports:
590590
- `docs_build/dev/reports/testing_lane_execution_report.md`
591591
- `docs_build/dev/reports/codex_changed_files.txt`
592592
- `docs_build/dev/reports/codex_review.diff`
593+
594+
595+
## PR_26156_118
596+
597+
Changes:
598+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
599+
- Updated Toolbox card rendering so tool names render as `h3 > a` links.
600+
- Sourced name-link targets from the registered Toolbox route via `getToolRoute()`.
601+
- Preserved existing preview-image links, Open Tool launch actions, card layout, status badges, and image diagnostics.
602+
- Added targeted Toolbox navigation/runtime Playwright/MSJ coverage for name-link route resolution.
603+
- Did not modify Toolbox registry metadata.
604+
- Did not add or modify CSS.
605+
- Did not modify `start_of_day`.
606+
607+
Validation:
608+
- `node --check toolbox/tools-page-accordions.js`
609+
- `node --check tests/playwright/tools/ToolNavigationPrevNext.spec.mjs`
610+
- `npm run test:lane:tool-navigation`
611+
- Scoped `git diff --check` for changed implementation/test files.
612+
- Targeted changed-file scan confirmed no local CSS, inline styles, script blocks, or `start_of_day` references were introduced.
613+
- Full samples smoke: skipped by request.
614+
615+
Required reports:
616+
- `docs_build/dev/reports/toolbox-name-link-navigation-report.md`
617+
- `docs_build/dev/reports/testing_lane_execution_report.md`
618+
- `docs_build/dev/reports/codex_changed_files.txt`
619+
- `docs_build/dev/reports/codex_review.diff`
620+
621+
622+
## PR_26156_119
623+
624+
Changes:
625+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
626+
- Updated Build Path rows on `toolbox/index.html` so the Tool cell renders a registry-backed badge image and linked tool name.
627+
- Sourced Build Path tool-name links from `getToolRoute()`.
628+
- Sourced Build Path badge images through the approved Toolbox registry image path.
629+
- Reused the existing visible image diagnostic behavior for missing badge fallback.
630+
- Preserved Build Path workflow order, status labels, completion values, and progress guidance.
631+
- Added targeted Build Path Playwright/MSJ coverage for links, badges, and visible missing-badge diagnostics.
632+
- Did not add inline styles, style blocks, script blocks, inline event handlers, or CSS.
633+
- Did not modify `start_of_day`.
634+
635+
Validation:
636+
- `node --check toolbox/tools-page-accordions.js`
637+
- `node --check tests/playwright/tools/BuildPathProgressSimplification.spec.mjs`
638+
- `npm run test:lane:build-path`
639+
- Scoped `git diff --check` for changed implementation/test files.
640+
- Targeted changed-file scan confirmed no inline styles, style blocks, script blocks, inline event handlers, or `start_of_day` references were introduced.
641+
- Full samples smoke: skipped by request.
642+
643+
Required reports:
644+
- `docs_build/dev/reports/build-path-tool-links-badges-report.md`
645+
- `docs_build/dev/reports/testing_lane_execution_report.md`
646+
- `docs_build/dev/reports/codex_changed_files.txt`
647+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Close Toolbox image UI diagnostics - PR_26156_114-117-tool-image-ui-closeout
1+
Link Build Path tools and badges - PR_26156_119-build-path-tool-links-badges
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# PR_26156_119 Build Path Tool Links Badges
2+
3+
## Scope
4+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before implementation.
5+
- Updated the Build Path screen rendered on `toolbox/index.html`.
6+
- Kept existing Build Path workflow order, status labels, completion values, and progress guidance intact.
7+
- Did not add inline styles, `<style>` blocks, `<script>` blocks, or inline event handlers.
8+
- Did not modify unrelated Toolbox screens.
9+
- Did not modify `start_of_day`.
10+
11+
## Implementation Notes
12+
- `toolbox/tools-page-accordions.js`
13+
- Replaced the Build Path Tool cell's plain text with a compact registry-backed badge and tool-name link.
14+
- Each Build Path badge uses the approved registry badge source from `/assets/theme-v2/images/badges/`.
15+
- Each Build Path tool-name link uses the registered route from `getToolRoute()` and stores it in `data-registered-tool-route`.
16+
- Browser navigation uses root-relative hrefs such as `/toolbox/game-design/index.html` so links resolve correctly from `/toolbox/index.html`.
17+
- Missing badge fallback reuses the existing visible image diagnostic behavior and `/assets/theme-v2/images/image-missing.svg`.
18+
- `tests/playwright/tools/BuildPathProgressSimplification.spec.mjs`
19+
- Added targeted Build Path coverage for badge image paths.
20+
- Added targeted Build Path coverage for registered tool-name links.
21+
- Simulated a missing badge image failure and verified the visible diagnostic.
22+
- Click-checked the Game Design Build Path link.
23+
24+
## Validation Notes
25+
- Impacted lane: `build-path`.
26+
- Command: `npm run test:lane:build-path`.
27+
- Result: PASS, 4 Playwright tests.
28+
- Static checks:
29+
- `node --check toolbox/tools-page-accordions.js` - PASS
30+
- `node --check tests/playwright/tools/BuildPathProgressSimplification.spec.mjs` - PASS
31+
- Scoped `git diff --check` for changed implementation/test files - PASS
32+
- Targeted guard checks:
33+
- No inline styles, `<style>` blocks, `<script>` blocks, inline event handlers, or `start_of_day` references were introduced in changed implementation/test files.
34+
35+
## Manual Test Notes
36+
- Toolbox Build Path view was exercised at `/toolbox/index.html?role=admin`.
37+
- Every Build Path row retained its existing workflow order.
38+
- Every Build Path tool name rendered as a link with a registered route.
39+
- Every Build Path badge rendered from the approved Theme V2 badge path for the tool.
40+
- Simulated Game Design badge failure displayed `Badge image missing; fallback shown.`.
41+
- Game Design Build Path link navigated to `/toolbox/game-design/index.html`.
42+
- No console errors or failed page requests were reported by the targeted lane.
43+
44+
## Skipped Lanes
45+
- Full samples smoke: skipped by request.
46+
- Tool image lane: skipped because this PR consumes existing approved badge paths and the Build Path lane directly validates the affected UI.
47+
- Broad Project Workspace/runtime suites: skipped because this PR only changes Build Path table UI and preserves existing progress/status content.

docs_build/dev/reports/coverage_changed_js_guardrail.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
66
Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
77

88
Changed runtime JS files considered:
9-
(66%) toolbox/tools-page-accordions.js - executed lines 1869/1869; executed functions 40/61
10-
(88%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 28/32
9+
(81%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 26/32
10+
(90%) toolbox/tools-page-accordions.js - executed lines 1934/1934; executed functions 70/78
1111

1212
Guardrail warnings:
1313
(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/dependency_gating_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-06-05T12:32:34.997Z
3+
Generated: 2026-06-05T12:42:55.005Z
44
Status: PASS
55

66
## Gate Order
@@ -18,9 +18,9 @@ Status: PASS
1818
| project-workspace | No | SKIP | none | Project Workspace mock repository, Project Workspace UI, and Toolbox Progress/Build Path project-state bridge | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
1919
| game-design | No | SKIP | none | Game Design mock repository, project purpose flow, validation overlay, capability demo authoring, and Toolbox progress handoff | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2020
| game-configuration | No | SKIP | none | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
21-
| build-path | No | SKIP | none | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
21+
| build-path | Yes | PASS | none | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | Lane has no lane dependencies and is eligible after preflight and compilation pass. |
2222
| tools-progress | No | SKIP | none | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
23-
| tool-navigation | Yes | PASS | none | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | Lane has no lane dependencies and is eligible after preflight and compilation pass. |
23+
| tool-navigation | No | SKIP | none | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2424
| tool-display-mode | No | SKIP | none | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2525
| tool-images | No | SKIP | none | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2626
| tool-runtime | No | SKIP | none | Active public toolbox and Tool Template V2 contract | Lane was not selected, so dependency-gated runtime scheduling skipped it. |

docs_build/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-06-05T12:32:34.998Z
3+
Generated: 2026-06-05T12:42:55.005Z
44
Status: PASS
55

66
## Summary
@@ -16,7 +16,7 @@ Prevented fixture ownership traversal: 0
1616

1717
| Lane | Status | Helpers | Fixtures | Imports | Dependency Hydration Hash | Reason |
1818
| --- | --- | --- | --- | --- | --- | --- |
19-
| tool-navigation | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs; toolbox/toolRegistry.js | 0074b6ff936b5572 | Dependency hydration was refreshed after warm-start invalidation. |
19+
| build-path | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs; toolbox/toolRegistry.js | 63d18ef7748baba0 | Dependency hydration was refreshed after warm-start invalidation. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/execution_graph_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-06-05T12:32:34.998Z
3+
Generated: 2026-06-05T12:42:55.006Z
44
Status: PASS
55

66
## Summary
@@ -16,7 +16,7 @@ Prevented targeted scheduling work: 0
1616

1717
| Lane | Status | Snapshot Status | Execution Graph Hash | Reason |
1818
| --- | --- | --- | --- | --- |
19-
| tool-navigation | INVALIDATED | INVALIDATED | 7c80d9ed012db476 | Lane snapshot is part of the selected targeted execution graph. |
19+
| build-path | INVALIDATED | INVALIDATED | 6d25c5bf0f297b47 | Lane snapshot is part of the selected targeted execution graph. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/failure_fingerprint_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-06-05T12:32:34.998Z
3+
Generated: 2026-06-05T12:43:20.765Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/filesystem_scan_reduction_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Filesystem Scan Reduction Report
22

3-
Generated: 2026-06-05T12:32:34.965Z
3+
Generated: 2026-06-05T12:42:54.984Z
44
Status: PASS
55

66
## Scan Enforcement

docs_build/dev/reports/incremental_validation_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-06-05T12:32:34.998Z
3+
Generated: 2026-06-05T12:42:55.006Z
44
Status: PASS
55

66
## Reuse Summary
@@ -18,7 +18,7 @@ Prevented fixture resolution passes: 0
1818

1919
| Lane | Decision | Invalidated By | Runtime Savings Observation |
2020
| --- | --- | --- | --- |
21-
| tool-navigation | INVALIDATED | Persistent manifest lane definition hash changed for tool-navigation. | Manifest was regenerated or skipped; no reuse savings for this lane. |
21+
| build-path | INVALIDATED | Persistent manifest lane definition hash changed for build-path. | Manifest was regenerated or skipped; no reuse savings for this lane. |
2222

2323
## Invalidation Rules
2424

0 commit comments

Comments
 (0)