solid-router 2.0.0-rc.0: `<Link>` drops a caller’s `role` on enabled links (react-router keeps it)

[TylerRick]

Reproducer: https://github.com/TylerRick/tanstack-solid-link-role-repro (pnpm install && pnpm dev; react-control/ is the same markup on react-router)

A role passed to <Link> never reaches the DOM unless the link is disabled:

element	solid-router 2.0.0-rc.0	react-router 1.170.27
<Link to="/" role="button">	no role attribute	role="button"
<Link to="/" role="button" disabled>	role="link"	role="link"
<a href="/" role="button">	role="button"	role="button"

useLinkProps copies the caller's props onto linkProps, then redefines role unconditionally, so the getter wins on enabled links:

role: () => local.disabled ? "link" : void 0,

The React adapter merges its { role: 'link', 'aria-disabled': true } only when the link IS disabled (...disabled && STATIC_DISABLED_PROPS), which is why the same markup keeps role="button" there.

A fix could be to fall back instead of override — role: () => (local.disabled ? 'link' : propsSafeToSpread.role) — or to define the getter only when local.disabled is set. Happy to PR whichever you prefer.

Impact for us: an accessible tab strip built on <Link role="button"> loses the role, so getByRole('button') no longer finds the tabs.

Versions: @tanstack/solid-router 2.0.0-rc.0, @tanstack/router-core 1.171.16, solid-js / @solidjs/web 2.0.0-rc.0, vite 8.2.1.

[schiller-manuel]

please provide an actual reproducer project as a git repo. this is required. also don't paste your AI output here. write a concise description instead.
future issues not following this will be closed

[Fnine59]

Fixed by #8109. Enabled Solid Router links now retain caller-provided roles, while disabled links continue to force role="link".

[TylerRick]

Added a reproducer repo and shortened the description, per the note on #8107: https://github.com/TylerRick/tanstack-solid-link-role-repro