From 0abdc74c9ddebc06931e265428692e4baec02cb1 Mon Sep 17 00:00:00 2001
From: andershagbard <andershagbard@gmail.com>
Date: Tue, 28 Jul 2026 11:30:37 +0200
Subject: [PATCH] Fix theme-check-disable-next-line inside <style>/<script>
 tags

getNextNode() only looked for sibling nodes via a `children` array,
but Liquid nodes nested inside raw HTML tags (<style>, <script>, <svg>)
are stored under RawMarkup.nodes instead. This caused
findNextLinePosition() to silently fail to find the next node, so
`theme-check-disable-next-line` had no effect for any tag inside a
<style>/<script> block (e.g. disabling PaginationSize on a paginate
tag used to generate CSS).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q8U8PReyAciD8ck994vMHk
---
 .changeset/fix-disable-next-line-raw-tags.md       |  5 +++++
 .../src/disabled-checks/index.spec.ts              | 14 ++++++++++++++
 .../src/disabled-checks/index.ts                   |  2 ++
 3 files changed, 21 insertions(+)
 create mode 100644 .changeset/fix-disable-next-line-raw-tags.md

diff --git a/.changeset/fix-disable-next-line-raw-tags.md b/.changeset/fix-disable-next-line-raw-tags.md
new file mode 100644
index 000000000..1b740a816
--- /dev/null
+++ b/.changeset/fix-disable-next-line-raw-tags.md
@@ -0,0 +1,5 @@
+---
+'@shopify/theme-check-common': patch
+---
+
+Fix `theme-check-disable-next-line` not suppressing offenses when the following tag is nested inside a raw HTML tag (`<style>`, `<script>`, `<svg>`). Previously, the sibling-node lookup only checked for a `children` array, but nodes inside raw HTML tags are stored under a `nodes` property on the `RawMarkup` body, so the disable comment was silently ineffective in that context.
diff --git a/packages/theme-check-common/src/disabled-checks/index.spec.ts b/packages/theme-check-common/src/disabled-checks/index.spec.ts
index 7c7233dc2..7d01e4774 100644
--- a/packages/theme-check-common/src/disabled-checks/index.spec.ts
+++ b/packages/theme-check-common/src/disabled-checks/index.spec.ts
@@ -281,6 +281,20 @@ ${buildComment('theme-check-enable')}
         expect(offenses).to.have.length(0);
       });
 
+      it('should disable the next line when nested inside a raw HTML tag like <style> or <script>', async () => {
+        for (const rawTag of ['style', 'script']) {
+          const file = `<${rawTag}>
+  {% # theme-check-disable-next-line %}
+  {% render 'something' %}
+  {% render 'other-thing' %}
+</${rawTag}>`;
+
+          const offenses = await check({ 'code.liquid': file }, checks);
+          expect(offenses).to.have.length(1);
+          expectRenderMarkupOffense(offenses, 'other-thing.liquid');
+        }
+      });
+
       it('should still report offenses in doc tags when disable-next-line is not present', async () => {
         const file = `{% doc %}
   @param baz - first param
diff --git a/packages/theme-check-common/src/disabled-checks/index.ts b/packages/theme-check-common/src/disabled-checks/index.ts
index dd925df39..cee8e932e 100644
--- a/packages/theme-check-common/src/disabled-checks/index.ts
+++ b/packages/theme-check-common/src/disabled-checks/index.ts
@@ -185,6 +185,8 @@ function getNextNode(
     siblingNodes = parentNode.markup;
   } else if ('children' in parentNode) {
     siblingNodes = parentNode.children || [];
+  } else if ('nodes' in parentNode) {
+    siblingNodes = parentNode.nodes || [];
   }
 
   const currentNodeIdx = siblingNodes.findIndex((c) => c === node);