From 9686babec8c10c65c54417c2c33dc760a9bddb69 Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 17:51:46 +0530 Subject: [PATCH 1/6] let's try that thing again --- .github/workflows/cmake-multi-platform.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index cf0c78b8..be61b347 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -157,12 +157,31 @@ jobs: PhoenixEngine retention-days: 7 + - name: install procdump (Windows) + if: runner.os == 'Windows' + shell: pwsh + run: | + Invoke-WebRequest -Uri "https://download.sysinternals.com/files/Procdump.zip" -OutFile procdump.zip + Expand-Archive procdump.zip -DestinationPath procdump + echo "${{ github.workspace }}\procdump" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + - name: Doc Gen (Windows) if: runner.os == 'Windows' shell: cmd run: | "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau + - name: upload crash dump (Windows) + if: runner.os == 'Windows' + uses: actions/upload-artifact@v6 + with: + name: "crashdump-${{ matrix.build_type }}" + path: | + *.dmp + x64/${{ matrix.build_type }}/PhoenixEngine.pdb + if-no-files-found: ignore + retention-days: 1 + - name: Test (Windows) if: runner.os == 'Windows' shell: cmd From 7bae6d7a3879660f4e2de7431d295baf990bb0bf Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 17:57:17 +0530 Subject: [PATCH 2/6] oops forgot --- .github/workflows/cmake-multi-platform.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index be61b347..c9b4b777 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -167,9 +167,11 @@ jobs: - name: Doc Gen (Windows) if: runner.os == 'Windows' + continue-on-error: true shell: cmd run: | - "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" + procdump -accepteula -e -ma -x . "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau - name: upload crash dump (Windows) if: runner.os == 'Windows' From 2d96fc58f6c0e5aab4d1cd23d6f07906c57912ba Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 21:56:47 +0530 Subject: [PATCH 3/6] vs2026 --- .github/workflows/cmake-multi-platform.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index c9b4b777..dfcdcab0 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -170,7 +170,7 @@ jobs: continue-on-error: true shell: cmd run: | - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" + call "C:\Program Files\Microsoft Visual Studio\2026\Enterprise\Common7\Tools\VsDevCmd.bat" procdump -accepteula -e -ma -x . "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau - name: upload crash dump (Windows) @@ -180,7 +180,7 @@ jobs: name: "crashdump-${{ matrix.build_type }}" path: | *.dmp - x64/${{ matrix.build_type }}/PhoenixEngine.pdb + build/${{ matrix.build_type }}/PhoenixEngine.pdb if-no-files-found: ignore retention-days: 1 From 6d215f0045660c3c34d7317754111c17c3936950 Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 22:24:29 +0530 Subject: [PATCH 4/6] pwsh --- .github/workflows/cmake-multi-platform.yml | 26 +++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index dfcdcab0..94813589 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -29,8 +29,8 @@ jobs: fail-fast: false matrix: - os: [windows-latest, ubuntu-latest] - build_type: [Release, Debug, ReleaseTSan, DebugTSan] + os: [windows-latest] + build_type: [Release, Debug] c_compiler: [cl, clang] include: - os: windows-latest @@ -165,13 +165,29 @@ jobs: Expand-Archive procdump.zip -DestinationPath procdump echo "${{ github.workspace }}\procdump" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + - name: dlls + if: runner.os == 'Windows' + shell: pwsh + run: | + $needed = (& "dumpbin.exe" /dependents PhoenixEngine.exe) 2>&1 + Write-Host $needed + foreach ($line in $needed) { + if ($line -match '^\s+(\S+\.dll)') { + $dll = $matches[1] + $found = Get-Command $dll -ErrorAction SilentlyContinue + if (-not $found) { + Write-Host "MISSING $dll" + } + } + } + - name: Doc Gen (Windows) if: runner.os == 'Windows' continue-on-error: true - shell: cmd + shell: pwsh run: | - call "C:\Program Files\Microsoft Visual Studio\2026\Enterprise\Common7\Tools\VsDevCmd.bat" - procdump -accepteula -e -ma -x . "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau + & ".\PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau + Write-Host "Exit code: $LASTEXITCODE" - name: upload crash dump (Windows) if: runner.os == 'Windows' From adc664180ffabcf834662f9104cfa7a299abd561 Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 22:30:27 +0530 Subject: [PATCH 5/6] cutie mew mew magic --- .github/workflows/cmake-multi-platform.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 94813589..1e9bf3e9 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -165,11 +165,15 @@ jobs: Expand-Archive procdump.zip -DestinationPath procdump echo "${{ github.workspace }}\procdump" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + - name: vsdev + if: runner.os == 'Windows' + uses: ilammy/msvc-dev-cmd@v1 + - name: dlls if: runner.os == 'Windows' shell: pwsh run: | - $needed = (& "dumpbin.exe" /dependents PhoenixEngine.exe) 2>&1 + $needed = (& dumpbin /dependents PhoenixEngine.exe) 2>&1 Write-Host $needed foreach ($line in $needed) { if ($line -match '^\s+(\S+\.dll)') { From dcc5b3803844e5ed3565f0e6e2387007a20aecc5 Mon Sep 17 00:00:00 2001 From: phoenixwhitefire2000 Date: Sat, 15 Aug 2026 22:41:05 +0530 Subject: [PATCH 6/6] waohg --- .github/workflows/cmake-multi-platform.yml | 47 +++------------------- 1 file changed, 5 insertions(+), 42 deletions(-) diff --git a/.github/workflows/cmake-multi-platform.yml b/.github/workflows/cmake-multi-platform.yml index 1e9bf3e9..95bdb121 100644 --- a/.github/workflows/cmake-multi-platform.yml +++ b/.github/workflows/cmake-multi-platform.yml @@ -29,8 +29,8 @@ jobs: fail-fast: false matrix: - os: [windows-latest] - build_type: [Release, Debug] + os: [windows-latest, ubuntu-latest] + build_type: [Release, Debug, ReleaseTSan, DebugTSan] c_compiler: [cl, clang] include: - os: windows-latest @@ -157,52 +157,15 @@ jobs: PhoenixEngine retention-days: 7 - - name: install procdump (Windows) - if: runner.os == 'Windows' - shell: pwsh - run: | - Invoke-WebRequest -Uri "https://download.sysinternals.com/files/Procdump.zip" -OutFile procdump.zip - Expand-Archive procdump.zip -DestinationPath procdump - echo "${{ github.workspace }}\procdump" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append - - - name: vsdev + - name: Setup VS Dev environment (Windows) if: runner.os == 'Windows' uses: ilammy/msvc-dev-cmd@v1 - - name: dlls - if: runner.os == 'Windows' - shell: pwsh - run: | - $needed = (& dumpbin /dependents PhoenixEngine.exe) 2>&1 - Write-Host $needed - foreach ($line in $needed) { - if ($line -match '^\s+(\S+\.dll)') { - $dll = $matches[1] - $found = Get-Command $dll -ErrorAction SilentlyContinue - if (-not $found) { - Write-Host "MISSING $dll" - } - } - } - - name: Doc Gen (Windows) if: runner.os == 'Windows' - continue-on-error: true - shell: pwsh + shell: cmd run: | - & ".\PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau - Write-Host "Exit code: $LASTEXITCODE" - - - name: upload crash dump (Windows) - if: runner.os == 'Windows' - uses: actions/upload-artifact@v6 - with: - name: "crashdump-${{ matrix.build_type }}" - path: | - *.dmp - build/${{ matrix.build_type }}/PhoenixEngine.pdb - if-no-files-found: ignore - retention-days: 1 + "PhoenixEngine.exe" --headless --tool scripts/ci/docs.luau - name: Test (Windows) if: runner.os == 'Windows'