From 87d59289b38d3765938fc71aeed9c0291dfb59b1 Mon Sep 17 00:00:00 2001 From: Valera V Harseko Date: Thu, 16 Jul 2026 23:31:08 +0300 Subject: [PATCH 1/2] Drop the stale animal-sniffer Java 1.7 API check from persistit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The persistit modules pinned animal-sniffer to the signature org.codehaus.mojo.signature:java17:1.0 — the Java 1.7 API surface — inherited from the upstream Akiban Persistit build. The project compiles at maven.compiler.release=11, so the check enforced a baseline three releases below the declared one, and javac already enforces the real baseline natively via `release`. The check was redundant and wrong. It never ran in CI until #270 switched the build from `mvn package` to `mvn verify`: animal-sniffer binds to the verify phase. Once it started running it failed on Java 8 APIs merged earlier under `mvn package` — ThreadLocal.withInitial (#228) and Long.hashCode(long) (#232). Remove the plugin declarations from the core and ui modules along with the signature properties in the parent. Nothing else refers to it: there are no @IgnoreJRERequirement annotations in the tree. --- persistit/core/pom.xml | 4 ---- persistit/pom.xml | 28 ---------------------------- persistit/ui/pom.xml | 4 ---- 3 files changed, 36 deletions(-) diff --git a/persistit/core/pom.xml b/persistit/core/pom.xml index e420c52ca..c6a5735a3 100644 --- a/persistit/core/pom.xml +++ b/persistit/core/pom.xml @@ -85,10 +85,6 @@ license-maven-plugin 2.6 - - org.codehaus.mojo - animal-sniffer-maven-plugin - diff --git a/persistit/pom.xml b/persistit/pom.xml index af84d435c..ad834ecd3 100644 --- a/persistit/pom.xml +++ b/persistit/pom.xml @@ -22,11 +22,6 @@ - - org.codehaus.mojo.signature - java17 - 1.0 - 1.20 2.6 @@ -45,29 +40,6 @@ - - org.codehaus.mojo - animal-sniffer-maven-plugin - ${version.animal-sniffer.plugin} - - - ${animal-sniffer.signature.groupId} - ${animal-sniffer.signature.artifactId} - ${animal-sniffer.signature.version} - - ${skipSanityChecks} - - - - enforce-java-api-compatibility - verify - - check - - - - - org.codehaus.mojo build-helper-maven-plugin diff --git a/persistit/ui/pom.xml b/persistit/ui/pom.xml index 0e64c7973..c8ee69f3f 100644 --- a/persistit/ui/pom.xml +++ b/persistit/ui/pom.xml @@ -26,10 +26,6 @@ com.mycila license-maven-plugin - - org.codehaus.mojo - animal-sniffer-maven-plugin - From e536a43ccf62a71726567f27a8e58ad226ed01f7 Mon Sep 17 00:00:00 2001 From: Valera V Harseko Date: Thu, 16 Jul 2026 23:38:56 +0300 Subject: [PATCH 2/2] Add the missing license headers to the persistit poms The three persistit poms carried no license header. They are not upstream Akiban files: they were added in #12 when the build artifacts were reorganized, so there is no upstream owner to preserve. Use the CDDL block of the root pom, which is their parent, with a standalone 3A Systems copyright covering 2020 (when the files were added) through the current year. --- persistit/core/pom.xml | 15 +++++++++++++++ persistit/pom.xml | 15 +++++++++++++++ persistit/ui/pom.xml | 15 +++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/persistit/core/pom.xml b/persistit/core/pom.xml index c6a5735a3..09e2f9d4d 100644 --- a/persistit/core/pom.xml +++ b/persistit/core/pom.xml @@ -1,4 +1,19 @@ + 4.0.0 diff --git a/persistit/pom.xml b/persistit/pom.xml index ad834ecd3..06d04c0ad 100644 --- a/persistit/pom.xml +++ b/persistit/pom.xml @@ -1,4 +1,19 @@ + 4.0.0 diff --git a/persistit/ui/pom.xml b/persistit/ui/pom.xml index c8ee69f3f..1f9998d47 100644 --- a/persistit/ui/pom.xml +++ b/persistit/ui/pom.xml @@ -1,4 +1,19 @@ + 4.0.0