From 887479d05612248146997dec6d1b2118ccab7ee9 Mon Sep 17 00:00:00 2001
From: Hendrik Ebbers <hendrik.ebbers@open-elements.com>
Date: Thu, 16 Jul 2026 18:13:44 +0200
Subject: [PATCH] fix(pom): re-enable -parameters compiler flag
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Commit d43152f ("remove unused maven plugins") dropped the maven-compiler-plugin
<parameters>true</parameters> configuration, assuming it was unused. It is not:
Spring relies on formal parameter names being present in the bytecode to resolve
constructor/method injection by name — e.g. to disambiguate two beans of the same
type by the parameter name, and to bind @RequestParam/@PathVariable/@ConfigurationProperties
without an explicit name. Spring Boot's own parent enables -parameters by default
for exactly this reason.

Without the flag, downstream Spring projects fail at ApplicationContext load with
NoUniqueBeanDefinitionException (observed in spring-services after bumping to parent
1.2.0: two JsonAuthenticationEntryPoint beans could no longer be told apart).

Re-added as the maven.compiler.parameters property (honored by maven-compiler-plugin
3.15.0), consistent with how maven.compiler.source/target are declared.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 pom.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pom.xml b/pom.xml
index 9feffe4..5c0e44f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,6 +39,11 @@
 
         <maven.compiler.source>21</maven.compiler.source>
         <maven.compiler.target>21</maven.compiler.target>
+        <!-- Emit -parameters so formal parameter names survive into the bytecode. Spring relies on
+             them to resolve constructor/method injection by name (e.g. disambiguating two beans of
+             the same type by parameter name) and to bind @RequestParam/@PathVariable/@ConfigurationProperties
+             without an explicit name. Spring Boot's own parent enables this by default for the same reason. -->
+        <maven.compiler.parameters>true</maven.compiler.parameters>
 
         <!-- Minimum build environment enforced by the maven-enforcer-plugin.
              Child projects may override these to require a newer toolchain. -->