From a7a41ef3d06c25b7f9f969ef500dc0ff3690ea1d Mon Sep 17 00:00:00 2001
From: Winchell <cw20050111@gmail.com>
Date: Mon, 10 Aug 2026 14:10:02 +0800
Subject: [PATCH] fix: address Copilot review comments on PR #3428 (URMA
 transport)

- Rename misleading test case ack_bit_is_rdma_ok -> ack_bit_is_urma_ok
- Derive URMA recv block size from sizeof(butil::IOBuf::Block) instead
  of the hard-coded 32-byte constant, which silently assumed the
  internal Block layout
- Pin the umdk WORKSPACE/MODULE.bazel dependency to an immutable
  commit SHA instead of the movable tag v26.06.0_CAM, matching how
  every other git dependency in these files is already pinned
---
 MODULE.bazel                  | 2 +-
 WORKSPACE                     | 2 +-
 src/brpc/urma/urma_helper.cpp | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/MODULE.bazel b/MODULE.bazel
index 391b8c2784..b1935511b4 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -60,6 +60,6 @@ git_repository = use_repo_rule(
 git_repository(
     name = 'umdk',
     build_file = '//bazel/third_party/umdk:umdk.BUILD',
+    commit = '564ee727a55523d4351a8fb3c94292b388ebb924', # v26.06.0_CAM
     remote = 'https://atomgit.com/openeuler/umdk.git',
-    commit = '564ee727a55523d4351a8fb3c94292b388ebb924',  # v26.06.0_CAM
 )
diff --git a/WORKSPACE b/WORKSPACE
index 22fc411b32..fa6e601746 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -282,8 +282,8 @@ http_archive(
 git_repository(
     name = "umdk",
     build_file = "//bazel/third_party/umdk:umdk.BUILD",
+    commit = "564ee727a55523d4351a8fb3c94292b388ebb924", # v26.06.0_CAM
     remote = "https://atomgit.com/openeuler/umdk.git",
-    commit = "564ee727a55523d4351a8fb3c94292b388ebb924",  # v26.06.0_CAM
 )
 
 # Header-only JSON library used by iobuf_unittest's IOBuf<->std::iostream
diff --git a/src/brpc/urma/urma_helper.cpp b/src/brpc/urma/urma_helper.cpp
index 648316f1ae..cbe3e53017 100644
--- a/src/brpc/urma/urma_helper.cpp
+++ b/src/brpc/urma/urma_helper.cpp
@@ -100,7 +100,6 @@ DEFINE_bool(urma_poller_yield, false,
             "Yield (bthread_yield) in the busy poll loop to let other "
             "bthreads run");
 
-
 // Set to true to skip real URMA hardware initialization (unit tests). When
 // true, GlobalUrmaInitializeOrDie() returns without touching liburma and the
 // endpoint builds its state machine without posting real WRs.