From dc9ab2de428bd72cceea48c5aea79566bdf2323e Mon Sep 17 00:00:00 2001 From: Xing Yang <5168106+XingY@users.noreply.github.com> Date: Sat, 20 Jun 2026 07:44:44 -0700 Subject: [PATCH] Update testGetSignalDataResourceContainerScoping to use the correct user permission and params (#1029) #### Rationale getSignalDataResourceAction has been updated from requiring ReadPermission to UpdatePermission in 25.10. Additionally, the form parameters are updated. Junit tests needs to be adjusted accordingly. #### Related Pull Requests * https://github.com/LabKey/commonAssays/pull/927 * https://github.com/LabKey/commonAssays/pull/1026 --- .../org/labkey/signaldata/SignalDataController.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/signalData/src/org/labkey/signaldata/SignalDataController.java b/signalData/src/org/labkey/signaldata/SignalDataController.java index 56dc3afac..c9918cdf2 100644 --- a/signalData/src/org/labkey/signaldata/SignalDataController.java +++ b/signalData/src/org/labkey/signaldata/SignalDataController.java @@ -42,10 +42,9 @@ import org.labkey.api.security.permissions.AbstractContainerScopingTest; import org.labkey.api.security.permissions.ReadPermission; import org.labkey.api.security.permissions.UpdatePermission; -import org.labkey.api.security.roles.ReaderRole; +import org.labkey.api.security.roles.EditorRole; import org.labkey.api.util.FileUtil; import org.labkey.api.util.Path; -import org.labkey.api.util.UnexpectedException; import org.labkey.api.view.ActionURL; import org.labkey.api.webdav.WebdavResource; import org.labkey.api.webdav.WebdavService; @@ -247,7 +246,7 @@ public void setup() throws Exception { _folderA = createContainer("A"); _folderB = createContainer("B"); - _readerA = createUserInRole(_folderA, ReaderRole.class); + _readerA = createUserInRole(_folderA, EditorRole.class); } @Test @@ -283,10 +282,10 @@ public void testGetSignalDataResourceContainerScoping() throws Exception */ private static ActionURL resourceUrl(Container requestContainer, Container fileContainer, String name) { - String path = filesPath(fileContainer).append(name).toString(); + String[] paths = { filesPath(fileContainer).append(name).toString() }; + String[] files = { name }; return new ActionURL(getSignalDataResourceAction.class, requestContainer) - .addParameter("path", path) - .addParameter("test", true); + .addParameters(Map.of("paths", paths, "files", files)); } private static Path filesPath(Container c)