From c84260b10262123686a72211716300e9de5958e4 Mon Sep 17 00:00:00 2001 From: William Allen Date: Thu, 9 Jul 2026 10:24:16 -0400 Subject: [PATCH] Move build comments to dedicated page --- app/Http/Controllers/BuildController.php | 10 + app/cdash/tests/CMakeLists.txt | 2 + .../js/angular/views/partials/build.html | 2 +- resources/js/vue/app.js | 1 + .../js/vue/components/BuildCommentsPage.vue | 213 ++++++++++++++++++ resources/js/vue/components/BuildSummary.vue | 146 +----------- .../js/vue/components/shared/BuildSidebar.vue | 29 +++ routes/web.php | 2 + tests/Browser/Pages/BuildCommentsPageTest.php | 119 ++++++++++ .../Pages/BuildSidebarComponentTest.php | 30 +++ tests/Browser/Pages/BuildSummaryPageTest.php | 30 --- 11 files changed, 408 insertions(+), 176 deletions(-) create mode 100644 resources/js/vue/components/BuildCommentsPage.vue create mode 100644 tests/Browser/Pages/BuildCommentsPageTest.php diff --git a/app/Http/Controllers/BuildController.php b/app/Http/Controllers/BuildController.php index 2f847826c9..a7befb8825 100644 --- a/app/Http/Controllers/BuildController.php +++ b/app/Http/Controllers/BuildController.php @@ -127,6 +127,16 @@ public function summary(int $build_id): View ]); } + public function comments(int $build_id): View + { + $this->setBuildById($build_id); + + return $this->vue('build-comments-page', 'Comments', [ + 'build-id' => $this->build->Id, + 'user-id' => Auth::id() ?? 0, + ]); + } + public function update(int $build_id): View { $this->setBuildById($build_id); diff --git a/app/cdash/tests/CMakeLists.txt b/app/cdash/tests/CMakeLists.txt index b4616aab97..98fee9613e 100644 --- a/app/cdash/tests/CMakeLists.txt +++ b/app/cdash/tests/CMakeLists.txt @@ -429,6 +429,8 @@ add_browser_test(/Browser/Pages/BuildDynamicAnalysisIdPageTest) add_browser_test(/Browser/Pages/BuildSummaryPageTest) +add_browser_test(/Browser/Pages/BuildCommentsPageTest) + add_browser_test(/Browser/Pages/BuildSidebarComponentTest) add_browser_test(/Browser/Pages/ProjectSettingsPageTest) diff --git a/resources/js/angular/views/partials/build.html b/resources/js/angular/views/partials/build.html index 619119553d..ed5b8dc1a9 100644 --- a/resources/js/angular/views/partials/build.html +++ b/resources/js/angular/views/partials/build.html @@ -91,7 +91,7 @@ + ng-href="builds/{{::build.id}}/comments"> diff --git a/resources/js/vue/app.js b/resources/js/vue/app.js index ef1038f4f9..83b9fe011c 100755 --- a/resources/js/vue/app.js +++ b/resources/js/vue/app.js @@ -29,6 +29,7 @@ const app = Vue.createApp({ BuildFilesPage: Vue.defineAsyncComponent(() => import('./components/BuildFilesPage.vue')), BuildTargetsPage: Vue.defineAsyncComponent(() => import('./components/BuildTargetsPage.vue')), BuildInstrumentationPage: Vue.defineAsyncComponent(() => import('./components/BuildInstrumentationPage.vue')), + BuildCommentsPage: Vue.defineAsyncComponent(() => import('./components/BuildCommentsPage.vue')), BuildBuildPage: Vue.defineAsyncComponent(() => import('./components/BuildBuildPage.vue')), CoverageFilePage: Vue.defineAsyncComponent(() => import('./components/CoverageFilePage.vue')), BuildCoveragePage: Vue.defineAsyncComponent(() => import('./components/BuildCoveragePage.vue')), diff --git a/resources/js/vue/components/BuildCommentsPage.vue b/resources/js/vue/components/BuildCommentsPage.vue new file mode 100644 index 0000000000..3e0d8d402c --- /dev/null +++ b/resources/js/vue/components/BuildCommentsPage.vue @@ -0,0 +1,213 @@ +