When displaying results of an ad hoc validation, do not display d-portal links

[stevieflow]

I uploaded a file that hasn't yet been published

On checking a particular record I see:

The hyperlink for the activity identifier has the alt-text: Open this activity in d-portal

As the file isn't published, clicking this link leads to:

@robredpath @simon-20 @emmajclegg

[simon-20]

@stevieflow, are these links useful when viewing the results of ad hoc validations - if you're uploading a newer version of a file that has already been published, you'll get links to D-Portal pages but the D-Portal view will be of the old data, not the data in the ad hoc file that has been uploaded.

If such links are not useful, the easiest thing is to just delete the links whenever we're viewing the results of an ad hoc validation session.

If such links are useful, even though the D-Portal view may be constructed from different data, then we can achieve this by having the Validator query the Datastore API using the endpoint which allows checking for the existence of IATI Identifiers. If the identifier exists in the Datastore, we can assume the data exists in D-Portal and create the link, otherwise not. (This won't remove all of the broken links, because the Datastore adds data quicker than D-Portal, but it would get rid of most of them).

[stevieflow]

Thanks for considering the options here @simon-20

I think if you upload a file (via whatever means) then there's no expectation that this data will also be on d-portal: so we can remove the links in ad-hoc scenarios

As noted by you here and me in #1000 there could be other options, but ultimately that has to be presented as a different workflow / option, as it is not "In d-portal"

Thanks

[simon-20]

Great, that's the easy option 👍