Summary
Non-blocking S3 residual from final re-review at 71395f6 (ACCEPT).
When the deadline-join helper cannot be set up (e.g. pthread_attr_setdetachstate or pthread_create fails), the shutdown/join path may surface a generic pthread_join failed style diagnostic rather than a setup-specific reason.
Where
src/worker.c — awp_pthread_join_deadline / join_exited_deadline error paths
Expected
Log or return path should distinguish:
- helper attr / create failure
- target
pthread_join failure after helper ran
- deadline timeout (already distinct: return
1 / quarantine)
Severity
S3 / diagnostics — behavior remains fail-closed (no joinable helper leak after 71395f6).
Origin
Final re-review residual after S3 close of setdetachstate error handling.
Summary
Non-blocking S3 residual from final re-review at
71395f6(ACCEPT).When the deadline-join helper cannot be set up (e.g.
pthread_attr_setdetachstateorpthread_createfails), the shutdown/join path may surface a generic pthread_join failed style diagnostic rather than a setup-specific reason.Where
src/worker.c—awp_pthread_join_deadline/join_exited_deadlineerror pathsExpected
Log or return path should distinguish:
pthread_joinfailure after helper ran1/ quarantine)Severity
S3 / diagnostics — behavior remains fail-closed (no joinable helper leak after
71395f6).Origin
Final re-review residual after S3 close of
setdetachstateerror handling.