Skip to content

Commit 3f3e8da

Browse files
committed
fixing codes based on mentor feedback
1 parent 2e425cb commit 3f3e8da

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
3838
expect(getAngleType(277)).toEqual("Reflex angle");
3939
});
4040
// Case 6: Invalid angles
41-
test(`should return "Invalid angle" when angle is less than 0 or greater than 360`, () => {
41+
test(`should return "Invalid angle" when angle is (0 > angle) and (angle > 360)`, () => {
4242
expect(getAngleType(-60)).toEqual("Invalid angle");
4343
expect(getAngleType(450)).toEqual("Invalid angle");
4444
expect(getAngleType(-1)).toEqual("Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
88
test(`should return false when denominator is zero`, () => {
99
expect(isProperFraction(1, 0)).toEqual(false);
1010
});
11-
test(`should return false when the abs(denominator) less abs(numerator)`, () => {
11+
test(`should return false when the abs(denominator) < abs(numerator)`, () => {
1212
expect(isProperFraction(7, 2)).toEqual(false);
1313
expect(isProperFraction(-17, -2)).toEqual(false);
1414
expect(isProperFraction(1, 0)).toEqual(false);
1515
expect(isProperFraction(0, 0)).toEqual(false);
1616
expect(isProperFraction(2, -2)).toEqual(false);
1717
});
18-
test(`should return true when abs(denominator) is greater than abs(numerator)`, () => {
18+
test(`should return true when abs(denominator) > abs(numerator)`, () => {
1919
expect(isProperFraction(2, 8)).toEqual(true);
2020
expect(isProperFraction(-3, -10)).toEqual(true);
2121
expect(isProperFraction(-3, 7)).toEqual(true);

0 commit comments

Comments
 (0)