review comments implemented

Author: risikatpopoola

Sprint-3/2-practice-tdd/count.js

@@ -1,5 +1,5 @@
 function countChar(stringOfCharacters, findCharacter) {
-  return stringOfCharacters.split(findCharacter).length-1
+  return stringOfCharacters.split(findCharacter).length - 1;
 }
 
 module.exports = countChar;

Sprint-3/2-practice-tdd/count.test.js

@@ -17,33 +17,32 @@ test("should count multiple occurrences of a character", () => {
   expect(count).toEqual(5);
 });
 test("should count multiple occurrences of a character", () => {
-  const str = "pneumonoultramicroscopicsilicovolcanoconoisis";
-  const char = "o";
+  const str = "international";
+  const char = "n";
   const count = countChar(str, char);
-  expect(count).toEqual(9);
+  expect(count).toEqual(3);
 });
 test("should count multiple occurrences of a character", () => {
-  const str = "pneumonoultramicroscopicsilicovolcanoconoisis";
-  const char = "i";
+  const str = "crisis";
+  const char = "s";
   const count = countChar(str, char);
-  expect(count).toEqual(6);
+  expect(count).toEqual(2);
 });
 
-
 // Scenario: No Occurrences
 // Given the input string `str`,
 // And a character `char` that does not exist within `str`.
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of `char` were found.
-test("should count multiple occurrences of a character", () => {
+test("should return 0, indicating that no occurrences of `char` were found", () => {
   const str = "interesting";
   const char = "b";
   const count = countChar(str, char);
   expect(count).toEqual(0);
 });
-test("should count multiple occurrences of a character", () => {
+test("should return 0, indicating that no occurrences of `char` were found", () => {
   const str = "future";
   const char = "m";
   const count = countChar(str, char);
   expect(count).toEqual(0);
-});
+});

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,18 +1,17 @@
 function getOrdinalNumber(num) {
-  if ([11, 12, 13].includes(num % 100)){
-    return num + "th"
+  if ([11, 12, 13].includes(num % 100)) {
+    return num + "th";
   }
-  if (String(num).at(-1)=== "1"){
-    return num + "st"
+  if (String(num).at(-1) === "1") {
+    return num + "st";
   }
-  if (String(num).at(-1) === "2"){
-    return num + "nd"
+  if (String(num).at(-1) === "2") {
+    return num + "nd";
   }
-  if (String(num).at(-1) === "3"){
-    return num + "rd"
-  }
-  else{
-    return num + "th"
+  if (String(num).at(-1) === "3") {
+    return num + "rd";
+  } else {
+    return num + "th";
   }
 }
 

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -43,4 +43,4 @@ test("should append 'nd' for numbers ending with 3", () => {
   expect(getOrdinalNumber(3)).toEqual("3rd");
   expect(getOrdinalNumber(2023)).toEqual("2023rd");
   expect(getOrdinalNumber(16733)).toEqual("16733rd");
-});
+});

Sprint-3/2-practice-tdd/repeat-str.js

@@ -1,12 +1,14 @@
 function repeatStr(str, count) {
   // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
   // The goal is to re-implement that function, not to use it.
-  if(count >= 0){
-    return str.repeat(count);
-  }
-  else{
+  let result = "";
+  if (count < 0) {
     throw new Error("Invalid count");
+  } else {
+    for (let i = 0; i < count; i++) {
+      result += str;
+    }
+    return result;
   }
 }
-
 module.exports = repeatStr;

Sprint-3/2-practice-tdd/repeat-str.test.js

@@ -26,13 +26,13 @@ test("should repeat the string count times", () => {
 // Given a target string `str` and a `count` equal to 1,
 // When the repeatStr function is called with these inputs,
 // Then it should return the original `str` without repetition.
-test("should repeat the string count times", () => {
+test("should repeat the string once", () => {
   const str = "hello";
   const count = 1;
   const repeatedStr = repeatStr(str, count);
   expect(repeatedStr).toEqual("hello");
 });
-test("should repeat the string count times", () => {
+test("should repeat the string once", () => {
   const str = "codeyourfuture";
   const count = 1;
   const repeatedStr = repeatStr(str, count);
@@ -42,13 +42,13 @@ test("should repeat the string count times", () => {
 // Given a target string `str` and a `count` equal to 0,
 // When the repeatStr function is called with these inputs,
 // Then it should return an empty string.
-test("should repeat the string count times", () => {
+test("should return an empty string", () => {
   const str = "hello";
   const count = 0;
   const repeatedStr = repeatStr(str, count);
   expect(repeatedStr).toEqual("");
 });
-test("should repeat the string count times", () => {
+test("should return an empty string", () => {
   const str = "codeyourfuture";
   const count = 0;
   const repeatedStr = repeatStr(str, count);
@@ -58,13 +58,13 @@ test("should repeat the string count times", () => {
 // Given a target string `str` and a negative integer `count`,
 // When the repeatStr function is called with these inputs,
 // Then it should throw an error, as negative counts are not valid.
-test("should repeat the string count times", () => {
+test("should throw an error for negative integer", () => {
   const str = "hello";
   const count = -4;
   expect(() => repeatStr(str, count)).toThrow("Invalid count");
 });
-test("should repeat the string count times", () => {
+test("should throw an error for negative integer", () => {
   const str = "codeyourfuture";
   const count = -1;
   expect(() => repeatStr(str, count)).toThrow("Invalid count");
-});
+});