Replies: 3 comments 27 replies
|
Help is on the way #1107. Righ now it's not possible to have what you need. Even if you use You can thank me if you like with a cup of ☕. |
|
Just realeased for you the fix https://github.com/CodeDredd/pinia-orm/releases/tag/pinia-orm%401.6.1 . It's fine. Maybe somehow you get it to work with sending me a coffee 😄 |
|
Thank you very much, I will test it as soon as possible. Unfortunately, GitHub has banned me from buying a coffee for you due to economic restrictions. Therefore, my payment failed.😪 But in any case, I would still like to help and address the issue. I have created a ticket to the GitHub support team. Once it is resolved, if possible, I will be more than happy to buy you a coffee. |
|
I have tested it and it works perfectly. However, I have a question. If I create an object with Maybe we should not generate an I asked because someone has a fairly extensive application, and in certain instances, they would like to determine if an object has been saved or simply created in an easy way. What do you think? |
|
Hmmm....i get your point. But then you need to use just I am still thinking if this easy solveable or needed at all since you can define ids as not uid. But it kind of feels right to make it that way you say it. |
|
I believe that using |
|
It seems like we have a problem - the
import { Model } from "pinia-orm"
import { Attr, Cast, Str, Uid } from "pinia-orm/dist/decorators"
import { DateCast } from "pinia-orm/dist/casts"
class User extends Model {
static entity = "user_profiles"
@Uid() declare id: string
@Str("") declare name: string
@Cast(() => DateCast) @Attr(null) declare createdAt: Date
@Cast(() => DateCast) @Attr(null) declare updatedAt: Date
static creating(model: Model) {
console.log("creating")
if (model.createdAt == null) {
model.createdAt = new Date()
}
if (!model.name) {
model.name = "set some name"
}
}
static updating(model: Model) {
console.log("updating")
model.updatedAt = new Date()
}
static saving(model: Model) {
console.log("saving")
model.updatedAt = new Date()
}
}
export { User }I encountered an error that I did not expect:
import { afterEach, beforeEach, describe, expect, it } from "vitest"
import { createPinia, type Pinia } from "pinia"
import { createORM, Model, Repository, useRepo } from "pinia-orm"
import { User } from "./User"
describe("User", () => {
// Define some variables that will be used in the tests
let pinia: Pinia
let userProfileRepo: Repository<User>
beforeEach(() => {
pinia = createPinia().use(createORM())
userProfileRepo = useRepo(User, pinia)
})
afterEach(async () => {
Model.clearRegistries()
})
it("userProfileRepo.new(true)", () => {
expect(userProfileRepo.all().length).toBe(0) // double check
const user = userProfileRepo.new(true)!
expect(userProfileRepo.all().length).toBe(1) // should save
expect(user.createdAt).toBeInstanceOf(Date)
expect(user.updatedAt).toBeInstanceOf(Date)
expect(user.name).toBe("set some name")
})
it("userProfileRepo.new(false), broken test", () => {
expect(userProfileRepo.all().length).toBe(0) // double check
const user = userProfileRepo.new(false)!
expect(userProfileRepo.all().length).toBe(0) // should not save
expect(user.createdAt).toBeInstanceOf(Date)
expect(user.updatedAt).toBeNull() // test broken is here
expect(user.name).toBe("set some name")
})
})
|
Okay, but we have a problem here. Where is the hook named Take a look: Maybe the hook named I believe I have a way to hook Pinia's storage before using the ORM to write data, although I'm not yet sure how to execute it. Still, I'm optimistic that it can be done. |
|
I will think about it and write a proposal for you outlining the name and method for implementing the hook. In any case, I will do my best to ensure its success. I will need some time to read through the documentation on how the other library was created and how they named their hooks. |
This hook is |
I also do not understand how returning
import { Model } from "pinia-orm"
import { Attr, Str, Uid } from "pinia-orm/dist/decorators"
class User extends Model {
static entity = "user_profiles"
@Uid() declare id: string
@Str("") declare name: string
@Attr(null) declare createdAt: number
@Attr(null) declare updatedAt: number
static creating(model: Model) {
console.log("creating")
if (model.createdAt == null) {
model.createdAt = new Date().getTime()
}
if (!model.name) {
model.name = "set some name"
}
return false
}
static updating(model: Model) {
console.log("updating")
model.updatedAt = new Date().getTime()
}
static saving(model: Model) {
console.log("saving")
model.updatedAt = new Date().getTime()
}
}
export { User }I returned import { afterEach, beforeEach, describe, expect, it } from "vitest"
import { createPinia, type Pinia } from "pinia"
import { createORM, Model, Repository, useRepo } from "pinia-orm"
import { User } from "./User"
describe("User", () => {
// Define some variables that will be used in the tests
let pinia: Pinia
let userProfileRepo: Repository<User>
beforeEach(() => {
pinia = createPinia().use(createORM())
userProfileRepo = useRepo(User, pinia)
})
afterEach(async () => {
Model.clearRegistries()
})
it("userProfileRepo.new(false)", () => {
expect(userProfileRepo.all().length).toBe(0) // double check
// hook creating fired because new instance
const user = userProfileRepo.new(false)!
expect(user).toBeTruthy() // ERROR IS HEREEE
expect(userProfileRepo.all().length).toBe(0)
// hook creating MUST NOT fire because NOT new instance
userProfileRepo.save(user)
expect(userProfileRepo.all().length).toBe(1)
// Assert that the createdAt and updatedAt fields are set correctly.
expect(new Date(user?.createdAt!)).toBeInstanceOf(Date)
expect(new Date(user?.updatedAt!)).toBeInstanceOf(Date)
expect(user.name).toBe("set some name")
})
}) |
|
I believe that naming and implementing the hooks's logic in a different way might be better. We have hooks named
We also have hooks named
Additionally, we could have optional hooks named
Some use cases:
P.S. |
|
I also encountered a strange error with another test, and I'm not sure if it's related to the new feature or not.
import { Model } from "pinia-orm"
import { Attr, Cast, Str, Uid } from "pinia-orm/dist/decorators"
import { DateCast } from "pinia-orm/dist/casts"
class User extends Model {
static entity = "user_profiles"
@Uid() declare id: string
@Str("") declare name: string
@Cast(() => DateCast) @Attr(null) declare createdAt: Date
@Cast(() => DateCast) @Attr(null) declare updatedAt: Date
static creating(model: Model) {
console.log("creating")
if (model.createdAt == null) {
model.createdAt = new Date()
}
if (!model.name) {
model.name = "set some name"
}
}
static updating(model: Model) {
console.log("updating")
model.updatedAt = new Date()
}
static saving(model: Model) {
console.log("saving")
model.updatedAt = new Date()
}
}
export { User }It happens on a code: class DateCast extends CastAttribute {
/**
* Create a new String attribute instance.
*/
constructor(attributes) {
super(attributes);
}
get(value) {
return value === null ? null : new Date(value);
}
/**
* Make the value for the attribute.
*/
set(value) {
if (value === null)
return null;
return (typeof value === "string" ? new Date(Date.parse(value)) : value).toISOString(); // <<<<<== HERE
}
}
import { afterEach, beforeEach, describe, expect, it } from "vitest"
import { createPinia, type Pinia } from "pinia"
import { createORM, Model, Repository, useRepo } from "pinia-orm"
import { User } from "./User"
describe("User", () => {
// Define some variables that will be used in the tests
let pinia: Pinia
let userProfileRepo: Repository<User>
beforeEach(() => {
pinia = createPinia().use(createORM())
userProfileRepo = useRepo(User, pinia)
})
afterEach(async () => {
Model.clearRegistries()
})
it("userProfileRepo.new(true): error with toISOString is not a function", () => {
expect(userProfileRepo.all().length).toBe(0) // double check
const user = userProfileRepo.new(true)!
expect(userProfileRepo.all().length).toBe(1)
expect(user.createdAt).toBeInstanceOf(Date)
expect(user.updatedAt).toBeInstanceOf(Date)
expect(user.name).toBe("set some name")
userProfileRepo.where("id", user.id).update({ name: "Modified name" }) ///<< ERROR IS HERE
})
it("userProfileRepo.new(false): error with toISOString is not a function", () => {
expect(userProfileRepo.all().length).toBe(0) // double check
const user = userProfileRepo.new(false)!
expect(userProfileRepo.all().length).toBe(0)
expect(user.createdAt).toBeInstanceOf(Date)
expect(user.updatedAt).toBeInstanceOf(Date)
expect(user.name).toBe("set some name")
userProfileRepo.save(user)
expect(userProfileRepo.all().length).toBe(1)
userProfileRepo.where("id", user.id).update({ name: "Modified name" }) ///<< ERROR IS HERE
})
}) |
|
FOUND it 🎉 ....released again and fix. Now everything is correct. Try v1.6.4 |
|
Btw... I don't know if you know it and if it is waht you need. But there is meta field if you need |
Yeah, I took a look at 519681c. I'm sorry, I should have been more clear in my previous messages. However, I have a problem. I'm not very experienced with JavaScript, which can sometimes make it difficult for other people to understand how I describe certain things. |
|
It's all ok 😉 .... sometimes i get self confused by my own words 😆 |
Yes, I have seen it. However, there are certain situations where I prefer to rely on my own logic so that I can better understand and meet my needs. This is especially true for my app, which will both receive and send data to an Electron app. Vue.js app communicates with Pinia ORM to manage data. Pinia ORM communicates with DataProfileModel to read/write data. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I completely do not understand how hooks like
savingandcreatingwork. I want to create some hooks to populate my model fields with custom logic in the following scenarios:I have a hook named
creatingthat populates models with default fields using my logic, and a hook namedsavingwith some logic too. Please note that the code I provided is only a simple example. In reality, I have more complex logic that I need to implement.What I did:
const user = useRepo(User).new(), all of my hooks fire but the models are saved, but I don't need them to be saved. This seems to fulfill all of my needs, but without saving the instance.const user = useRepo(User).make(), none of my hooks seem to fire, even though I expect thecreatinghook to be fired.I am trying to find a way to create a new instance of a model in Pinia-ORM without saving it, while still firing the
creatinghook, similar to usinguseRepo(User).new(). Is there a way to accomplish this using Pinia-ORM?P.S.
I have read all the documentation, issues, Google searches, etc. multiple times over the past two days, but I didn't find any instructions.
{ "dependencies": { "@mdi/font": "^7.2.96", "pinia": "^2.0.32", "pinia-orm": "^1.5.1", "vue": "^3.2.47", "vue-router": "^4.1.6", "vuetify": "^3.1.10" }, "devDependencies": { "@rushstack/eslint-patch": "^1.2.0", "@types/jsdom": "^21.1.0", "@types/node": "^18.14.2", "@vitejs/plugin-vue": "^4.0.0", "@vitejs/plugin-vue-jsx": "^3.0.0", "@vue/eslint-config-prettier": "^7.1.0", "@vue/eslint-config-typescript": "^11.0.2", "@vue/test-utils": "^2.3.0", "@vue/tsconfig": "^0.1.3", "concurrently": "^7.6.0", "cypress": "^12.7.0", "electron": "^23.1.4", "electron-builder": "^23.6.0", "eslint": "^8.34.0", "eslint-plugin-cypress": "^2.12.1", "eslint-plugin-vue": "^9.9.0", "jsdom": "^21.1.0", "npm-run-all": "^4.1.5", "prettier": "^2.8.4", "start-server-and-test": "^2.0.0", "typescript": "~4.9.5", "vite": "^4.1.4", "vitest": "^0.29.1", "vue-tsc": "^1.2.0", "wait-on": "^7.0.1" } }All reactions