From b37bae822afbb1118d8839c7daa9710d51936672 Mon Sep 17 00:00:00 2001 From: franconicola Date: Sun, 26 Jul 2026 22:22:44 +0200 Subject: [PATCH] chore: drop gitmoji commit enforcement Remove the CI commit-check job and the local commitizen pre-commit hook, both of which required gitmoji-style commit messages via cz-conventional-gitmoji. Switch commitizen to plain conventional commits (still used for version bumping/changelog generation) and update CONTRIBUTING.md accordingly. --- .github/workflows/ci.yml | 27 ------------------ .pre-commit-config.yaml | 7 ----- CONTRIBUTING.md | 4 +-- pyproject.toml | 3 +- uv.lock | 59 +++++++++++++++------------------------- 5 files changed, 25 insertions(+), 75 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5124cb38..43b0bf90 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,33 +10,6 @@ env: UV_VERSION: "0.10.11" jobs: - commit-check: - name: Commit Messages - runs-on: ubuntu-latest - if: github.event_name == 'pull_request' - steps: - - name: Check out code with full history - uses: actions/checkout@v7 - with: - fetch-depth: 0 # Needed for commit range check - - - name: Install uv - uses: astral-sh/setup-uv@v7 - with: - version: ${{ env.UV_VERSION }} - enable-cache: true - - - name: Set up Python - uses: actions/setup-python@v7 - with: - python-version: '3.11' - - - name: Install dependencies - run: uv sync --group dev - - - name: Check commit messages in PR - run: uv run cz check --rev-range ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} - python-checks: name: Linting and Formatting runs-on: ubuntu-latest diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 67c2b153..8066a958 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,11 +1,4 @@ repos: - - repo: https://github.com/commitizen-tools/commitizen - rev: v4.8.3 - hooks: - - id: commitizen - stages: [commit-msg] - additional_dependencies: [cz-conventional-gitmoji==0.7.0] - - repo: https://github.com/astral-sh/ruff-pre-commit # Keep in sync with the ruff version resolved by uv / used in CI # (.github/workflows/ci.yml runs `uv run ruff …`). Version drift here diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e01fc281..5c312bd2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -135,14 +135,14 @@ To set up your environment for local development: 4. (Optional but Recommended) Install pre-commit hooks: ```bash - uv run pre-commit install --hook-type commit-msg --hook-type pre-commit + uv run pre-commit install ``` ## Styleguides ### Git Commit Messages -We follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification. This is enforced locally via pre-commit hooks (if installed) and in our CI pipeline. +We follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification. Commit messages should be structured as follows: diff --git a/pyproject.toml b/pyproject.toml index 3f38247e..b19e2098 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -47,7 +47,6 @@ dev = [ "pytest>=8.3.5", "pre-commit>=4.2.0", "commitizen>=4.7.1", - "cz-conventional-gitmoji>=0.7.0", "pytest-cov>=6.1.1", "pytest-rerunfailures>=14.0", "pytest-xdist>=3.0", @@ -70,7 +69,7 @@ docs = [ hackagent = "hackagent.cli.main:cli" [tool.commitizen] -name = "cz_gitmoji" +name = "cz_conventional_commits" tag_format = "v$version" version_scheme = "pep440" version_provider = "pep621" diff --git a/uv.lock b/uv.lock index 92cf193e..7b2176be 100644 --- a/uv.lock +++ b/uv.lock @@ -929,8 +929,8 @@ name = "cupy-cuda12x" version = "14.1.1" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "cuda-pathfinder" }, - { name = "numpy" }, + { name = "cuda-pathfinder", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, + { name = "numpy", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/dd/18/8ec57a901a11d6955f90e1fbf3e04c8f26721066c99dfa25276e3e3b1f1d/cupy_cuda12x-14.1.1-cp310-cp310-manylinux2014_aarch64.whl", hash = "sha256:909c4b8ac05eee43edfbe791522ee5d593e3504be7bd5c20e2de12b050db2a26", size = 143787561, upload-time = "2026-06-01T04:51:46.125Z" }, @@ -947,19 +947,6 @@ wheels = [ { url = "https://files.pythonhosted.org/packages/a4/80/5e05de89ba61df072aab6f8a6ee3ffeec57db68a0a456825b3b4ce608426/cupy_cuda12x-14.1.1-cp314-cp314t-manylinux2014_x86_64.whl", hash = "sha256:238080487174268d0f09770fe518de7c5b206527bef5c6792aef7ba0626a1c48", size = 132635338, upload-time = "2026-06-01T04:53:35.229Z" }, ] -[[package]] -name = "cz-conventional-gitmoji" -version = "0.7.0" -source = { registry = "https://pypi.org/simple" } -dependencies = [ - { name = "attrs" }, - { name = "commitizen" }, -] -sdist = { url = "https://files.pythonhosted.org/packages/b8/80/5402e92d019860c88772e5d7bcdd812f1e0c7f24b51fdbb503bdb55e64f2/cz_conventional_gitmoji-0.7.0.tar.gz", hash = "sha256:d1a672d570911147cc27a17ba15877e5ef279b91c51a8da9a89523f27325a261", size = 13958, upload-time = "2025-04-01T22:04:16.607Z" } -wheels = [ - { url = "https://files.pythonhosted.org/packages/60/47/3d7d559850a8146bb08adb01486156339d49271aff38e11729707ab996ee/cz_conventional_gitmoji-0.7.0-py3-none-any.whl", hash = "sha256:278b817d306efa5b446db8d078288c42534cfff56662a344da0053c24b50701b", size = 15157, upload-time = "2025-04-01T22:04:15.393Z" }, -] - [[package]] name = "databind" version = "4.5.5" @@ -1211,7 +1198,7 @@ name = "exceptiongroup" version = "1.3.1" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "typing-extensions" }, + { name = "typing-extensions", marker = "python_full_version < '3.11'" }, ] sdist = { url = "https://files.pythonhosted.org/packages/50/79/66800aadf48771f6b62f7eb014e352e5d06856655206165d775e675a02c9/exceptiongroup-1.3.1.tar.gz", hash = "sha256:8b412432c6055b0b7d14c310000ae93352ed6754f70fa8f7c34141f91c4e3219", size = 30371, upload-time = "2025-11-21T23:01:54.787Z" } wheels = [ @@ -1899,7 +1886,6 @@ dependencies = [ dev = [ { name = "anyio" }, { name = "commitizen" }, - { name = "cz-conventional-gitmoji" }, { name = "datamodel-code-generator", extra = ["http", "ruff"] }, { name = "google-adk" }, { name = "mcp" }, @@ -1945,7 +1931,6 @@ requires-dist = [ dev = [ { name = "anyio", specifier = ">=4.3.0" }, { name = "commitizen", specifier = ">=4.7.1" }, - { name = "cz-conventional-gitmoji", specifier = ">=0.7.0" }, { name = "datamodel-code-generator", extras = ["http", "ruff"], specifier = ">=0.54.0" }, { name = "google-adk", specifier = ">=1.4.2" }, { name = "mcp", specifier = ">=1.21.2" }, @@ -2775,7 +2760,7 @@ name = "mlx" version = "0.31.2" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "mlx-metal" }, + { name = "mlx-metal", marker = "sys_platform == 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/29/7c/c16d52494a1ba6d90443f31fa26bc810bf878d532dfa9a7a13f49ef9542d/mlx-0.31.2-cp310-cp310-macosx_14_0_arm64.whl", hash = "sha256:b29cf940f34205f09bb552ac60465ae833c4ae640b52777c6d725ddbad8461ca", size = 586942, upload-time = "2026-04-22T03:14:21.97Z" }, @@ -2800,13 +2785,13 @@ name = "mlx-lm" version = "0.31.3" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "jinja2" }, - { name = "mlx" }, - { name = "numpy" }, - { name = "protobuf" }, - { name = "pyyaml" }, - { name = "sentencepiece" }, - { name = "transformers" }, + { name = "jinja2", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, + { name = "mlx", marker = "sys_platform == 'darwin'" }, + { name = "numpy", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, + { name = "protobuf", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, + { name = "pyyaml", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, + { name = "sentencepiece", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, + { name = "transformers", marker = "python_full_version < '3.14' or sys_platform == 'darwin'" }, ] sdist = { url = "https://files.pythonhosted.org/packages/84/94/9a38d6b0c6fcca995b9136c94eb7da1e9c5165652edf228b96b29960fa7a/mlx_lm-0.31.3.tar.gz", hash = "sha256:61eb0e3ba09444f77f874aff295401d7ccd20b39495cbbce0c782a15474ce733", size = 304318, upload-time = "2026-04-22T07:37:27.922Z" } wheels = [ @@ -3366,7 +3351,7 @@ name = "nvidia-cudnn-cu12" version = "9.10.2.21" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "nvidia-cublas-cu12" }, + { name = "nvidia-cublas-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/ba/51/e123d997aa098c61d029f76663dedbfb9bc8dcf8c60cbd6adbe42f76d049/nvidia_cudnn_cu12-9.10.2.21-py3-none-manylinux_2_27_x86_64.whl", hash = "sha256:949452be657fa16687d0930933f032835951ef0892b37d2d53824d1a84dc97a8", size = 706758467, upload-time = "2025-06-06T21:54:08.597Z" }, @@ -3377,7 +3362,7 @@ name = "nvidia-cufft-cu12" version = "11.3.3.83" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "nvidia-nvjitlink-cu12" }, + { name = "nvidia-nvjitlink-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/1f/13/ee4e00f30e676b66ae65b4f08cb5bcbb8392c03f54f2d5413ea99a5d1c80/nvidia_cufft_cu12-11.3.3.83-py3-none-manylinux2014_x86_64.manylinux_2_17_x86_64.whl", hash = "sha256:4d2dd21ec0b88cf61b62e6b43564355e5222e4a3fb394cac0db101f2dd0d4f74", size = 193118695, upload-time = "2025-03-07T01:45:27.821Z" }, @@ -3404,9 +3389,9 @@ name = "nvidia-cusolver-cu12" version = "11.7.3.90" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "nvidia-cublas-cu12" }, - { name = "nvidia-cusparse-cu12" }, - { name = "nvidia-nvjitlink-cu12" }, + { name = "nvidia-cublas-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, + { name = "nvidia-cusparse-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, + { name = "nvidia-nvjitlink-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/85/48/9a13d2975803e8cf2777d5ed57b87a0b6ca2cc795f9a4f59796a910bfb80/nvidia_cusolver_cu12-11.7.3.90-py3-none-manylinux_2_27_x86_64.whl", hash = "sha256:4376c11ad263152bd50ea295c05370360776f8c3427b30991df774f9fb26c450", size = 267506905, upload-time = "2025-03-07T01:47:16.273Z" }, @@ -3417,7 +3402,7 @@ name = "nvidia-cusparse-cu12" version = "12.5.8.93" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "nvidia-nvjitlink-cu12" }, + { name = "nvidia-nvjitlink-cu12", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/c2/f5/e1854cb2f2bcd4280c44736c93550cc300ff4b8c95ebe370d0aa7d2b473d/nvidia_cusparse_cu12-12.5.8.93-py3-none-manylinux2014_x86_64.manylinux_2_17_x86_64.whl", hash = "sha256:1ec05d76bbbd8b61b06a80e1eaf8cf4959c3d4ce8e711b65ebd0443bb0ebb13b", size = 288216466, upload-time = "2025-03-07T01:48:13.779Z" }, @@ -5652,7 +5637,7 @@ resolution-markers = [ "python_full_version < '3.11'", ] dependencies = [ - { name = "numpy" }, + { name = "numpy", marker = "python_full_version < '3.11'" }, ] sdist = { url = "https://files.pythonhosted.org/packages/0f/37/6964b830433e654ec7485e45a00fc9a27cf868d622838f6b6d9c5ec0d532/scipy-1.15.3.tar.gz", hash = "sha256:eae3cf522bc7df64b42cad3925c876e1b0b6c35c1337c93e12c0f366f55b0eaf", size = 59419214, upload-time = "2025-05-08T16:13:05.955Z" } wheels = [ @@ -5710,7 +5695,7 @@ resolution-markers = [ "python_full_version == '3.11.*'", ] dependencies = [ - { name = "numpy" }, + { name = "numpy", marker = "python_full_version >= '3.11'" }, ] sdist = { url = "https://files.pythonhosted.org/packages/7a/97/5a3609c4f8d58b039179648e62dd220f89864f56f7357f5d4f45c29eb2cc/scipy-1.17.1.tar.gz", hash = "sha256:95d8e012d8cb8816c226aef832200b1d45109ed4464303e997c5b13122b297c0", size = 30573822, upload-time = "2026-02-23T00:26:24.851Z" } wheels = [ @@ -6386,7 +6371,7 @@ name = "triton" version = "3.4.0" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "setuptools" }, + { name = "setuptools", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] wheels = [ { url = "https://files.pythonhosted.org/packages/62/ee/0ee5f64a87eeda19bbad9bc54ae5ca5b98186ed00055281fd40fb4beb10e/triton-3.4.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl", hash = "sha256:7ff2785de9bc02f500e085420273bb5cc9c9bb767584a4aa28d6e360cec70128", size = 155430069, upload-time = "2025-07-30T19:58:21.715Z" }, @@ -6989,8 +6974,8 @@ name = "xformers" version = "0.0.32.post1" source = { registry = "https://pypi.org/simple" } dependencies = [ - { name = "numpy" }, - { name = "torch" }, + { name = "numpy", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, + { name = "torch", marker = "python_full_version < '3.14' or sys_platform != 'darwin'" }, ] sdist = { url = "https://files.pythonhosted.org/packages/6f/33/3b9c4d3d5b2da453d27de891df4ad653ac5795324961aa3a5c15b0353fe6/xformers-0.0.32.post1.tar.gz", hash = "sha256:1de84a45c497c8d92326986508d81f4b0a8c6be4d3d62a29b8ad6048a6ab51e1", size = 12106196, upload-time = "2025-08-14T18:07:45.486Z" } wheels = [